Re: svn commit: r1411629 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

2012-11-23 Thread Daniel Shahaf
Revert r1412515 then? Hyrum K Wright wrote on Fri, Nov 23, 2012 at 15:29:32 -0500: > I did a little poking and fixed this in r1413046. > > > On Fri, Nov 23, 2012 at 2:18 PM, Hyrum K Wright wrote: > > > This test isn't cleaning up after itself (or before a subsequent run). > > The first time I

Re: svn commit: r1413015 - in /subversion/trunk/subversion: svn/propedit-cmd.c svn/propset-cmd.c tests/cmdline/prop_tests.py tests/cmdline/stat_tests.py tests/cmdline/svntest/actions.py

2012-11-23 Thread Daniel Shahaf
br...@apache.org wrote on Fri, Nov 23, 2012 at 18:24:42 -: > Author: brane > Date: Fri Nov 23 18:24:40 2012 > New Revision: 1413015 > > URL: http://svn.apache.org/viewvc?rev=1413015&view=rev > Log: > Fix issue #4261 (require --force to set unknown svn: prop names). > > +def almost_known_prop_

Re: svn commit: r1413109 - in /subversion/trunk: ./ subversion/svnrdump/svnrdump.c subversion/svnrdump/svnrdump.h

2012-11-23 Thread Branko Čibej
On 24.11.2012 01:39, hwri...@apache.org wrote: > Author: hwright > Date: Sat Nov 24 00:39:38 2012 > New Revision: 1413109 > > URL: http://svn.apache.org/viewvc?rev=1413109&view=rev > Log: > Cherrypick r1413107 from the ev2-export branch. I'm going to be brave here > and develop on trunk. The plan

Re: svn commit: r1411629 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

2012-11-23 Thread Hyrum K Wright
I did a little poking and fixed this in r1413046. On Fri, Nov 23, 2012 at 2:18 PM, Hyrum K Wright wrote: > This test isn't cleaning up after itself (or before a subsequent run). > The first time I run it in a working copy, it passes, but the next time, I > get the following error: > > $ ./fs-te

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-23 Thread Ben Reser
On Fri, Nov 23, 2012 at 9:09 AM, Branko Čibej wrote: > No. The check specifically looks for a three-letter prefix ending in a > colon, and allows only one wrong character or transposition. It will > flag svm: but not tsvn:. svk would pop up for anyone still using (no idea if anyone does) SVK. >

Re: svn commit: r1411629 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

2012-11-23 Thread Hyrum K Wright
This test isn't cleaning up after itself (or before a subsequent run). The first time I run it in a working copy, it passes, but the next time, I get the following error: $ ./fs-test 37 subversion/tests/libsvn_fs/fs-test.c:4908: (apr_err=160033) subversion/tests/svn_test_fs.c:183: (apr_err=160033

Re: svnmucc: trivial spelling error in help message

2012-11-23 Thread Julian Foad
sebb wrote: > The text: > > --config-option ARG  use ARG so override a configuration option\ > > should presumably be: > > --config-option ARG  use ARG to override a configuration option\ > > i.e. change "so" to "to". I'm on trivia duty today. Thanks!  Fixed on trunk in r1413033. - Juli

svnmucc: trivial spelling error in help message

2012-11-23 Thread sebb
The text: --config-option ARG use ARG so override a configuration option\ should presumably be: --config-option ARG use ARG to override a configuration option\ i.e. change "so" to "to".

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-23 Thread Branko Čibej
On 23.11.2012 17:17, Mark Phippard wrote: > Personally, I think checking for mis-spellings in "svn:" goes too far. > For example, do these checks interfere with setting any of the tsvn: > properties? No. The check specifically looks for a three-letter prefix ending in a colon, and allows only one

Re: svn commit: r1412911 - in /subversion/trunk: subversion/libsvn_fs_fs/fs_fs.c subversion/libsvn_repos/reporter.c tools/client-side/svn-bench/null-log-cmd.c tools/server-side/fsfs-reorg.c

2012-11-23 Thread Philip Martin
Julian Foad writes: > subversion/libsvn_subr/cmdline.c:621:26: ISO C forbids passing argument 3 of > 'svn_auth_set_parameter' between function pointer and 'void *' ISO C allows function pointers and void * to be a different sizes but POSIX's dlsym(3) more-or-less guarantees they are the same si

Re: svn commit: r1412911 - in /subversion/trunk: subversion/libsvn_fs_fs/fs_fs.c subversion/libsvn_repos/reporter.c tools/client-side/svn-bench/null-log-cmd.c tools/server-side/fsfs-reorg.c

2012-11-23 Thread Julian Foad
Bert Huijben wrote: > I can easily make these cases a compile error with Visual C++, > but that will probably make other developers call it a broken/ > old/(fill in your own curse word) compiler for following such > an old standard. >  > Suggestions? Honestly, I would like to suggest that we fin

Re: problems committing with serf

2012-11-23 Thread Stefan Küng
On 23.11.2012 17:20, Philip Martin wrote: Stefan Küng writes: Sending. svn: E175002: Commit failed (details follow): svn: E175002: MKACTIVITY request on '/svn/!svn/act/4b7f5c8e-5e27-f145-929b-dfe9f 7297de5' failed: 405 Method Not Allowed svn: E175002: DELETE request on '/svn/!svn/act/4

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-23 Thread Julian Foad
Branko Čibej wrote: > On 23.11.2012 15:35, Julian Foad wrote: >> In file included from subversion/libsvn_delta/compat.c:36:0: >> ./subversion/svn_private_config.h:236:7: > "SVN_QSORT_R_NORMAL_ARG_ORDER" is not defined [...] > > Julian, we've had this discussion before. I'm not going to change

Re: problems committing with serf

2012-11-23 Thread Philip Martin
Stefan Küng writes: > Sending. > svn: E175002: Commit failed (details follow): > svn: E175002: MKACTIVITY request on > '/svn/!svn/act/4b7f5c8e-5e27-f145-929b-dfe9f > 7297de5' failed: 405 Method Not Allowed > svn: E175002: DELETE request on > '/svn/!svn/act/4b7f5c8e-5e27-f145-929b-dfe9f7

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-23 Thread Mark Phippard
On Fri, Nov 23, 2012 at 5:43 AM, Branko Čibej wrote: > On 19.11.2012 03:50, Julian Foad wrote: >> Proposal: >> >> For any unrecognized property name in the 'svn:' name space, these would >> bail out with an error unless '--force' is given: >> >> svn pset svn:foo >> svn pedit svn:foo >> >> and

RE: svn commit: r1412911 - in /subversion/trunk: subversion/libsvn_fs_fs/fs_fs.c subversion/libsvn_repos/reporter.c tools/client-side/svn-bench/null-log-cmd.c tools/server-side/fsfs-reorg.c

2012-11-23 Thread Bert Huijben
I can easily make these cases a compile error with Visual C++, but that will probably make other developers call it a broken/old/(fill in your own curse word) compiler for following such an old standard. Suggestions? Bert *From:* julianf...@apache.org *Sent:* November 23, 2012 4:19 PM *To:* com

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-23 Thread Branko Čibej
On 23.11.2012 16:31, Daniel Shahaf wrote: > Branko Čibej wrote on Fri, Nov 23, 2012 at 15:59:16 +0100: >> On 23.11.2012 15:35, Julian Foad wrote: >>> In file included from subversion/libsvn_delta/compat.c:36:0: >>> ./subversion/svn_private_config.h:236:7: "SVN_QSORT_R_NORMAL_ARG_ORDER" is >>> not

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-23 Thread Daniel Shahaf
Daniel Shahaf wrote on Fri, Nov 23, 2012 at 17:31:05 +0200: > Branko Čibej wrote on Fri, Nov 23, 2012 at 15:59:16 +0100: > > On 23.11.2012 15:35, Julian Foad wrote: > > > In file included from subversion/libsvn_delta/compat.c:36:0: > > > ./subversion/svn_private_config.h:236:7: "SVN_QSORT_R_NORMAL_

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-23 Thread Daniel Shahaf
Branko Čibej wrote on Fri, Nov 23, 2012 at 15:59:16 +0100: > On 23.11.2012 15:35, Julian Foad wrote: > > In file included from subversion/libsvn_delta/compat.c:36:0: > > ./subversion/svn_private_config.h:236:7: "SVN_QSORT_R_NORMAL_ARG_ORDER" is > > not defined > > -- > > In file included from subv

Re: svn commit: r1412554 - in /subversion/trunk/subversion: include/private/svn_string_private.h libsvn_subr/string.c tests/libsvn_subr/string-test.c

2012-11-23 Thread Julian Foad
Branko Čibej wrote: > On 22.11.2012 17:22, Julian Foad wrote: >> Unfortunately our C'89 coding standard doesn't allow us to use >> non-constant initializers, and there are some compilers occasionally >> used to build Subversion that don't accept it. > > Heh, by the way: > > subversion/libsvn_f

problems committing with serf

2012-11-23 Thread Stefan Küng
Hi, using the latest build from 1.7.x with serf configured. I'm trying to commit changes to a working copy to a Google code repository, this fails with: Sending. svn: E175002: Commit failed (details follow): svn: E175002: MKACTIVITY request on '/svn/!svn/act/4b7f5c8e-5e27-f145-929b-df

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-23 Thread Branko Čibej
On 23.11.2012 15:35, Julian Foad wrote: > In file included from subversion/libsvn_delta/compat.c:36:0: > ./subversion/svn_private_config.h:236:7: "SVN_QSORT_R_NORMAL_ARG_ORDER" is > not defined > -- > In file included from subversion/libsvn_delta/svndiff.c:31:0: > ./subversion/svn_private_config.h

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-23 Thread Julian Foad
In file included from subversion/libsvn_delta/compat.c:36:0: ./subversion/svn_private_config.h:236:7: "SVN_QSORT_R_NORMAL_ARG_ORDER" is not defined -- In file included from subversion/libsvn_delta/svndiff.c:31:0: ./subversion/svn_private_config.h:236:7: "SVN_QSORT_R_NORMAL_ARG_ORDER" is not defin

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-23 Thread Branko Čibej
On 23.11.2012 12:58, Daniel Shahaf wrote: > Branko Čibej wrote on Fri, Nov 23, 2012 at 11:43:29 +0100: >> $ svn ps svm:ignore x . >> svn: E195011: 'svm:ignore' is not a valid svn: property name; did you mean >> 'svn:ignore'? >> (Use --force if you're sure about 'svm:ignore'.) > > "To set the 'svm:

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-23 Thread Daniel Shahaf
Branko Čibej wrote on Fri, Nov 23, 2012 at 11:43:29 +0100: > On 19.11.2012 03:50, Julian Foad wrote: > > Proposal: > > > > For any unrecognized property name in the 'svn:' name space, these would > > bail out with an error unless '--force' is given: > > > > svn pset svn:foo > > svn pedit svn:f

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-23 Thread Branko Čibej
On 19.11.2012 03:50, Julian Foad wrote: > Proposal: > > For any unrecognized property name in the 'svn:' name space, these would bail > out with an error unless '--force' is given: > > svn pset svn:foo > svn pedit svn:foo > > and all other subcommands where properties are handled would continu

Re: svn commit: r1412554 - in /subversion/trunk/subversion: include/private/svn_string_private.h libsvn_subr/string.c tests/libsvn_subr/string-test.c

2012-11-23 Thread Branko Čibej
On 22.11.2012 17:22, Julian Foad wrote: >> Author: brane >> Date: Thu Nov 22 14:00:48 2012 >> New Revision: 1412554 >> Modified: subversion/trunk/subversion/libsvn_subr/string.c >> svn_cstring__similarity(const char *stra, const char *strb, >> svn_membuf_t *buffer, apr_size