I can easily make these cases a compile error with Visual C++, but that will probably make other developers call it a broken/old/(fill in your own curse word) compiler for following such an old standard.
Suggestions? Bert *From:* julianf...@apache.org *Sent:* November 23, 2012 4:19 PM *To:* comm...@subversion.apache.org *Subject:* svn commit: r1412911 - in /subversion/trunk: subversion/libsvn_fs_fs/fs_fs.c subversion/libsvn_repos/reporter.c tools/client-side/svn-bench/null-log-cmd.c tools/server-side/fsfs-reorg.c Author: julianfoad Date: Fri Nov 23 15:18:48 2012 New Revision: 1412911 URL: http://svn.apache.org/viewvc?rev=1412911&view=rev Log: Do not use non-constant initializers in struct variables, since this violates our C'89 coding standard. Although most compilers used for Subversion support non-constant initializers, some do not, such as Solaris SunPRO. Note that GCC requires the '-pedantic' option to report this. A previous commit of this kind was r1352068.