Re: svn commit: r1350021 - in /subversion/trunk/subversion: libsvn_subr/adler32.c libsvn_subr/cache-membuffer.c libsvn_subr/cache.c libsvn_subr/string.c mod_authz_svn/mod_authz_svn.c svnserve/main.c

Adjust the log message to note the incorrect main change, and the revision where it was reverted? On Jun 13, 2012 11:22 PM, wrote: > Author: stefan2 > Date: Wed Jun 13 21:22:24 2012 > New Revision: 1350021 > > URL: http://svn.apache.org/viewvc?rev=1350021&view=rev > Log: > Silence more GCC conver

Re: [Issue 3981] serf infinite loop over https

I think the assert is due to something. I'm doing some work on property handling and the same assert is triggering consistently, so I should be able to track it. I'll add details to the new bug. On Jun 14, 2012 12:19 AM, "Philip Martin" wrote: > Justin Erenkrantz writes: > > > (I do not have an

How high are the revision numbers in your repo?

Hi Hyrum, Just got home and saw your question on IRC. Here are the statistics on our svn repositories: N is 105 sum is 51557790 meanis 491026.571428571 SD Nis 1609852.27973539 SD N-1 is 1617573.43808371 min is 1 25% is 5 50% is 3028 75% is 35981 90% is 714

RE: svn commit: r1349944 - /subversion/trunk/gen-make.py

> -Original Message- > From: Hyrum K Wright [mailto:hyrum.wri...@wandisco.com] > Sent: Thursday, June 14, 2012 12:33 AM > To: Bert Huijben > Cc: Michael Pilato; Subversion Development > Subject: Re: svn commit: r1349944 - /subversion/trunk/gen-make.py > > On Wed, Jun 13, 2012 at 9:45 PM,

Re: svn commit: r1349944 - /subversion/trunk/gen-make.py

On Wed, Jun 13, 2012 at 9:45 PM, Bert Huijben wrote: > > >> -Original Message- >> From: C. Michael Pilato [mailto:cmpil...@collab.net] >> Sent: Wednesday, June 13, 2012 9:34 PM >> To: dev@subversion.apache.org >> Cc: Hyrum K Wright; comm...@subversion.apache.org >> Subject: Re: svn commit:

Re: [Issue 3981] serf infinite loop over https

Justin Erenkrantz writes: > (I do not have an easy way to login to the issue tracker from my iPad...so, > moving back to the list...) > > I really do not think the assert is due to memory corruption - nothing I > saw indicated that was happening. I think it is far more likely that there > is ano

Re: serf w/SurfShield crash in authz_tests.py#15

handler->handler_pool is somehow NULL when we invoke get_locations. Weird. Perhaps you can throw some printf's before the get_locations call to see if it is indeed NULL and not an artifact of the trace. A quick glance at the code shows handler_pool should be set in add_file correctly. -- justin

Re: [Issue 3981] serf infinite loop over https

(I do not have an easy way to login to the issue tracker from my iPad...so, moving back to the list...) I really do not think the assert is due to memory corruption - nothing I saw indicated that was happening. I think it is far more likely that there is another bug somewhere. (It is the simples

serf w/SurfShield crash in authz_tests.py#15

Justin (or anyone), With latest trunk (@1349944) I get a crash in authz_tests.py 15 ("authz issue #3242 - access required at repo root") when running with serf and my AVG SurfShield enabled. Possibly also other tests crash (I'll do a full run later tonight). With SurfShield disabled, there is no c

RE: svn commit: r1349944 - /subversion/trunk/gen-make.py

> -Original Message- > From: C. Michael Pilato [mailto:cmpil...@collab.net] > Sent: Wednesday, June 13, 2012 9:34 PM > To: dev@subversion.apache.org > Cc: Hyrum K Wright; comm...@subversion.apache.org > Subject: Re: svn commit: r1349944 - /subversion/trunk/gen-make.py > > On 06/13/2012 0

Re: svn commit: r1349944 - /subversion/trunk/gen-make.py

C. Michael Pilato wrote on Wed, Jun 13, 2012 at 21:33:53 +0200: > On 06/13/2012 07:36 PM, Hyrum K Wright wrote: > > On Wed, Jun 13, 2012 at 6:10 PM, wrote: > >> Author: rhuijben > >> Date: Wed Jun 13 16:10:25 2012 > >> New Revision: 1349944 > >> > >> URL: http://svn.apache.org/viewvc?rev=1349944&

Re: svn commit: r1349944 - /subversion/trunk/gen-make.py

On 06/13/2012 07:36 PM, Hyrum K Wright wrote: > On Wed, Jun 13, 2012 at 6:10 PM, wrote: >> Author: rhuijben >> Date: Wed Jun 13 16:10:25 2012 >> New Revision: 1349944 >> >> URL: http://svn.apache.org/viewvc?rev=1349944&view=rev >> Log: >> * gen-make.py >> Make the --with-neon= and --without-neon

AW: [PATCH]: Optimize merge_file_trivial()

Hi, Julian, [Re-Post, because I did forget to actually attach the patch...] Here's the second round. I hope I did catch all issues. As there were no comments about the names and the parameter order, I guess they're okay. The tests still look well: Summary of test results: 1619 tests PASSED

AW: [PATCH]: Optimize merge_file_trivial()

Hi, Julian, Here's the second round. I hope I did catch all issues. As there were no comments about the names and the parameter order, I guess they're okay. The tests still look well: Summary of test results: 1619 tests PASSED 85 tests SKIPPED 38 tests XFAILED (1 WORK-IN-PROGRESS) [[ Op

Re: svn commit: r1349944 - /subversion/trunk/gen-make.py

On Wed, Jun 13, 2012 at 6:10 PM, wrote: > Author: rhuijben > Date: Wed Jun 13 16:10:25 2012 > New Revision: 1349944 > > URL: http://svn.apache.org/viewvc?rev=1349944&view=rev > Log: > * gen-make.py >  Make the --with-neon= and --without-neon arguments on gen-make.py optional, >  just like how ./c

Re: Retrieve pristine version of a replaced file via the svn api

On 13.06.2012 17:10, Julian Foad wrote: > Branko Čibej wrote: > >> However, I shall now >> demonstrate that Subversion already provides that functionality: > This demo doesn't seem to include the replacement of a node, which is the > case in question. Well sure, It's not intended to; after all, t

Re: Retrieve pristine version of a replaced file via the svn api

Branko Čibej wrote: > On 13.06.2012 16:33, Julian Foad wrote: >> I think this is a valid enhancement request: to have an API to get the >> WC base tree (not what the UI calls "base", but the result of the last >> checkout/update, which is called BASE (usually with capital letters) >> in libsvn

Re: AW: [PATCH]: Optimize merge_file_trivial() (Was: Fix issue #4128)

Markus Schaber wrote: >> Please use 'TRUE' and 'FALSE' for Boolean values in the code and in the doc >> strings, not zero and non-zero. > > I did just copy this from the 2-file functions that existed. I'll update the > patch accordingly. Ah, I see.  I've fixed those in r1349889. As for auto s

Re: Retrieve pristine version of a replaced file via the svn api

On 13.06.2012 16:33, Julian Foad wrote: > (I'm not cross-posting to users@.) > > I think this is a valid enhancement request: to have an API to get the WC > base tree (not what the UI calls "base", but the result of the last > checkout/update, which is called BASE (usually with capital letters) i

AW: [PATCH]: Optimize merge_file_trivial() (Was: Fix issue #4128)

Hi, Julian, > Please use 'TRUE' and 'FALSE' for Boolean values in the code and in the doc > strings, not zero and non-zero. I did just copy this from the 2-file functions that existed. I'll update the patch accordingly. > Please replace 'rsp' with 'and' or 'or' in the doc strings. See >

Re: Retrieve pristine version of a replaced file via the svn api

(I'm not cross-posting to users@.) I think this is a valid enhancement request: to have an API to get the WC base tree (not what the UI calls "base", but the result of the last checkout/update, which is called BASE (usually with capital letters) in libsvn_wc).  By "get the tree" I mean an API t

Re: Retrieve pristine version of a replaced file via the svn api

On 13.06.2012 13:59, Roghair, Frank wrote: > Hi All, > > Developers in our organization need to have their changes reviewed before the > commit is allowed. All that effort, just to avoid using per-task branches and doing the review before merging to the mainline. -- Brane

Retrieve pristine version of a replaced file via the svn api

Hi All, Developers in our organization need to have their changes reviewed before the commit is allowed. For this purpose a customized tool was created called createReviewChangeSet.exe. The tool does create a zip file containing a text file "changeSet.txt" which contains the change list with a e

Re: [PATCH]: Optimize merge_file_trivial() (Was: Fix issue #4128)

Hi Markus.  Only some stylistic comments from me; the basic idea looks fine. Please use 'TRUE' and 'FALSE' for Boolean values in the code and in the doc strings, not zero and non-zero. Please replace 'rsp' with 'and' or 'or' in the doc strings.  See

Re: (df) diff full

On 06/12/2012 11:52 PM, C. Michael Pilato wrote: > Per subversion/svn/conflict-callbacks.c:show_diff(): > > if (desc->merged_file && desc->base_abspath) > { > /* Show the conflict markers to the user */ > path1 = desc->base_abspath; > path2 = desc->merged_file; > } >

[PATCH]: Optimize merge_file_trivial() (Was: Fix issue #4128)

Hi, all, Von: Philip Martin [philip.mar...@wandisco.com] >> [Context: merge_file_trivial() in merge.c] > > I wonder if we could reduce the file IO by comparing all three files in > one operation instead of two operations on pairs of files? In follow-up to my last patch fixing issue #4128, the fol

Re: Patch to remove libsvn_ra_neon

On Wed, Jun 13, 2012 at 12:20:20AM +0200, Hyrum K Wright wrote: > On Tue, Jun 12, 2012 at 11:57 PM, Stefan Sperling wrote: > > On Tue, Jun 12, 2012 at 01:47:13PM +0200, Hyrum K Wright wrote: > >> We've had the "should we remove neon?" discussion before, and the > >> consensus has felt to resolve i

Re: Patch to remove libsvn_ra_neon

On Wed, Jun 13, 2012 at 9:33 AM, Greg Stein wrote: > On Tue, Jun 12, 2012 at 7:47 AM, Hyrum K Wright > wrote: >> We've had the "should we remove neon?" discussion before, and the >> consensus has felt to resolve in the affirmative.  Now is the time for >> action. >> >> I've got a 586 kb patch whi

Re: svn commit: r1349661 - /subversion/trunk/subversion/libsvn_subr/cache-memcache.c

On Wed, Jun 13, 2012 at 9:22 AM, wrote: > Author: gstein > Date: Wed Jun 13 07:22:00 2012 > New Revision: 1349661 > > URL: http://svn.apache.org/viewvc?rev=1349661&view=rev > Log: > Followup to r1349277: old APRs do not have APR_INT16_MAX > > * subversion/libsvn_subr/cache-memcache.c: >  (...): d

Re: Patch to remove libsvn_ra_neon

On Tue, Jun 12, 2012 at 7:47 AM, Hyrum K Wright wrote: > We've had the "should we remove neon?" discussion before, and the > consensus has felt to resolve in the affirmative.  Now is the time for > action. > > I've got a 586 kb patch which removes libsvn_ra_neon from trunk.  It > doesn't not remov

Re: Patch to remove libsvn_ra_neon

On Tue, Jun 12, 2012 at 5:57 PM, Stefan Sperling wrote: > On Tue, Jun 12, 2012 at 01:47:13PM +0200, Hyrum K Wright wrote: >> We've had the "should we remove neon?" discussion before, and the >> consensus has felt to resolve in the affirmative.  Now is the time for >> action. > > We should move thi