Markus Schaber wrote: >> Please use 'TRUE' and 'FALSE' for Boolean values in the code and in the doc >> strings, not zero and non-zero. > > I did just copy this from the 2-file functions that existed. I'll update the > patch accordingly.
Ah, I see. I've fixed those in r1349889. As for auto source formatting, I have settings for the Vim text editor, but I don't know about VS or a stand-alone tool. - Julian >> Please replace 'rsp' with 'and' or 'or' in the doc strings. See >> <http://www.transblawg.eu/index.php?/archives/870-Resp.-and-other-non-existent-English-wordsNicht-existente-englische-Woerter.html> >> :-) > >> Please don't initialize variables that are going to be unconditionally >> initialized later: variables 'file1_h', 'file2_h', 'file3_h' in >> contents_three_identical_p(). > > I'll fix both issues, too. > >> Please make all the indentation consistent, and put operators on the >> beginning of each continuation line indented to just inside the relevant >> opening parenthesis, so instead of this: > > Is there some reformatter script or (even better) visual studio plugin that > implements all the formatting rules? > > Best regards > > Markus Schaber
