Safe to add a field to svn_error_t?

2010-12-23 Thread Blair Zajac
The addition of "tracing" to svn_error_t in 1.7 currently uses a special message string "traced call". Instead of doing this, can we safely add an svn_boolean_t to svn_error_t the indicates if it is a traced error? While svn_error_t is public, I'm hoping most people are creating them with svn

Re: svn commit: r1052151 - /subversion/trunk/tools/server-side/svn-populate-node-origins-index.c

2010-12-23 Thread Blair Zajac
On 12/23/10 2:07 AM, Julian Foad wrote: bl...@apache.org wrote: URL: http://svn.apache.org/viewvc?rev=1052151&view=rev Log: Remove a gcc "implicit conversion shortens 64-bit value into a 32-bit value" warning. tools/server-side/svn-populate-node-origins-index.c:140: warning: format ‘%ld’ expec

Re: svn_error_purge_tracing() and clearing the errors Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-23 Thread Blair Zajac
On 12/23/10 3:01 AM, Daniel Shahaf wrote: I've made a quick sketch --- looks good? The suggestions look good. We could add some more tests, checking the behavior with SVN_NO_ERROR input and one where all errors are tracing, which should return an error from SVN_ERR_ASSERT(). As an aside, t

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-23 Thread Johan Corveleyn
On Thu, Dec 23, 2010 at 11:43 PM, Gavin Beau Baumanis wrote: > On 23/12/2010, at 11:36 PM, Johan Corveleyn wrote: > >> On Thu, Dec 23, 2010 at 3:44 AM, Gavin Beau Baumanis >> wrote: >>> Hi Johan, >> >> Hi Gavin. Thanks for your interest. It's a nice problem isn't it? > > Yes - it "should be" so v

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-23 Thread Gavin Beau Baumanis
On 23/12/2010, at 11:36 PM, Johan Corveleyn wrote: > On Thu, Dec 23, 2010 at 3:44 AM, Gavin Beau Baumanis > wrote: >> Hi Johan, > > Hi Gavin. Thanks for your interest. It's a nice problem isn't it? Yes - it "should be" so very simple... but a little thought - and before you know it - it's not

Re: Commercial versus Community support at Subversion

2010-12-23 Thread Benson Margulies
Stefan, Thanks for the long reply. I find myself in a somewhat humorous situation here. One of the people who works for me has wondered, for some time, if it made sense for us to have a support contract with one of the providers of those around svn. So, when we hit this particular problem, he fel

Re: svn commit: r1051745 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

2010-12-23 Thread Kamesh Jayachandran
On 12/22/2010 07:21 PM, Hyrum K. Wright wrote: On Wed, Dec 22, 2010 at 1:15 AM, Kamesh Jayachandran wrote: On 12/22/2010 09:38 AM, bl...@apache.org wrote: Author: blair Date: Wed Dec 22 04:08:14 2010 New Revision: 1051745 URL: http://svn.apache.org/viewvc?rev=1051745&view=rev Log: Update test

Re: Commercial versus Community support at Subversion

2010-12-23 Thread Stefan Sperling
On Thu, Dec 23, 2010 at 08:01:56AM -0500, Benson Margulies wrote: > Hello SVN development community, > > Yesterday, a sales person from a company which I will not name here > sent us an email message that I will quote, below. > > There's nothing wrong with companies selling the services of > cont

Commercial versus Community support at Subversion

2010-12-23 Thread Benson Margulies
Hello SVN development community, Yesterday, a sales person from a company which I will not name here sent us an email message that I will quote, below. There's nothing wrong with companies selling the services of contributors. However, this email message claims that the 'only' way that an issue i

Re: How to delete particular revision of file from SVN Repos

2010-12-23 Thread Hyrum K Wright
On Thu, Dec 23, 2010 at 2:33 AM, stsivaraj wrote: > > Hi All, >         I am using Subversion version1.2 and need one favour. I have > written code to delete particular revision from SVN Repository. > Unfortunately, i couldn't delete particular version from repository. Any one > can response me..

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-23 Thread Johan Corveleyn
On Thu, Dec 23, 2010 at 3:44 AM, Gavin Beau Baumanis wrote: > Hi Johan, Hi Gavin. Thanks for your interest. It's a nice problem isn't it? > I was intrigued by your requirement to create a large file for testing. > I remember from a really long time ago when I learnt C, that we used a > specific

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-23 Thread Johan Corveleyn
On Thu, Dec 23, 2010 at 1:05 PM, Julian Foad wrote: > On Thu, 2010-12-23, Daniel Shahaf wrote: >> Daniel Shahaf wrote on Thu, Dec 23, 2010 at 13:25:40 +0200: >> > Johan Corveleyn wrote on Thu, Dec 23, 2010 at 01:51:08 +0100: >> > > Yes, that's a good idea. I'll try to spend some time on that. But

Re: [PATCH] svn info - changing hard coded error message to specific one.

2010-12-23 Thread Julian Foad
>From IRC: julianf: We changed error codes in libsvn_wc all over the place. I don't think we see strict error codes as part of the documented behavior, unless it is in the function documentation Bert: OK, but I wonder if we really should accept changes to a libsvn_client response (which this is

Re: [PATCH] svn info - changing hard coded error message to specific one.

2010-12-23 Thread Noorul Islam K M
Daniel Shahaf writes: > Noorul Islam K M wrote on Thu, Dec 23, 2010 at 15:53:58 +0530: > >> >> Forwarding one of the threads to dev@ with [PATCH] tag so that this gets >> attention of more people. Julian said on IRC, >> >> noorul: Now we're into the realm of changing behaviour. If the >> erro

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-23 Thread Julian Foad
On Thu, 2010-12-23, Daniel Shahaf wrote: > Daniel Shahaf wrote on Thu, Dec 23, 2010 at 13:25:40 +0200: > > Johan Corveleyn wrote on Thu, Dec 23, 2010 at 01:51:08 +0100: > > > Yes, that's a good idea. I'll try to spend some time on that. But I'm > > > wondering about a good way to write such a scrip

Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-23 Thread Julian Foad
Daniel Shahaf wrote: > Julian Foad wrote on Wed, Dec 22, 2010 at 16:43:16 +: > > GCC. > > > > From the output of "make": > > > > [...]/libtool --tag=CC --silent --mode=link gcc -Wno-system-headers > > -Wold-style-definition -Wdeclaration-after-statement -Wpointer-arith > > -Wwrite-strings -W

Re: [PATCH] Issue #3653: svn update should not output svn:external fetches if they have not been updated

2010-12-23 Thread Daniel Shahaf
Tijn Porcelijn wrote on Thu, Dec 23, 2010 at 00:09:32 -0800: > Hi Daniel, > > Here's my previous mail as plain text (utf8). > Thanks, much better. (I forgot to say that I asked for plain texts only in future mails --- i.e., I didn't mean to ask you to re-send this one --- but thanks anyway for

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-23 Thread Daniel Shahaf
Daniel Shahaf wrote on Thu, Dec 23, 2010 at 13:25:40 +0200: > Johan Corveleyn wrote on Thu, Dec 23, 2010 at 01:51:08 +0100: > > On Wed, Dec 22, 2010 at 11:50 AM, Philip Martin > > wrote: > > > Johan Corveleyn writes: > > > > > >> On Mon, Dec 20, 2010 at 11:19 AM, Philip Martin > > >> wrote: > >

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-23 Thread Daniel Shahaf
Johan Corveleyn wrote on Thu, Dec 23, 2010 at 01:51:08 +0100: > As a first attempt, I quickly hacked up a small shell script, writing > out lines in a for loop, one by one, with a fixed string together with > the line number (index of the iteration). But that's too slow (1 > lines of 70 bytes,

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-23 Thread Daniel Shahaf
Johan Corveleyn wrote on Thu, Dec 23, 2010 at 01:51:08 +0100: > On Wed, Dec 22, 2010 at 11:50 AM, Philip Martin > wrote: > > Johan Corveleyn writes: > > > >> On Mon, Dec 20, 2010 at 11:19 AM, Philip Martin > >> wrote: > >>> Johan Corveleyn writes: > >>> > This makes the diff algorithm anot

Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-23 Thread Daniel Shahaf
Julian Foad wrote on Wed, Dec 22, 2010 at 16:43:16 +: > On Wed, 2010-12-22, Blair Zajac wrote: > > On 12/22/10 4:36 AM, Julian Foad wrote: > > > subversion/libsvn_repos/commit.c:648: no previous prototype for > > > 'svn_repos__post_commit_error_str' > > > > Thanks, fixed in r1051968. > > > >

Re: [PATCH] svn info - changing hard coded error message to specific one.

2010-12-23 Thread Daniel Shahaf
Noorul Islam K M wrote on Thu, Dec 23, 2010 at 15:53:58 +0530: > > Forwarding one of the threads to dev@ with [PATCH] tag so that this gets > attention of more people. Julian said on IRC, > > noorul: Now we're into the realm of changing behaviour. If the error > code returned from libsvn

Re: svn_error_purge_tracing() and clearing the errors Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-23 Thread Daniel Shahaf
Blair Zajac wrote on Wed, Dec 22, 2010 at 22:26:15 -0800: > On 12/22/10 4:38 PM, Daniel Shahaf wrote: >> Blair Zajac wrote on Wed, Dec 22, 2010 at 13:22:11 -0800: >>> On 12/22/10 10:56 AM, Daniel Shahaf wrote: Blair Zajac wrote on Wed, Dec 22, 2010 at 10:45:12 -0800: > It seems the best th

[PATCH] svn info - changing hard coded error message to specific one.

2010-12-23 Thread Noorul Islam K M
Forwarding one of the threads to dev@ with [PATCH] tag so that this gets attention of more people. Julian said on IRC, noorul: Now we're into the realm of changing behaviour. If the error code returned from libsvn_client is different in 1.7 from what it was in 1.6, maybe that

Re: svn commit: r1052151 - /subversion/trunk/tools/server-side/svn-populate-node-origins-index.c

2010-12-23 Thread Julian Foad
bl...@apache.org wrote: > URL: http://svn.apache.org/viewvc?rev=1052151&view=rev > Log: > Remove a gcc "implicit conversion shortens 64-bit value into a 32-bit > value" warning. tools/server-side/svn-populate-node-origins-index.c:140: warning: format ‘%ld’ expects type ‘long int’, but argument 3 h

Re: Input validation observations - svn info - changing "(Not a valid URL)" to the specific error message

2010-12-23 Thread Noorul Islam K M
Noorul Islam K M writes: > Julian Foad writes: > >> Re: >> * "svn info ^/b" -> "Not a valid URL"; should be "path '/b' not found >> in revision REV"? >> >> On Wed, 2010-12-08, Noorul Islam K M wrote: >> [...] >>> One of the solution that you suggested was to keep what the existing >>> code is

Re: Input validation observations - svn info - changing "(Not a valid URL)" to the specific error message

2010-12-23 Thread Noorul Islam K M
Julian Foad writes: > Re: > * "svn info ^/b" -> "Not a valid URL"; should be "path '/b' not found > in revision REV"? > > On Wed, 2010-12-08, Noorul Islam K M wrote: > [...] >> One of the solution that you suggested was to keep what the existing >> code is doing but saying something more helpfu

How to delete particular revision of file from SVN Repos

2010-12-23 Thread stsivaraj
Hi All, I am using Subversion version1.2 and need one favour. I have written code to delete particular revision from SVN Repository. Unfortunately, i couldn't delete particular version from repository. Any one can response me.. how to delete? public void deleteDocRevision(String collDir,

Re: [PATCH] Issue #3653: svn update should not output svn:external fetches if they have not been updated

2010-12-23 Thread Tijn Porcelijn
Hi Daniel, Here's my previous mail as plain text (utf8). tijn On 2010-12-22 14:02, Daniel Shahaf wrote: > > Forwarding back to the list. > > Tijn Porcelijn wrote on Wed, Dec 22, 2010 at 01:54:07 -0800: > > Hi Daniel, > > > > I guess you're right. It makes more sense to echo the external URL > >