Julian Foad wrote on Wed, Dec 22, 2010 at 16:43:16 +0000: > On Wed, 2010-12-22, Blair Zajac wrote: > > On 12/22/10 4:36 AM, Julian Foad wrote: > > > subversion/libsvn_repos/commit.c:648: no previous prototype for > > > 'svn_repos__post_commit_error_str' > > > > Thanks, fixed in r1051968. > > > > Which compiler are you using that gives this warning? > > GCC. > > >From the output of "make": > > [...]/libtool --tag=CC --silent --mode=link gcc -Wno-system-headers > -Wold-style-definition -Wdeclaration-after-statement -Wpointer-arith > -Wwrite-strings -Wshadow -ansi -Wall -Wformat=2 -Wunused > -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes > -Wmissing-declarations -Wno-multichar -Wredundant-decls -Wnested-externs > -Wunreachable-code -Winline -Wno-long-long -g -DAPR_POOL_DEBUG -Wundef > -Wendif-labels -Wcast-qual -Wno-deprecated-declarations > -Wno-unreachable-code -Wno-format-nonliteral -pthread > -D_LARGEFILE64_SOURCE -DNE_LFS -Werror=implicit-function-declaration > -DSVN_DEBUG -DAP_DEBUG [...] > > (The first group of options are inserted by Subversion's configury, and > my config/build/test script sets CFLAGS to "-g -O -DAPR_POOL_DEBUG > -Wundef -Wendif-labels
> -Wcast-qual This one generates a couple dozen warnings for me.... > -Wno-deprecated-declarations -Wno-unreachable-code -Wno-format-nonliteral".) With these three, I now have a warning-free build --- thanks! (after r1052225, and modulo the svn-populate-node-origin issue from yesterday) > > - Julian > > Daniel (using gcc 4.3.2 on Debian)
