Re: Default commandline args

2010-12-20 Thread Stefan Sperling
On Mon, Dec 20, 2010 at 10:34:46PM -0800, Blair Zajac wrote: > What about ~/.subversion/cli or ~/.subversion/command-line-client. > If somebody wants to copy an existing configuration from another > user, they just can't copy ~/.subversion now. There are other clients such as TortoiseSVN which hav

Re: Default commandline args

2010-12-20 Thread Blair Zajac
On 12/20/10 8:30 PM, C. Michael Pilato wrote: On 12/20/2010 05:28 PM, Hyrum K. Wright wrote: In issue #3765, I suggest the possibility of a CVS-style config file wherein a user could specify a set of default arguments for a given subcommand. For example, 'svn diff' would default to 'svn diff -x

Re: Default commandline args

2010-12-20 Thread C. Michael Pilato
On 12/20/2010 05:28 PM, Hyrum K. Wright wrote: > In issue #3765, I suggest the possibility of a CVS-style config file > wherein a user could specify a set of default arguments for a given > subcommand. For example, 'svn diff' would default to 'svn diff -x -p' > if the config file had an entry for

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 5.2)

2010-12-20 Thread Julian Foad
On Mon, 2010-12-20, Danny Trebbien wrote: > [[[ > Add a public API function, svn_subst_translate_string2(), an extension of > svn_subst_translate_string(), that has two additional output parameters for > determining whether re-encoding and/or line ending translation were performed. [...] Thanks, D

Default commandline args

2010-12-20 Thread Hyrum K. Wright
In issue #3765, I suggest the possibility of a CVS-style config file wherein a user could specify a set of default arguments for a given subcommand. For example, 'svn diff' would default to 'svn diff -x -p' if the config file had an entry for such. Thinking this would be an SMOP, I jumped in...on

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-20 Thread Johan Corveleyn
On Mon, Dec 20, 2010 at 11:19 AM, Philip Martin wrote: > Johan Corveleyn writes: > >> This makes the diff algorithm another 10% - 15% >> faster (granted, this was measured with my "extreme" testcase of a 1,5 >> Mb file (6 lines), of which most lines are identical >> prefix/suffix). > > Can yo

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-20 Thread Johan Corveleyn
On Mon, Dec 20, 2010 at 2:16 PM, Johan Corveleyn wrote: > On Mon, Dec 20, 2010 at 11:03 AM, Julian Foad > wrote: >> On Mon, 2010-12-20, Johan Corveleyn wrote: >>> New macro version (increment only, decrement is similar): >>> [[[ >>> /* For all files in the FILE array, increment the curp pointer.

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

2010-12-20 Thread Daniel Shahaf
Philip Martin wrote on Mon, Dec 20, 2010 at 19:59:37 +: > Daniel Shahaf writes: > > > Blair Zajac wrote on Mon, Dec 20, 2010 at 11:14:34 -0800: > >> > >> Shouldn't svn_repos_fs_commit_txn() always run the post-commit hook if > >> new_rev is a valid rev? > >> > > > > That matters when NEW_REV

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

2010-12-20 Thread Daniel Shahaf
Blair Zajac wrote on Mon, Dec 20, 2010 at 12:03:09 -0800: > > On Dec 20, 2010, at 11:48 AM, Daniel Shahaf wrote: > > > Blair Zajac wrote on Mon, Dec 20, 2010 at 11:14:34 -0800: > >> The docs for svn_fs_commit_txn() for read: > >> > >> * @note Success or failure of the commit of @a txn is determi

Re: svn commit: r1051164 - /subversion/trunk/subversion/libsvn_ra/util.c

2010-12-20 Thread C. Michael Pilato
On 12/20/2010 02:45 PM, Philip Martin wrote: > cmpil...@apache.org writes: > >> Author: cmpilato >> Date: Mon Dec 20 16:07:08 2010 >> New Revision: 1051164 >> >> URL: http://svn.apache.org/viewvc?rev=1051164&view=rev >> Log: >> Another follow-up to r1050216. >> >> * subversion/libsvn_ra/util.c >>

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

2010-12-20 Thread Blair Zajac
On Dec 20, 2010, at 11:48 AM, Daniel Shahaf wrote: > Blair Zajac wrote on Mon, Dec 20, 2010 at 11:14:34 -0800: >> The docs for svn_fs_commit_txn() for read: >> >> * @note Success or failure of the commit of @a txn is determined by >> * examining the value of @a *new_rev upon this function's retu

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

2010-12-20 Thread Philip Martin
Daniel Shahaf writes: > Blair Zajac wrote on Mon, Dec 20, 2010 at 11:14:34 -0800: >> >> Shouldn't svn_repos_fs_commit_txn() always run the post-commit hook if >> new_rev is a valid rev? >> > > That matters when NEW_REV is a valid rev but there is a non-SVN_NO_ERROR > return value. When can that

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

2010-12-20 Thread Daniel Shahaf
Blair Zajac wrote on Mon, Dec 20, 2010 at 11:14:34 -0800: > The docs for svn_fs_commit_txn() for read: > > * @note Success or failure of the commit of @a txn is determined by > * examining the value of @a *new_rev upon this function's return. If > * the value is a valid revision number, the com

Re: svn commit: r1051164 - /subversion/trunk/subversion/libsvn_ra/util.c

2010-12-20 Thread Philip Martin
cmpil...@apache.org writes: > Author: cmpilato > Date: Mon Dec 20 16:07:08 2010 > New Revision: 1051164 > > URL: http://svn.apache.org/viewvc?rev=1051164&view=rev > Log: > Another follow-up to r1050216. > > * subversion/libsvn_ra/util.c > (svn_ra__release_operational_lock): Switch the sense of t

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

2010-12-20 Thread Philip Martin
Blair Zajac writes: > The docs for svn_fs_commit_txn() for read: > > * @note Success or failure of the commit of @a txn is determined by > * examining the value of @a *new_rev upon this function's return. If > * the value is a valid revision number, the commit was successful, > * even though

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

2010-12-20 Thread C. Michael Pilato
On 12/20/2010 02:14 PM, Blair Zajac wrote: > Shouldn't svn_repos_fs_commit_txn() always run the post-commit hook if > new_rev is a valid rev? That does seem reasonable, yes. > BTW, we should have the docs for svn_fs_commit_txn mention that *new_rev is > always modified, so the caller doesn't have

svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

2010-12-20 Thread Blair Zajac
The docs for svn_fs_commit_txn() for read: * @note Success or failure of the commit of @a txn is determined by * examining the value of @a *new_rev upon this function's return. If * the value is a valid revision number, the commit was successful, * even though a n...@c NULL function return v

Re: Will we release 1.5.9? (was Re: 1.5.9 up for testing/signing)

2010-12-20 Thread Stefan Sperling
On Mon, Dec 20, 2010 at 12:31:55PM -0600, Hyrum K. Wright wrote: > We got two sigs for each of Windows and Unix for 1.5.9, but the > signing process has stalled from there. I'd still like to release > this, if possible, but we should probably make a decision at some > point. I have run tests but

Will we release 1.5.9? (was Re: 1.5.9 up for testing/signing)

2010-12-20 Thread Hyrum K. Wright
We got two sigs for each of Windows and Unix for 1.5.9, but the signing process has stalled from there. I'd still like to release this, if possible, but we should probably make a decision at some point. -Hyrum On Thu, Dec 2, 2010 at 3:55 PM, Hyrum K. Wright wrote: > 1.5.9 tarballs are up for te

[PATCH] WCNG: Enforce that a pristine checksum always references an entry in the pristine store.

2010-12-20 Thread Julian Foad
I'm working towards cleaning up the pristine store automatically. Although not strictly necessary, I think it will be helpful if a pristine text checksum in the DB shall be guaranteed always to reference a pristine text that is currently in the store. In support of this goal, the current patch en

Re: svn commit: r1050216 - in /subversion/trunk/subversion: include/private/svn_ra_private.h libsvn_ra/util.c svnrdump/load_editor.c svnsync/main.c

2010-12-20 Thread Daniel Shahaf
C. Michael Pilato wrote on Mon, Dec 20, 2010 at 11:04:04 -0500: > On 12/18/2010 04:29 PM, Daniel Shahaf wrote: > > cmpil...@apache.org wrote on Thu, Dec 16, 2010 at 23:10:10 -: > > [...] > > >> * subversion/libsvn_ra/util.c > >> (is_atomicity_error): Moved here from svnsync/main.c. > >> (

Re: svn commit: r1049646 - in /subversion/trunk/subversion: bindings/javahl/native/ include/ include/private/ libsvn_repos/ svnadmin/ svnrdump/ tests/cmdline/ tests/cmdline/svntest/

2010-12-20 Thread C. Michael Pilato
On 12/18/2010 04:03 PM, Daniel Shahaf wrote: > cmpil...@apache.org wrote on Wed, Dec 15, 2010 at 17:24:17 -: >> @@ -947,14 +953,19 @@ subcommand_load(apr_getopt_t *os, void * >> + if (err && err->apr_err == SVN_ERR_BAD_PROPERTY_VALUE) >> +return svn_error_quick_wrap(err, >> +

Re: svn_load_dirs.pl and paths with '@'

2010-12-20 Thread Julian Foad
Hi Kevin. Thanks for contributing this bug fix. '@' is called an 'at' sign; '&' is called an ampersand. Unfortunately your patch didn't reach the mailing list, probably because the mailing list strips attachments that it doesn't recognize as a plain text MIME type. You could try renaming it as

Re: svn commit: r1050216 - in /subversion/trunk/subversion: include/private/svn_ra_private.h libsvn_ra/util.c svnrdump/load_editor.c svnsync/main.c

2010-12-20 Thread C. Michael Pilato
On 12/18/2010 04:29 PM, Daniel Shahaf wrote: > cmpil...@apache.org wrote on Thu, Dec 16, 2010 at 23:10:10 -: [...] >> * subversion/libsvn_ra/util.c >> (is_atomicity_error): Moved here from svnsync/main.c. >> (svn_ra__release_operational_lock): New, abstracted from >> svnsync/main.c:m

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 5.2)

2010-12-20 Thread Julian Foad
Danny Trebbien wrote: > >> Hi Danny. Please could you enhance your tests so that they can detect > >> this error (so that they will fail if this error is present). > > > > Sometimes I should use more words. > > > > What I meant to say is: I'm trying to devote as much of my time as > > possible to

svn_load_dirs.pl and paths with '@'

2010-12-20 Thread Kevinm
I stumbled across a bug in svn_load_dirs.pl when importing paths with an ampersand character. Anything after the final ampersand in a path gets interpreted as a peg revision during the add phase, so the affected files don't get imported and the sanity check at the end fails. I have attached a patc

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 5.2)

2010-12-20 Thread Danny Trebbien
>> Hi Danny.  Please could you enhance your tests so that they can detect >> this error (so that they will fail if this error is present). > > Sometimes I should use more words. > > What I meant to say is: I'm trying to devote as much of my time as > possible to other things (WC-NG specifically) so

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 5.2)

2010-12-20 Thread Julian Foad
On Mon, 2010-12-20 at 10:11 +, Julian Foad wrote: > On Sun, 2010-12-19 at 16:22 -0800, Danny Trebbien wrote: > > Branko Čibej xbc.nu> writes: > > > > Hi Daniel. > > > > > > > > I haven't looked at your patch v5 yet, because this Git diff doesn't > > > > look quite right. How will this memcmp

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-20 Thread Johan Corveleyn
On Mon, Dec 20, 2010 at 11:03 AM, Julian Foad wrote: > On Mon, 2010-12-20, Johan Corveleyn wrote: >> New macro version (increment only, decrement is similar): >> [[[ >> /* For all files in the FILE array, increment the curp pointer.  If a file >>  * points before the beginning of file, let it poin

Re: Input validation observations - svn info - changing "(Not a valid URL)" to the specific error message

2010-12-20 Thread Julian Foad
Re: * "svn info ^/b" -> "Not a valid URL"; should be "path '/b' not found in revision REV"? On Wed, 2010-12-08, Noorul Islam K M wrote: [...] > One of the solution that you suggested was to keep what the existing > code is doing but saying something more helpful than "Not a valid > URL". I thoug

Re: Input validation observations

2010-12-20 Thread Julian Foad
On Mon, 2010-12-13, Noorul Islam K M wrote: > Julian Foad writes: > > > > * "svn mv ^/ ^/" -> "Cannot move path > > 'https:/svn.apache.org/repos/asf' into itself"; should not print the URL > > as if it's a local path. > > Attached is the patch which improves error message displayed. > [[[ > Ma

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-20 Thread Philip Martin
Johan Corveleyn writes: > This makes the diff algorithm another 10% - 15% > faster (granted, this was measured with my "extreme" testcase of a 1,5 > Mb file (6 lines), of which most lines are identical > prefix/suffix). Can you provide a test script? Or decribe the test more fully, please.

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 5.2)

2010-12-20 Thread Julian Foad
On Sun, 2010-12-19 at 16:22 -0800, Danny Trebbien wrote: > Branko Čibej xbc.nu> writes: > > > Hi Daniel. > > > > > > I haven't looked at your patch v5 yet, because this Git diff doesn't > > > look quite right. How will this memcmp expression work properly if the > > > two strings being compared a

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-20 Thread Julian Foad
On Mon, 2010-12-20, Johan Corveleyn wrote: > New macro version (increment only, decrement is similar): > [[[ > /* For all files in the FILE array, increment the curp pointer. If a file > * points before the beginning of file, let it point at the first byte again. > * If the end of the current ch