Philip Martin wrote on Mon, Dec 20, 2010 at 19:59:37 +0000: > Daniel Shahaf <d...@daniel.shahaf.name> writes: > > > Blair Zajac wrote on Mon, Dec 20, 2010 at 11:14:34 -0800: > >> > >> Shouldn't svn_repos_fs_commit_txn() always run the post-commit hook if > >> new_rev is a valid rev? > >> > > > > That matters when NEW_REV is a valid rev but there is a non-SVN_NO_ERROR > > return value. When can that happen? > > Packing or rep-caching processing after the new rev is created. >
Agreed that (in both of these cases) running the post-commit hook anyway would make sense. > -- > Philip
