On 12/20/2010 02:14 PM, Blair Zajac wrote: > Shouldn't svn_repos_fs_commit_txn() always run the post-commit hook if > new_rev is a valid rev?
That does seem reasonable, yes. > BTW, we should have the docs for svn_fs_commit_txn mention that *new_rev is > always modified, so the caller doesn't have to set *new_rev to > SVN_INVALID_REVNUM. We normally don't make that sort of doc statement. But, in a case such as this -- where success/fail is determined by something other than an error value -- I agree that it makes sense. -- C. Michael Pilato <cmpil...@collab.net> CollabNet <> www.collab.net <> Distributed Development On Demand
signature.asc
Description: OpenPGP digital signature
