Re: [PATCH] Fixing a broken link in notes/subversion-design.html

2010-09-21 Thread Senthil Kumaran S
Hi Azhagu, Azhagu Selvan SP wrote: I have attached the patch which fixes the broken link of webdav-usage.html. Thanks for the patch, committed in r999778. -- Senthil Kumaran S http://www.stylesen.org/

[PATCH] Fixing a broken link in notes/subversion-design.html

2010-09-21 Thread Azhagu Selvan SP
Hi, I have attached the patch which fixes the broken link of webdav-usage.html. [[[ * notes/subversion-design.html: Fixed a broken link ]]] -- Azhagu Selvan SP http://azhaguselvan.co.cc Index: notes/subversion-design.html

Re: svn_client_relocate2()'s docstring

2010-09-21 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, Sep 21, 2010 at 23:53:22 +0200: > > /** > > * Recursively modify a working copy rooted at @a wcroot_dir, changing any > > * repository URLs that begin with @a from to begin with @a to instead. > > * > > * @param wcroot_dir Working copy root directory > > * @pa

svn_client_relocate2()'s docstring

2010-09-21 Thread Daniel Shahaf
> /** > * Recursively modify a working copy rooted at @a wcroot_dir, changing any > * repository URLs that begin with @a from to begin with @a to instead. > * > * @param wcroot_dir Working copy root directory > * @param from Original URL > * @param to New URL > * @param ctx svn_clien

Re: svn commit: r998296 - /subversion/trunk/subversion/include/svn_client.h

2010-09-21 Thread Hyrum Wright
On Tue, Sep 21, 2010 at 10:25 PM, Daniel Shahaf wrote: > hwri...@apache.org wrote on Fri, Sep 17, 2010 at 20:04:53 -: >> Author: hwright >> Date: Fri Sep 17 20:04:53 2010 >> New Revision: 998296 >> >> URL: http://svn.apache.org/viewvc?rev=998296&view=rev >> Log: >> * subversion/include/svn_cli

Re: svn commit: r998296 - /subversion/trunk/subversion/include/svn_client.h

2010-09-21 Thread Daniel Shahaf
hwri...@apache.org wrote on Fri, Sep 17, 2010 at 20:04:53 -: > Author: hwright > Date: Fri Sep 17 20:04:53 2010 > New Revision: 998296 > > URL: http://svn.apache.org/viewvc?rev=998296&view=rev > Log: > * subversion/include/svn_client.h > (svn_client_cat2): Rewrite docstring (see r997639). >

Re: svn commit: r999507 - in /subversion/trunk/subversion: svnrdump/dump_editor.c tests/cmdline/svnrdump_tests.py

2010-09-21 Thread Ramkumar Ramachandra
Hi Daniel, Thanks for the review. Daniel Shahaf writes: > > - /* Disallow a path relative to nothing. */ > > - SVN_ERR_ASSERT_NO_RETURN(!path || pb); > > - > > Why did you drop this assertion? I thought about it for a bit, and I can't seem to figure out why I added it in the first place. My c

Re: add NODES.prior_deleted boolean column

2010-09-21 Thread Julian Foad
Pish, only the OpenOffice attachment was preserved. Here's a PDF copy, temporarily: . - Julian On Tue, 2010-09-21 at 18:41 +0100, Julian Foad wrote: > Greg Stein wrote: > > After working through the several email messages, and discussion, I > > belie

Re: add NODES.prior_deleted boolean column

2010-09-21 Thread Julian Foad
Greg Stein wrote: > After working through the several email messages, and discussion, I > believe we're now down to a simple change: > > * add a "prior_deleted" flag to NODES > > The flag simply means that a node exists prior to this layer and has > been deleted or moved-away. The 'presence' colu

Re: svn commit: r999507 - in /subversion/trunk/subversion: svnrdump/dump_editor.c tests/cmdline/svnrdump_tests.py

2010-09-21 Thread Daniel Shahaf
artag...@apache.org wrote on Tue, Sep 21, 2010 at 17:11:51 -: > Author: artagnon > Date: Tue Sep 21 17:11:50 2010 > New Revision: 999507 > > URL: http://svn.apache.org/viewvc?rev=999507&view=rev > Log: > * subversion/svnrdump/dump_editor.c > (delete_entry): Duplicate the string that we're us

Re: State of Python Bindings for Windows

2010-09-21 Thread anatoly techtonik
On Tue, Sep 21, 2010 at 6:23 PM, wrote: > > You can find un-tested/un-official versions here: http://alagazam.net/ > > I didn't create them, just *really* happy they are there... > (And the python and perl bindings do appear to work, just >  haven't had any official testing according to the autho

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-21 Thread Daniel Shahaf
Daniel Trebbien wrote on Tue, Sep 21, 2010 at 08:12:38 -0700: > On Sun, Sep 19, 2010 at 9:39 PM, Daniel Shahaf > wrote: > > Need the word "to" after the semicolon for the English to be correct. > > Fixed. (When I say "fixed", I mean that I committed a fix in my own > fork of Subversion: http:/

Re: svnsync backwards-compatibility with older servers (Was: Re: svn commit: r999421)

2010-09-21 Thread Daniel Shahaf
Stefan Sperling wrote on Tue, Sep 21, 2010 at 18:25:10 +0200: > On Tue, Sep 21, 2010 at 05:07:49PM +0100, Jon Foster wrote: > > So... what do we do if a 1.7 svnsync connects to a <=1.6 mirror server? > > Some options are: > > Right now, the code uses option (1). > > 1) It works like 1.6 - i.e. i

Re: svn commit: r999421 - /subversion/branches/atomic-revprop/subversion/svnsync/main.c

2010-09-21 Thread Daniel Shahaf
Stefan Sperling wrote on Tue, Sep 21, 2010 at 17:01:13 +0200: > On Tue, Sep 21, 2010 at 02:03:12PM -, danie...@apache.org wrote: > > Author: danielsh > > Date: Tue Sep 21 14:03:12 2010 > > New Revision: 999421 > > > > URL: http://svn.apache.org/viewvc?rev=999421&view=rev > > Log: > > On the at

Re: svnsync backwards-compatibility with older servers (Was: Re: svn commit: r999421)

2010-09-21 Thread Stefan Sperling
On Tue, Sep 21, 2010 at 05:07:49PM +0100, Jon Foster wrote: > So... what do we do if a 1.7 svnsync connects to a <=1.6 mirror server? > Some options are: > > 1) It works like 1.6 - i.e. it does buggy locking that works most of the > time, then one day it corrupts the mirror repo. > > 2) It runs w

svnsync backwards-compatibility with older servers (Was: Re: svn commit: r999421)

2010-09-21 Thread Jon Foster
Hi, svnsync has always had locking, to prevent two svnsync processes from writing to the same mirror at the same time. (If that happens, then the mirror repo gets corrupted. You have to either delete the mirror repo and resync, dump/load it, or restore from backup. Either way, there's significa

Re: buildbot failure in ASF Buildbot on svn-debian-x86_64-32 shared gcc

2010-09-21 Thread Ramkumar Ramachandra
Hi Greg, Greg Stein writes: > What's up with this buildbot? > > I've noticed a lot of flapping of the bots lately. It is hard to tell > whether svn is stable or not with all this noise. Looking at the stdio > from this build... WTF?! is all that I can say. > > Anybody know what's up here? Sorry

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-21 Thread Daniel Trebbien
Daniel Trebbien gmail.com> writes: > Yes, I did copy-and-paste. I see your point, though, and I am going to > correct this by adding another `static` function that both will call. Never mind the talk of a new static function. `svn_subst_translate_string` should of course call `svn_subst_translat

Re: State of Python Bindings for Windows

2010-09-21 Thread kmradke
anatoly techtonik wrote on 09/20/2010 05:16:18 AM: > I can't find any binaries for Python bindings for Windows. Previously > they were available from tigris.org site, but now there aren't any > updates. It will greatly reduce frustration for users of hgsubversion > and other Windows tools if up t

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-21 Thread Daniel Trebbien
Daniel Shahaf daniel.shahaf.name> writes: > > Gavin, thanks for the information, but I think Daniel Trebbien already > knows this. > > Gavin Beau Baumanis wrote on Sun, Sep 19, 2010 at 08:52:05 +1000: > > Hi Daniel, > > > > You should always feel comfortable with "pimping" your own patch > >

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-21 Thread Daniel Trebbien
On Sun, Sep 19, 2010 at 9:39 PM, Daniel Shahaf wrote: >> * subversion/include/svn_subst.h >>   Added documentation of the new public API function >>   svn_subst_translate_string2(). >> > > Should use this syntax: > > * subversion/include/svn_subst.h >  (svn_subst_translate_string2): New function.

Re: svn commit: r999421 - /subversion/branches/atomic-revprop/subversion/svnsync/main.c

2010-09-21 Thread Stefan Sperling
On Tue, Sep 21, 2010 at 02:03:12PM -, danie...@apache.org wrote: > Author: danielsh > Date: Tue Sep 21 14:03:12 2010 > New Revision: 999421 > > URL: http://svn.apache.org/viewvc?rev=999421&view=rev > Log: > On the atomic-revprops branch: > > In svnsync, grab the lock atomically, if possible.

Re: svn diff optimization to make blame faster?

2010-09-21 Thread Hyrum K. Wright
On Mon, Sep 20, 2010 at 12:10 PM, Johan Corveleyn wrote: > On Mon, Sep 20, 2010 at 11:52 AM, Branko Čibej wrote: >>  On 15.09.2010 14:20, Johan Corveleyn wrote: >>> Some update on this: I have implemented this for svn_diff (excluding >>> the identical prefix and suffix of both files, and only the

Re: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

2010-09-21 Thread Julian Reschke
On 21.09.2010 14:49, Jon Foster wrote: ... http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/dav/main/mod_dav. c?revision=982016&view=markup#l2121 This is the mod_dav function that builds the 207 response from a failed PROPPATCH. It doesn't allow us to add extra XML wherever we want; we on

RE: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

2010-09-21 Thread Jon Foster
Julian Reschke wrote: > On 21.09.2010 14:12, Daniel Shahaf wrote: > > Julian Reschke wrote on Tue, Sep 21, 2010 at 13:46:13 +0200: > >> Hi, > >> > >> just two comments without having looked at the remainder of the discussion. > >> > >> 1) If you need to augment a standard HTTP response code with ad

Re: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

2010-09-21 Thread Julian Reschke
On 21.09.2010 14:12, Daniel Shahaf wrote: Julian Reschke wrote on Tue, Sep 21, 2010 at 13:46:13 +0200: Hi, just two comments without having looked at the remainder of the discussion. 1) If you need to augment a standard HTTP response code with additional information, the right thing to use is

Re: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

2010-09-21 Thread Daniel Shahaf
Julian Reschke wrote on Tue, Sep 21, 2010 at 13:46:13 +0200: > Hi, > > just two comments without having looked at the remainder of the discussion. > > 1) If you need to augment a standard HTTP response code with additional > information, the right thing to use is DAV:error (see >

Re: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

2010-09-21 Thread Julian Reschke
On 21.09.2010 13:52, Jon Foster wrote: Hi, just two comments without having looked at the remainder of the discussion. Please read my first mail in this [PATCH 3/3] thread, which explains why these choices were made. ... That's the message I read, and I didn't see any consideration of using

RE: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

2010-09-21 Thread Jon Foster
Hi, > just two comments without having looked at the remainder of the discussion. Please read my first mail in this [PATCH 3/3] thread, which explains why these choices were made. Kind regards, Jon -Original Message- From: Julian Reschke [mailto:julian.resc...@gmx.de] Sent: 21 Septem

Re: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

2010-09-21 Thread Julian Reschke
Hi, just two comments without having looked at the remainder of the discussion. 1) If you need to augment a standard HTTP response code with additional information, the right thing to use is DAV:error (see ). 2) Do not use 412 Pre

Re: buildbot failure in ASF Buildbot on svn-debian-x86_64-32 shared gcc

2010-09-21 Thread Daniel Shahaf
Bert Huijben wrote on Tue, Sep 21, 2010 at 11:17:09 +0200: > > > > -Original Message- > > From: Greg Stein [mailto:gst...@gmail.com] > > Sent: dinsdag 21 september 2010 10:42 > > To: dev@subversion.apache.org > > Subject: Re: buildbot failure in ASF Buildbot on svn-debian-x86_64-32 > > sh

Re: svn client has inconsistent returnstatus for non-existing local files

2010-09-21 Thread Daniel Shahaf
Sjon Hortensius wrote on Tue, Sep 21, 2010 at 09:19:17 +0200: > Thanks for your reply, and yes, it seems I made an error describing > the actual bug. I meant the exit-status of `svn cat`; which differs. > > > If 'svn' reports an error that cannot be detected by a calling script, > > then please po

RE: buildbot failure in ASF Buildbot on svn-debian-x86_64-32 shared gcc

2010-09-21 Thread Bert Huijben
> -Original Message- > From: Greg Stein [mailto:gst...@gmail.com] > Sent: dinsdag 21 september 2010 10:42 > To: dev@subversion.apache.org > Subject: Re: buildbot failure in ASF Buildbot on svn-debian-x86_64-32 > shared gcc > > What's up with this buildbot? > > I've noticed a lot of flap

Re: buildbot failure in ASF Buildbot on svn-debian-x86_64-32 shared gcc

2010-09-21 Thread Greg Stein
What's up with this buildbot? I've noticed a lot of flapping of the bots lately. It is hard to tell whether svn is stable or not with all this noise. Looking at the stdio from this build... WTF?! is all that I can say. Anybody know what's up here? Cheers, -g On Tue, Sep 21, 2010 at 04:10, wro

Re: svn client has inconsistent returnstatus for non-existing local files

2010-09-21 Thread Sjon Hortensius
On Tue, Sep 21, 2010 at 12:01 AM, Daniel Shahaf wrote: > Sjon Hortensius wrote on Thu, Sep 16, 2010 at 17:04:19 +0200: >> LS, >> >> Please advise if this is a bug, or a known feature. I have a local >> checkout on which I can execute svn commands. However, there seems to >> be some inconsistency i