Re: compression

2010-06-28 Thread Daniel Shahaf
Edward Ned Harvey wrote on Tue, 29 Jun 2010 at 07:15 -: > Svnserve is using standard zlib (not a parallel implementation) so You can disable all (most?) compression by not advertising the svndiff1 capability in svnserve/serve.c. > Some people are seeing 20min commit times on changes they coul

compression

2010-06-28 Thread Edward Ned Harvey
Compression can be good, or bad for performance. Whenever somebody has large binary files managed by svn, and all the access is on a high speed LAN, then compression is usually bad ... I'm trying to help a company right now, where that is the situation. Performance is *crazy* bad because we're w

Re: svn commit: r958698 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c

2010-06-28 Thread Greg Stein
Not on my game today. Thanks! On Mon, Jun 28, 2010 at 16:26, Bert Huijben wrote: > > >> -Original Message- >> From: Greg Stein [mailto:gst...@gmail.com] >> Sent: maandag 28 juni 2010 22:22 >> To: dev@subversion.apache.org >> Subject: Re: svn commit: r958698 - in >> /subversion/trunk/subv

Re: svn commit: r958260 - /subversion/trunk/subversion/libsvn_client/diff.c

2010-06-28 Thread Daniel Näslund
On Mon, Jun 28, 2010 at 02:38:26PM +0200, Daniel Näslund wrote: > Since r958537, there is a diff extension switch to enable git diffs: > > svn diff -x --git-diff [-g] > > In hindsight, I'm not sure that was the best thing to do. I read this > part from svn help diff: > > [[[ > -x --extensions AR

RE: svn commit: r958698 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c

2010-06-28 Thread Bert Huijben
> -Original Message- > From: Greg Stein [mailto:gst...@gmail.com] > Sent: maandag 28 juni 2010 22:22 > To: dev@subversion.apache.org > Subject: Re: svn commit: r958698 - in > /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c > > On Mon, Jun 28, 2010 at 16:04, wrote: > >... > >

Re: svn commit: r958698 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c

2010-06-28 Thread Greg Stein
On Mon, Jun 28, 2010 at 16:04, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Mon Jun 28 20:04:22 2010 >... > @@ -1332,6 +1338,11 @@ svn_wc_add4(svn_wc_context_t *wc_ctx, >                                           repos_root_url, repos_root_url, >                              

Re: svn commit: r958671 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2010-06-28 Thread Greg Stein
On Mon, Jun 28, 2010 at 15:24, Daniel Shahaf wrote: >... >> > (on s.c.n viewvc's diffs used to ignore whitespace... doesn't seem to be >> > the case on s.a.o though) >> >> Whitespace can be important (e.g Python scripts), so keeping simple >> whitespace changes in the commit email is a Good Thing.

Re: subversion-1.6.12, apache-2.3.6

2010-06-28 Thread Jeff Trawick
On Mon, Jun 28, 2010 at 3:13 PM, Greg Stein wrote: > [resending; the original has httpd.apache.COM ...] > > On Mon, Jun 28, 2010 at 15:12, Greg Stein wrote: >> On Mon, Jun 28, 2010 at 05:20, Philip Martin >> wrote: >>> "Bert Huijben" writes: >>> > -Original Message- > From: szu

Re: svn commit: r958671 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2010-06-28 Thread Daniel Shahaf
Greg Stein wrote on Mon, 28 Jun 2010 at 22:16 -: > On Mon, Jun 28, 2010 at 14:59, Daniel Shahaf wrote: > > Greg Stein wrote on Mon, 28 Jun 2010 at 21:50 -: > >> How am I supposed to review this? I can't tell what is indentation, > >> versus actual code change. > >> > > > > svn diff -x-w ?

Re: svn commit: r958671 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2010-06-28 Thread Greg Stein
On Mon, Jun 28, 2010 at 14:59, Daniel Shahaf wrote: > Greg Stein wrote on Mon, 28 Jun 2010 at 21:50 -: >> On Mon, Jun 28, 2010 at 14:33,   wrote: >> > Author: rhuijben >> > Date: Mon Jun 28 18:33:05 2010 >> > New Revision: 958671 >> > >> > URL: http://svn.apache.org/viewvc?rev=958671&view=rev

Re: subversion-1.6.12, apache-2.3.6

2010-06-28 Thread Greg Stein
On Mon, Jun 28, 2010 at 05:20, Philip Martin wrote: > "Bert Huijben" writes: > >>> -Original Message- >>> From: szukw...@arcor.de [mailto:szukw...@arcor.de] >>> Sent: maandag 28 juni 2010 9:51 >>> To: dev@subversion.apache.org >>> Subject: Re: subversion-1.6.12, apache-2.3.6 >>> >>> I kno

Re: subversion-1.6.12, apache-2.3.6

2010-06-28 Thread Greg Stein
[resending; the original has httpd.apache.COM ...] On Mon, Jun 28, 2010 at 15:12, Greg Stein wrote: > On Mon, Jun 28, 2010 at 05:20, Philip Martin > wrote: >> "Bert Huijben" writes: >> -Original Message- From: szukw...@arcor.de [mailto:szukw...@arcor.de] Sent: maandag 28

Re: svn commit: r958671 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2010-06-28 Thread Daniel Shahaf
Greg Stein wrote on Mon, 28 Jun 2010 at 21:50 -: > On Mon, Jun 28, 2010 at 14:33, wrote: > > Author: rhuijben > > Date: Mon Jun 28 18:33:05 2010 > > New Revision: 958671 > > > > URL: http://svn.apache.org/viewvc?rev=958671&view=rev > > Log: > > * subversion/libsvn_wc/adm_ops.c > >  (svn_wc_ad

Re: svn commit: r958671 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2010-06-28 Thread Greg Stein
On Mon, Jun 28, 2010 at 14:33, wrote: > Author: rhuijben > Date: Mon Jun 28 18:33:05 2010 > New Revision: 958671 > > URL: http://svn.apache.org/viewvc?rev=958671&view=rev > Log: > * subversion/libsvn_wc/adm_ops.c >  (svn_wc_add4): Fix indentation and remove a few more unneeded ifs. Argh!!! How

Re: svn commit: r958515 - /subversion/trunk/build.conf

2010-06-28 Thread Greg Stein
Ah! whew! Thought I had missed some big change in our dependency matrix... On Mon, Jun 28, 2010 at 14:44, Daniel Shahaf wrote: > Greg Stein wrote on Mon, 28 Jun 2010 at 21:32 -: >> What is this? AFAIK, we use libexpat, not libxml. And even then, we >> use expat via its inclusion in apr-util

Re: svn commit: r958630 - in /subversion/trunk/subversion: libsvn_ra_local/split_url.c tests/libsvn_ra_local/ra-local-test.c

2010-06-28 Thread Greg Stein
This is just compounding the problem. The test suite should NEVER cause an assertion. You simply are not allowed to pass those arguments into the functions. That is why the assertion is there. Neither the test suite, nor third parties should pass those bad arguments. Period. If you want to conver

Re: svn commit: r958515 - /subversion/trunk/build.conf

2010-06-28 Thread Daniel Shahaf
Greg Stein wrote on Mon, 28 Jun 2010 at 21:32 -: > What is this? AFAIK, we use libexpat, not libxml. And even then, we > use expat via its inclusion in apr-util. I don't recall any autoconf > code to look for libxml to ensure that we can link against it. > I thought 'xml' means to use the fol

Re: svn commit: r958583 - /subversion/trunk/subversion/tests/svn_test_main.c

2010-06-28 Thread Greg Stein
On Mon, Jun 28, 2010 at 10:09, wrote: > Author: julianfoad > Date: Mon Jun 28 14:09:33 2010 > New Revision: 958583 > > URL: http://svn.apache.org/viewvc?rev=958583&view=rev > Log: > * subversion/tests/svn_test_main.c >  (main): Configure the Subversion library to raise an error on assertion >    

Re: svn commit: r958571 - in /subversion/trunk/subversion: libsvn_subr/dirent_uri.c tests/libsvn_subr/dirent_uri-test.c

2010-06-28 Thread Greg Stein
On Mon, Jun 28, 2010 at 09:27, wrote: > Author: julianfoad > Date: Mon Jun 28 13:27:46 2010 > New Revision: 958571 > > URL: http://svn.apache.org/viewvc?rev=958571&view=rev > Log: > Fix a file:// URL decoding bug. > > * subversion/libsvn_subr/dirent_uri.c >  (svn_uri_get_dirent_from_file_url): Do

Re: svn commit: r958515 - /subversion/trunk/build.conf

2010-06-28 Thread Greg Stein
What is this? AFAIK, we use libexpat, not libxml. And even then, we use expat via its inclusion in apr-util. I don't recall any autoconf code to look for libxml to ensure that we can link against it. On Mon, Jun 28, 2010 at 05:36, wrote: > Author: julianfoad > Date: Mon Jun 28 09:36:43 2010 > N

Re: svn commit: r958559 - in /subversion/trunk/subversion: include/ libsvn_client/ libsvn_delta/ libsvn_subr/ libsvn_wc/ mod_dav_svn/ svn/ tests/libsvn_subr/

2010-06-28 Thread Blair Zajac
On 06/28/2010 05:45 AM, rhuij...@apache.org wrote: Author: rhuijben Date: Mon Jun 28 12:45:39 2010 New Revision: 958559 URL: http://svn.apache.org/viewvc?rev=958559&view=rev Log: Switch the argument order of (the new in 1.7) svn_dirent_split(), svn_uri_split() and svn_relpath_split() functions t

Re: svn commit: r957917 - /subversion/trunk/subversion/libsvn_client/status.c

2010-06-28 Thread Julian Foad
I (Julian Foad) wrote: > We should document what depth "unknown" means on svn_client_status5(). > Would something like the following work? > > * Get status only as deeply as @a depth indicates. > + * If @a depth is #svn_depth_unknown, the editor will affect only the > + * paths reported by the i

Re: svn commit: r958260 - /subversion/trunk/subversion/libsvn_client/diff.c

2010-06-28 Thread Daniel Näslund
On Sat, Jun 26, 2010 at 04:47:46PM -0400, Greg Stein wrote: > On Sat, Jun 26, 2010 at 13:56, wrote: > > Author: dannas > > Date: Sat Jun 26 17:56:06 2010 > > New Revision: 958260 > > > > URL: http://svn.apache.org/viewvc?rev=958260&view=rev > > Log: > > With SVN_EXPERIMENTAL_PATCH defined, only p

Re: svn commit: r957917 - /subversion/trunk/subversion/libsvn_client/status.c

2010-06-28 Thread Julian Foad
Bert Huijben wrote: > Log: > For consistency, make 'svn status -u --depth infinity' show what an > 'svn update --depth infinity' would see, instead of also what an > 'svn update --set-depth infinity' would bring into the working > copy, by limiting the reporting to the recorded depth. +1 on this f

Re: [Patch] - Fix compilation of direct_uri-test.c on OS/2

2010-06-28 Thread Matthew Bentham
On 28/06/2010 10:29, Bert Huijben wrote: -Original Message- From: Julian Foad [mailto:julian.f...@wandisco.com] Sent: maandag 28 juni 2010 10:48 To: Paul Smedley Cc: dev@subversion.apache.org Subject: Re: [Patch] - Fix compilation of direct_uri-test.c on OS/2 On Sun, 2010-06-27, Paul

RE: [Patch] - Fix compilation of direct_uri-test.c on OS/2

2010-06-28 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julian.f...@wandisco.com] > Sent: maandag 28 juni 2010 10:48 > To: Paul Smedley > Cc: dev@subversion.apache.org > Subject: Re: [Patch] - Fix compilation of direct_uri-test.c on OS/2 > > On Sun, 2010-06-27, Paul Smedley wrote: > > [[[ > > F

Re: subversion-1.6.12, apache-2.3.6

2010-06-28 Thread Philip Martin
"Bert Huijben" writes: >> -Original Message- >> From: szukw...@arcor.de [mailto:szukw...@arcor.de] >> Sent: maandag 28 juni 2010 9:51 >> To: dev@subversion.apache.org >> Subject: Re: subversion-1.6.12, apache-2.3.6 >> >> I know that httpd-2.3.x is alpha. Second trial for the patch. > > T

RE: subversion-1.6.12, apache-2.3.6

2010-06-28 Thread szukw000
- Original Nachricht Von: Bert Huijben An: szukw...@arcor.de, dev@subversion.apache.org Datum: 28.06.2010 09:58 Betreff: RE: subversion-1.6.12, apache-2.3.6 > > -Original Message- > > From: szukw...@arcor.de [mailto:szukw...@arcor.de] > > Sent: maandag 28 juni 2010 9:5

Re: [Patch] - Fix compilation of direct_uri-test.c on OS/2

2010-06-28 Thread Julian Foad
On Sun, 2010-06-27, Paul Smedley wrote: > [[[ > Fix compilation of direct_uri-test.c on OS/2 > > * subversion/tests/libsvn_subr/dirent_uri-test.c : add define of getdcwd > as _getdcwd for __OS2__ as well as _MSC_VER > ]]] Hi Paul. To see if there were other similar places, I searched for _MSC_V

RE: subversion-1.6.12, apache-2.3.6

2010-06-28 Thread Bert Huijben
> -Original Message- > From: szukw...@arcor.de [mailto:szukw...@arcor.de] > Sent: maandag 28 juni 2010 9:51 > To: dev@subversion.apache.org > Subject: Re: subversion-1.6.12, apache-2.3.6 > > I know that httpd-2.3.x is alpha. Second trial for the patch. Thanks for your patch, it came throu

Re: subversion-1.6.12, apache-2.3.6

2010-06-28 Thread szukw000
I know that httpd-2.3.x is alpha. Second trial for the patch. winfried -- WM 2010: Top News, Spielpläne, Public Viewing-Termine, E-Cards und alles, was der Fan sonst noch braucht, gibt´s im Sport-Channel auf arcor.de. http://www.arcor.de/rd/footer.wm2010 subversion-1.6.12.dif.gz Description: GN