Re: svn trunk r945350: PASS (x64-ubuntu gcc)

2010-05-19 Thread Joe Swatosh
On Wed, May 19, 2010 at 12:36 PM, Daniel Shahaf wrote: > Hyrum K. Wright wrote on Wed, 19 May 2010 at 08:38 -0500: >> On Wed, May 19, 2010 at 6:15 AM, Bert Huijben wrote: >> >> > > -Original Message- >> > > From: Joe Swatosh [mailto:joe.swat...@gmail.com] >> >> Perhaps we should note th

Re: svn commit: r946518 - in /subversion/trunk/subversion: bindings/javahl/native/EnumMapper.cpp tests/cmdline/svntest/main.py

2010-05-19 Thread Greg Stein
On Wed, May 19, 2010 at 23:55, wrote: > Author: hwright > Date: Thu May 20 03:55:16 2010 > New Revision: 946518 > > URL: http://svn.apache.org/viewvc?rev=946518&view=rev > Log: > JavaHL: Fix a JNI frame bug. > > * subversion/bindings/javahl/native/CreateJ.cpp >  (getOrdinal): add a call to PushLo

Re: [PATCH] Fix for a local frame leak in EnumMapper.cpp

2010-05-19 Thread Hyrum K. Wright
On Wed, May 19, 2010 at 6:26 PM, Byeongcheol Lee wrote: > Dear Subversion Developers: > > I attach a patch for a local frame leak in EnumMapper.cpp, and the log > message follows here: > > [[[ > * subversion/bindings/javahl/native/CreateJ.cpp > (getOrdinal): add a call to "PushLocalFrame" before

Re: svn commit: r946495 - /subversion/trunk/subversion/libsvn_wc/deprecated.c

2010-05-19 Thread Greg Stein
Ah. I see. Julian's compiler *did* warn about it... thx -g On Wed, May 19, 2010 at 23:20, Greg Stein wrote: > Why was this not found by the compiler? > > On Wed, May 19, 2010 at 20:42,   wrote: >> Author: stsp >> Date: Thu May 20 00:42:09 2010 >> New Revision: 946495 >> >> URL: http://svn.apache

Re: svn commit: r946495 - /subversion/trunk/subversion/libsvn_wc/deprecated.c

2010-05-19 Thread Greg Stein
Why was this not found by the compiler? On Wed, May 19, 2010 at 20:42, wrote: > Author: stsp > Date: Thu May 20 00:42:09 2010 > New Revision: 946495 > > URL: http://svn.apache.org/viewvc?rev=946495&view=rev > Log: > * subversion/libsvn_wc/deprecated.c >  (wrap_4to3_dir_opened): Accept the new SK

Re: svn commit: r946186 - new output parameter SKIP_CHILDREN

2010-05-19 Thread Stefan Sperling
On Thu, May 20, 2010 at 12:14:22AM +0100, Julian Foad wrote: > On Wed, 2010-05-19, s...@apache.org wrote: > > Author: stsp > > Date: Wed May 19 13:55:51 2010 > > New Revision: 946186 > > > > URL: http://svn.apache.org/viewvc?rev=946186&view=rev > > > * subversion/include/svn_wc.h > > (svn_wc_di

Re: svn commit: r946475 - /subversion/trunk/tools/dev/unix-build/Makefile.svn

2010-05-19 Thread Stefan Sperling
On Wed, May 19, 2010 at 04:06:05PM -0700, Blair Zajac wrote: > On 05/19/2010 03:58 PM, s...@apache.org wrote: > >Author: stsp > >Date: Wed May 19 22:58:37 2010 > >New Revision: 946475 > > > >URL: http://svn.apache.org/viewvc?rev=946475&view=rev > >Log: > >* tools/dev/unix-build/Makefile.svn: Fix a

[PATCH] Fix for a local frame leak in EnumMapper.cpp

2010-05-19 Thread Byeongcheol Lee
Dear Subversion Developers: I attach a patch for a local frame leak in EnumMapper.cpp, and the log message follows here: [[[ * subversion/bindings/javahl/native/CreateJ.cpp (getOrdinal): add a call to "PushLocalFrame" before the method returns successfully without a Java exception. ]]] To repro

[PATCH] Fix for a local frame leak in EnumMapper.cpp

2010-05-19 Thread Byeongcheol Lee
Dear Subversion Developers: I attach a patch for a local frame leak in EnumMapper.cpp, and the log message follows here: [[[ * subversion/bindings/javahl/native/CreateJ.cpp (getOrdinal): add a call to "PushLocalFrame" before the method returns successfully without a Java exception. ]]] To repro

Re: svn commit: r946186 - new output parameter SKIP_CHILDREN

2010-05-19 Thread Julian Foad
On Wed, 2010-05-19, s...@apache.org wrote: > Author: stsp > Date: Wed May 19 13:55:51 2010 > New Revision: 946186 > > URL: http://svn.apache.org/viewvc?rev=946186&view=rev > * subversion/include/svn_wc.h > (svn_wc_diff_callbacks4_t): Add new output parameter SKIP_CHILDREN >to the dir_opened

Re: svn commit: r946475 - /subversion/trunk/tools/dev/unix-build/Makefile.svn

2010-05-19 Thread Blair Zajac
On 05/19/2010 03:58 PM, s...@apache.org wrote: Author: stsp Date: Wed May 19 22:58:37 2010 New Revision: 946475 URL: http://svn.apache.org/viewvc?rev=946475&view=rev Log: * tools/dev/unix-build/Makefile.svn: Fix a comment typo. Set LD_LIBRARY_PATH when running tests for perl and python bindi

in-database properties [status]

2010-05-19 Thread Greg Stein
Hey all, Just a quick note on in-database properties: the code is written and working. You can mess around with it by #define'ing USE_DB_PROPS in props.h. The code passes the entire test suite except for two related to migration. BUT. Migration code does not exist for 1.6 (and earlier) working co

Re: svn commit: r946343 - in /subversion/trunk/subversion/libsvn_wc: wc_db.c wc_db_util.c wc_db_util.h

2010-05-19 Thread Hyrum K. Wright
On Wed, May 19, 2010 at 3:43 PM, Greg Stein wrote: > On Wed, May 19, 2010 at 15:09, wrote: > > Author: hwright > > Date: Wed May 19 19:09:21 2010 > > New Revision: 946343 > > > > URL: http://svn.apache.org/viewvc?rev=946343&view=rev > > Log: > > Introduce another file for breaking stuff out of

Re: svn commit: r946343 - in /subversion/trunk/subversion/libsvn_wc: wc_db.c wc_db_util.c wc_db_util.h

2010-05-19 Thread Greg Stein
On Wed, May 19, 2010 at 15:09, wrote: > Author: hwright > Date: Wed May 19 19:09:21 2010 > New Revision: 946343 > > URL: http://svn.apache.org/viewvc?rev=946343&view=rev > Log: > Introduce another file for breaking stuff out of wc_db.c. > > * subversion/libsvn_wc/wc_db_util.c, >  subversion/libsv

RE: [Patch] RE: Windows drive letter check fails on lower case current working drive

2010-05-19 Thread Bert Huijben
> -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: woensdag 20 januari 2010 11:31 > To: 'Branko Čibej'; 'William A. Rowe Jr.' > Cc: d...@apr.apache.org; 'Philip Martin'; 'Bert Huijben'; > dev@subversion.apache.org > Subject: RE: [Patch] RE: Windows drive letter chec

Re: svn trunk r945350: PASS (x64-ubuntu gcc)

2010-05-19 Thread Daniel Shahaf
Hyrum K. Wright wrote on Wed, 19 May 2010 at 08:38 -0500: > On Wed, May 19, 2010 at 6:15 AM, Bert Huijben wrote: > > > > -Original Message- > > > From: Joe Swatosh [mailto:joe.swat...@gmail.com] > > > Sent: woensdag 19 mei 2010 8:33 > > > To: dev@subversion.apache.org > > > Subject: Re: s

Re: svn commit: r945788 - in /subversion/trunk/subversion/libsvn_wc: adm_files.c adm_files.h diff.c

2010-05-19 Thread Julian Foad
On Wed, 2010-05-19, Greg Stein wrote: > On Tue, May 18, 2010 at 13:51, wrote: > > Author: julianfoad > > Date: Tue May 18 17:51:13 2010 > > New Revision: 945788 > > > > URL: http://svn.apache.org/viewvc?rev=945788&view=rev > > Log: > > Start splitting up the uses of svn_wc__text_base_path() accor

Re: svn commit: r945034 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/commit_util.c libsvn_wc/node.c

2010-05-19 Thread Philip Martin
Greg Stein writes: > On Mon, May 17, 2010 at 05:03, wrote: >> Author: philip >> Date: Mon May 17 09:03:36 2010 >> New Revision: 945034 >> >> URL: http://svn.apache.org/viewvc?rev=945034&view=rev >> Log: >> * subversion/include/private/svn_wc_private.h >>  (svn_wc__db_temp_get_keep_local): Renam

Re: svn commit: r945708 - in /subversion/branches/1.6.x-issue3469/subversion/libsvn_wc: adm_ops.c entries.c tree_conflicts.c

2010-05-19 Thread Johan Corveleyn
On Wed, May 19, 2010 at 3:13 PM, Stefan Sperling wrote: > On Wed, May 19, 2010 at 03:05:33PM +0200, Stefan Sperling wrote: >> On Wed, May 19, 2010 at 12:47:42PM +0200, Johan Corveleyn wrote: >> > On Tue, May 18, 2010 at 5:42 PM,   wrote: >> > > Author: stsp >> > > Date: Tue May 18 15:42:57 2010 >>

[Press Release] WANdisco Gives Back to the Subversion Community

2010-05-19 Thread george.pow...@wandisco.com
Profits from WANdisco Subversion Support Contract Sales Go Toward Subversion’s Continuing Development and Support the Activities of the Subversion community. http://svn.wandisco.com/WANdisco_Gives_Back_to_the_Subversion_Community

Re: 2-URL merges incorrectly reverse-merge mergeinfo for merge target?

2010-05-19 Thread C. Michael Pilato
Stefan Sperling wrote: > You said the algorithm was: > > the reverse-merge of the diff between "ancestor" and "left" >+ the merge of the diff between "ancestor" and "right" > > Unless I'm mistaken, in this case ancestor is tr...@6, > left is tr...@15, and right is featu...@15. tr...@5 i

Re: svn trunk r945350: PASS (x64-ubuntu gcc)

2010-05-19 Thread Hyrum K. Wright
On Wed, May 19, 2010 at 6:15 AM, Bert Huijben wrote: > > -Original Message- > > From: Joe Swatosh [mailto:joe.swat...@gmail.com] > > Sent: woensdag 19 mei 2010 8:33 > > To: dev@subversion.apache.org > > Subject: Re: svn trunk r945350: PASS (x64-ubuntu gcc) > > > > Is the Ubuntu Buildbot t

Re: [PATCH] Fix for a JNI bug in CreateJ.cpp (JavaHL)

2010-05-19 Thread Hyrum K. Wright
Committed in r946181. Thanks! -Hyrum On Wed, May 19, 2010 at 7:57 AM, Greg Stein wrote: > Cool. Thanks!! > > On Wed, May 19, 2010 at 00:21, Byeongcheol Lee > wrote: > > [[[ > > * subversion/bindings/javahl/native/CreateJ.cpp > > (Set): Use CallBooleanMethod for a method returning a boolean v

Re: svn commit: r945708 - in /subversion/branches/1.6.x-issue3469/subversion/libsvn_wc: adm_ops.c entries.c tree_conflicts.c

2010-05-19 Thread Stefan Sperling
On Wed, May 19, 2010 at 03:05:33PM +0200, Stefan Sperling wrote: > On Wed, May 19, 2010 at 12:47:42PM +0200, Johan Corveleyn wrote: > > On Tue, May 18, 2010 at 5:42 PM, wrote: > > > Author: stsp > > > Date: Tue May 18 15:42:57 2010 > > > New Revision: 945708 > > > > > > URL: http://svn.apache.org

Re: [PATCH v2] Saving a few cycles, part 2/3

2010-05-19 Thread Greg Stein
On Tue, May 18, 2010 at 07:25, Stefan Fuhrmann wrote: >... > It takes a hundred arrows to shoot an elephant. Although some may > miss, they all need to be fired. Currently we inspect every single > arrow, discus its potential penetration depth, smoothness of the > shaft and likelihood of hitting a

Re: [PATCH v2] Saving a few cycles, part 2/3

2010-05-19 Thread Greg Stein
On Thu, May 13, 2010 at 20:00, Julian Foad wrote: >... > The fast_memcpy() optimization raised an eyebrow: one developer (Greg > Stein) mentioned to me that optimizing standard memcpy felt wrong in > principle.  I don't know what was behind his feeling.  I guess one kind > of concern that could be

Re: svn commit: r945708 - in /subversion/branches/1.6.x-issue3469/subversion/libsvn_wc: adm_ops.c entries.c tree_conflicts.c

2010-05-19 Thread Stefan Sperling
On Wed, May 19, 2010 at 12:47:42PM +0200, Johan Corveleyn wrote: > On Tue, May 18, 2010 at 5:42 PM, wrote: > > Author: stsp > > Date: Tue May 18 15:42:57 2010 > > New Revision: 945708 > > > > URL: http://svn.apache.org/viewvc?rev=945708&view=rev > > Log: > > On the 1.6.x-issue3469 branch, fix iss

Re: [PATCH] Fix for a JNI bug in CreateJ.cpp (JavaHL)

2010-05-19 Thread Greg Stein
Cool. Thanks!! On Wed, May 19, 2010 at 00:21, Byeongcheol Lee wrote: > [[[ > * subversion/bindings/javahl/native/CreateJ.cpp >  (Set): Use CallBooleanMethod for a method returning a boolean value. > ]]] > > On Tue, May 18, 2010 at 10:25 PM, Hyrum K. Wright > wrote: >> >> >> On Tue, May 18, 2010

Re: svn commit: r945034 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/commit_util.c libsvn_wc/node.c

2010-05-19 Thread Greg Stein
On Mon, May 17, 2010 at 05:03, wrote: > Author: philip > Date: Mon May 17 09:03:36 2010 > New Revision: 945034 > > URL: http://svn.apache.org/viewvc?rev=945034&view=rev > Log: > * subversion/include/private/svn_wc_private.h >  (svn_wc__db_temp_get_keep_local): Renamed to ... >  (svn_wc__temp_get_

Re: svn commit: r945788 - in /subversion/trunk/subversion/libsvn_wc: adm_files.c adm_files.h diff.c

2010-05-19 Thread Greg Stein
On Tue, May 18, 2010 at 13:51, wrote: > Author: julianfoad > Date: Tue May 18 17:51:13 2010 > New Revision: 945788 > > URL: http://svn.apache.org/viewvc?rev=945788&view=rev > Log: > Start splitting up the uses of svn_wc__text_base_path() according to their > purpose: some wanted the path in order

Re: [WIP] Use repos_root_url and repos_relpath in the status code.

2010-05-19 Thread Greg Stein
On Wed, May 19, 2010 at 05:37, Bert Huijben wrote: >... >> +          abs_path = svn_uri_join(parent_url + strlen(wb->repos_root), >> +                                  svn_dirent_basename(local_abspath, > NULL), >> +                                  pool); > > And this has the same issues with en

RE: svn trunk r945350: PASS (x64-ubuntu gcc)

2010-05-19 Thread Bert Huijben
> -Original Message- > From: Joe Swatosh [mailto:joe.swat...@gmail.com] > Sent: woensdag 19 mei 2010 8:33 > To: dev@subversion.apache.org > Subject: Re: svn trunk r945350: PASS (x64-ubuntu gcc) > > Is the Ubuntu Buildbot the only one still sending to > svn-break...@subversion.tigris.org?

Re: svn commit: r945708 - in /subversion/branches/1.6.x-issue3469/subversion/libsvn_wc: adm_ops.c entries.c tree_conflicts.c

2010-05-19 Thread Johan Corveleyn
On Tue, May 18, 2010 at 5:42 PM, wrote: > Author: stsp > Date: Tue May 18 15:42:57 2010 > New Revision: 945708 > > URL: http://svn.apache.org/viewvc?rev=945708&view=rev > Log: > On the 1.6.x-issue3469 branch, fix issue #3469 "tree conflict inside of > directory external causes assertion to fail".

RE: [WIP] Use repos_root_url and repos_relpath in the status code.

2010-05-19 Thread Bert Huijben
> -Original Message- > From: Daniel Näslund [mailto:dan...@longitudo.com] > Sent: zondag 16 mei 2010 23:24 > To: dev@subversion.apache.org > Subject: [WIP] Use repos_root_url and repos_relpath in the status code. > > Hi! > > There's a lot of parameteter tracking in this patch. Basically

Re: 2-URL merges incorrectly reverse-merge mergeinfo for merge target?

2010-05-19 Thread Stefan Sperling
On Tue, May 18, 2010 at 09:34:37PM -0400, C. Michael Pilato wrote: > Stefan Sperling wrote: > > Given the subject line, I guess most of you realised that this mail > > is intended for Paul and any other merge-tracking nerds on this list :) > > > > Attached is a script that shows a merge which remo

Re: Possible svnsync bug

2010-05-19 Thread Jamma Tino Schwarze
Thanks for the quick confirmation. I filed it under issue number 3641. http://subversion.tigris.org/issues/show_bug.cgi?id=3641 Thanks, Jamma Tino. On Tue, May 18, 2010 at 06:09:08PM +0100, Philip Martin wrote: > Jamma Tino Schwarze writes: > > > During testing svnsync I came across an issue w