On Tue, May 18, 2010 at 13:51, <julianf...@apache.org> wrote: > Author: julianfoad > Date: Tue May 18 17:51:13 2010 > New Revision: 945788 > > URL: http://svn.apache.org/viewvc?rev=945788&view=rev > Log: > Start splitting up the uses of svn_wc__text_base_path() according to their > purpose: some wanted the path in order to delete the file, some to read it, > some to write it, some to move it. This patch creates and uses a separate > function for those callers that need the path to a file to read from. > > * subversion/libsvn_wc/adm_files.h, > subversion/libsvn_wc/adm_files.c > (svn_wc__get_working_node_pristine_file): New function. > > * subversion/libsvn_wc/diff.c > (delete_entry, close_file): Use svn_wc__get_working_node_pristine_file() > to replace one kind of usage of svn_wc__text_base_path().
I don't understand this. The uses do not necessarily have a WORKING node, so the function name doesn't seem right. The diff code might be asking for the pristine text associated with the BASE node (cuz there is no WORKING). >... I do understand/agree with the approach -- different names make it easier to reason about the code. But I dunno this reason :-P Cheers, -g
