On Wed, May 19, 2010 at 04:06:05PM -0700, Blair Zajac wrote: > On 05/19/2010 03:58 PM, [email protected] wrote: > >Author: stsp > >Date: Wed May 19 22:58:37 2010 > >New Revision: 946475 > > > >URL: http://svn.apache.org/viewvc?rev=946475&view=rev > >Log: > >* tools/dev/unix-build/Makefile.svn: Fix a comment typo. Set LD_LIBRARY_PATH > > when running tests for perl and python bindings. > > > > > svn-check-swig-pl: > >- cd $(svn_builddir)&& make check-swig-pl > >+ cd $(svn_builddir)&& \ > >+ env LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) make check-swig-pl > > I don't think you need the "env" here, isn't using > LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) sufficient, since our Makefile's > use Bourne shell by default.
It possibly is. I'm using env in a couple of other places in this file though. I don't think it hurts. Note that this isn't hooked up to our standard makefiles at all. It's just a wrapper that fetches dependencies, builds svn, can run multi-way tests and some other things. It may be worth lifting some functionality from it into our standard Makefile eventually. Basically I use it to build my own development builds, that's all. Thanks, Stefan
