Re: [PR] Bump de.thetaphi:forbiddenapis from 3.7 to 3.8 [incubator-stormcrawler]

2024-10-14 Thread via GitHub
jnioche merged PR #1359: URL: https://github.com/apache/incubator-stormcrawler/pull/1359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...

Re: [PR] Bump org.jetbrains:annotations from 25.0.0 to 26.0.0 [incubator-stormcrawler]

2024-10-14 Thread via GitHub
jnioche merged PR #1358: URL: https://github.com/apache/incubator-stormcrawler/pull/1358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...

[PR] Regenerated License file after dependency upgrades [incubator-stormcrawler]

2024-10-14 Thread via GitHub
github-actions[bot] opened a new pull request, #1360: URL: https://github.com/apache/incubator-stormcrawler/pull/1360 Found some uncommited changes (from license regeneration) after running build on StormCrawler main -- This is an automated message from the Apache Git Service. To respond

Re: [PR] #620 Add support for shards - SolrSpout [incubator-stormcrawler]

2024-10-14 Thread via GitHub
jnioche commented on code in PR #1343: URL: https://github.com/apache/incubator-stormcrawler/pull/1343#discussion_r1800461361 ## external/solr/setup-solr.sh: ## Review Comment: or in a sub directory? I am not against having an archetype for SOLR but so far there has bee

Re: [PR] #620 Add support for shards - SolrSpout [incubator-stormcrawler]

2024-10-14 Thread via GitHub
jnioche commented on code in PR #1343: URL: https://github.com/apache/incubator-stormcrawler/pull/1343#discussion_r1800465804 ## external/solr/src/main/java/org/apache/stormcrawler/solr/persistence/SolrSpout.java: ## @@ -135,7 +157,8 @@ else if (resetFetchDateAfterNSecs != -1)

Re: [PR] #620 Add support for shards - SolrSpout [incubator-stormcrawler]

2024-10-14 Thread via GitHub
jnioche commented on code in PR #1343: URL: https://github.com/apache/incubator-stormcrawler/pull/1343#discussion_r1800469984 ## external/solr/src/main/java/org/apache/stormcrawler/solr/persistence/SolrSpout.java: ## @@ -156,10 +176,15 @@ else if (resetFetchDateAfterNSecs != -1

Re: [PR] #620 Add support for shards - SolrSpout [incubator-stormcrawler]

2024-10-14 Thread via GitHub
jnioche commented on code in PR #1343: URL: https://github.com/apache/incubator-stormcrawler/pull/1343#discussion_r1800472853 ## external/solr/src/test/java/org/apache/stormcrawler/solr/persistence/SpoutTest.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Fou

[GH] (incubator-stormcrawler): Workflow run "Java CI with Maven" is working again!

2024-10-14 Thread GitBox
The GitHub Actions job "Java CI with Maven" on incubator-stormcrawler.git has succeeded. Run started by GitHub user mvolikas (triggered by mvolikas). Head commit for run: 27d71c9683b140bde338f7475c223b7d9abd14c6 / Markos Volikas #620 add license Report URL: https://github.com/apache/incubato

[GH] (incubator-stormcrawler): Workflow run "Java CI with Maven" failed!

2024-10-14 Thread GitBox
The GitHub Actions job "Java CI with Maven" on incubator-stormcrawler.git has failed. Run started by GitHub user mvolikas (triggered by mvolikas). Head commit for run: e1ee25d90675770936fd2f22c39385addc7403d4 / Markos Volikas #620 add Solr spout test Report URL: https://github.com/apache/inc

Re: [PR] #620 Add support for shards - SolrSpout [incubator-stormcrawler]

2024-10-14 Thread via GitHub
mvolikas commented on code in PR #1343: URL: https://github.com/apache/incubator-stormcrawler/pull/1343#discussion_r1799832189 ## external/solr/src/main/java/org/apache/stormcrawler/solr/persistence/SolrSpout.java: ## @@ -135,7 +157,8 @@ else if (resetFetchDateAfterNSecs != -1)

Re: [PR] #620 Add support for shards - SolrSpout [incubator-stormcrawler]

2024-10-14 Thread via GitHub
mvolikas commented on code in PR #1343: URL: https://github.com/apache/incubator-stormcrawler/pull/1343#discussion_r1799838080 ## external/solr/src/main/java/org/apache/stormcrawler/solr/persistence/SolrSpout.java: ## @@ -156,10 +176,15 @@ else if (resetFetchDateAfterNSecs != -

Re: [PR] #620 Add support for shards - SolrSpout [incubator-stormcrawler]

2024-10-14 Thread via GitHub
mvolikas commented on code in PR #1343: URL: https://github.com/apache/incubator-stormcrawler/pull/1343#discussion_r1799842927 ## external/solr/src/test/java/org/apache/stormcrawler/solr/persistence/SpoutTest.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Fo