jnioche commented on code in PR #1343:
URL: 
https://github.com/apache/incubator-stormcrawler/pull/1343#discussion_r1800465804


##########
external/solr/src/main/java/org/apache/stormcrawler/solr/persistence/SolrSpout.java:
##########
@@ -135,7 +157,8 @@ else if (resetFetchDateAfterNSecs != -1) {
 
         query.setQuery("*:*")
                 .addFilterQuery("nextFetchDate:[* TO " + lastNextFetchDate + 
"]")
-                .setSort("nextFetchDate", ORDER.asc);
+                .setSort("nextFetchDate", ORDER.asc)
+                .setParam("shards", "shard" + shardID);

Review Comment:
   I would simply not set the param constraint in the query if the config for 
the number of shards is set or defaults to 1, this way it wouldn't matter how 
the collection is configured - you would get all the results. Doesn't matter 
too much though and the current behaviour is also fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to