mvolikas commented on code in PR #1343:
URL: 
https://github.com/apache/incubator-stormcrawler/pull/1343#discussion_r1799838080


##########
external/solr/src/main/java/org/apache/stormcrawler/solr/persistence/SolrSpout.java:
##########
@@ -156,10 +176,15 @@ else if (resetFetchDateAfterNSecs != -1) {
         LOG.debug("QUERY => {}", query);
 
         try {
+            LOG.trace("isInQuery set to true");
+            isInQuery.set(true);
+
             long startQuery = System.currentTimeMillis();
             QueryResponse response = connection.getClient().query(query);
             long endQuery = System.currentTimeMillis();
 
+            markQueryReceivedNow();
+

Review Comment:
   I guess the `isInQuery.set(true)` and `markQueryReceivedNow()` are only 
relevant when the calls to Solr are asynchronous right? If so, we will have to 
review this for #621.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to