Re: Review Request 30825: SAMZA-547: Add Java Serializable Serde

2015-02-11 Thread Ruslan Khafizov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30825/ --- (Updated Feb. 11, 2015, 1:31 p.m.) Review request for samza. Repository: samz

Re: [DISCUSS] SQL workflow

2015-02-11 Thread Milinda Pathirage
Hi Chris, Do you need me to create the SAMZA-483 patch against latest master with SAMZA-482 patch? I think that will make it easier to review the patch? Thanks Milinda On Mon, Feb 9, 2015 at 11:39 AM, Chris Riccomini wrote: > Cool. Looks like we've got consensus. I'll move forward with RTC on

Re: [DISCUSS] SQL workflow

2015-02-11 Thread Milinda Pathirage
/need/want Milinda On Wed, Feb 11, 2015 at 12:22 PM, Milinda Pathirage wrote: > Hi Chris, > > Do you need me to create the SAMZA-483 patch against latest master with > SAMZA-482 patch? I think that will make it easier to review the patch? > > Thanks > Milinda > > On Mon, Feb 9, 2015 at 11:39 AM

Re: [DISCUSS] SQL workflow

2015-02-11 Thread Chris Riccomini
Hey Milinda, That'd be great. Do you have any dependency on SAMZA-484? I haven't had a chance to commit that one yet. Cheers, Chris On Wed, Feb 11, 2015 at 9:23 AM, Milinda Pathirage wrote: > /need/want > > Milinda > > On Wed, Feb 11, 2015 at 12:22 PM, Milinda Pathirage > > wrote: > > > Hi Ch

Re: [DISCUSS] SQL workflow

2015-02-11 Thread Milinda Pathirage
No, SAMZA-483 doesn't depend on SAMZA-484. But we need to add Calcite as a dependency and Calcite streaming support is only in Julian's branch ( https://github.com/julianhyde/incubator-calcite/tree/chi). What can we do about that? Milinda On Wed, Feb 11, 2015 at 12:30 PM, Chris Riccomini wrote:

Re: [DISCUSS] SQL workflow

2015-02-11 Thread Chris Riccomini
Hey Milinda, I've just committed SAMZA-484, so you should be able to re-base and get all the latest code. > But we need to add Calcite as a dependency and Calcite streaming support is only in Julian's branch We'll have to have Julian publish a release to Apache. This can be a SNAPSHOT to Apache'

Re: [DISCUSS] SQL workflow

2015-02-11 Thread Chris Riccomini
Hey Julian, It looks like Calcite is at least setup to publish to Maven: https://repository.apache.org/#nexus-search;quick~calcite Julian, can you publish SNAPSHOT releases with your streaming changes to it? Thanks! Chris On Wed, Feb 11, 2015 at 10:08 AM, Chris Riccomini wrote: > Hey Milin

RE: [DISCUSS] SQL workflow

2015-02-11 Thread Felix GV
I guess one concern with Calcite SNAPSHOT releases is that they imply they'll be included in the next release, which may not be the case if they're still considered very experimental. Alternatively, perhaps Julian can create a new version name with a classifier for streaming. http://maven.apac

Re: [DISCUSS] SQL workflow

2015-02-11 Thread Julian Hyde
This seems more like a branch than a classifier. Calcite is developing in a branch, and would produce snapshots from that branch. The rule of thumb I’ve learned integrating Calcite into Hive is that only a branch should depend on snapshot versions of another component. (Hive broke this rule and

Re: Review Request 30667: Samza Calcite Integration Prototype (SAMZA-483)

2015-02-11 Thread Milinda Pathirage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30667/ --- (Updated Feb. 12, 2015, 3:47 a.m.) Review request for samza, Chris Riccomini, J