Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-17 Thread Jake Maes
> On Aug. 16, 2016, 12:50 a.m., Navina Ramesh wrote: > > docs/learn/tutorials/versioned/samza-rest-getting-started.md, line 73 > > > > > > Should change run-samza-rest-service.sh to be executable (chmod 755) > > Jake

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-17 Thread Jake Maes
> On Aug. 16, 2016, 12:50 a.m., Navina Ramesh wrote: > > docs/learn/tutorials/versioned/samza-rest-getting-started.md, line 88 > > > > > > I am running in to an issue of not finding config files in the path > > speci

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-17 Thread Jake Maes
> On Aug. 16, 2016, 12:50 a.m., Navina Ramesh wrote: > > docs/learn/tutorials/versioned/samza-rest-getting-started.md, line 88 > > > > > > I am running in to an issue of not finding config files in the path > > speci

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-16 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/#review145962 --- Ship it! Ship It! - Navina Ramesh On Aug. 17, 2016, 1:58 a.m

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-16 Thread Navina Ramesh
> On Aug. 16, 2016, 12:50 a.m., Navina Ramesh wrote: > > docs/learn/tutorials/versioned/samza-rest-getting-started.md, line 73 > > > > > > Should change run-samza-rest-service.sh to be executable (chmod 755) > > Jake

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-16 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/ --- (Updated Aug. 17, 2016, 1:58 a.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-16 Thread Jake Maes
> On Aug. 16, 2016, 12:50 a.m., Navina Ramesh wrote: > > Reminder: This review is for the doc, not the code. So any code feedback will not be reflected in this review. Instead see https://reviews.apache.org/r/50151/ > On Aug. 16, 2016, 12:50 a.m., Navina Ramesh wrote: > > docs/learn/tutorials

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-16 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/ --- (Updated Aug. 17, 2016, 1:45 a.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-16 Thread Jake Maes
> On Aug. 16, 2016, 12:55 a.m., Navina Ramesh wrote: > > One last comment: Can you attach the .png file to the JIRA? Otherwise, the > > local deployment has a broken link. done - Jake --- This is an automatically generated e-mail. To r

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-15 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/#review145823 --- docs/learn/documentation/versioned/rest/monitors.md (line 23)

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-15 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/#review145822 --- One last comment: Can you attach the .png file to the JIRA? Otherw

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-08-15 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/#review144296 --- bin/generate-javadocs.sh (line 21)

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-29 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/ --- (Updated July 29, 2016, 6:58 p.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-29 Thread Jake Maes
> On July 27, 2016, 9:36 p.m., Navina Ramesh wrote: > > I think it will be simpler if we can just provide architectural overview in > > the website and add a separate tutorial to run it with samza-hello-samza. > > Thanks! > > Jake Maes wrote: > So, do you suggest moving the deployment step

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-29 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/ --- (Updated July 29, 2016, 6:53 p.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-27 Thread Jake Maes
> On July 27, 2016, 9:36 p.m., Navina Ramesh wrote: > > I think it will be simpler if we can just provide architectural overview in > > the website and add a separate tutorial to run it with samza-hello-samza. > > Thanks! So, do you suggest moving the deployment steps to the tutorial or duplic

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-27 Thread Jake Maes
> On July 27, 2016, 9:37 p.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/rest/overview.md, line 104 > > > > > > Is there is no default log4j in the generate tar ball, it will good to > > move this

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-27 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/#review143826 --- docs/learn/documentation/versioned/rest/overview.md (line 104)

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-27 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/#review143777 --- I think it will be simpler if we can just provide architectural ov

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-27 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/ --- (Updated July 27, 2016, 8:47 p.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-27 Thread Jake Maes
> On July 27, 2016, 12:52 a.m., Navina Ramesh wrote: > > bin/generate-javadocs.sh, line 22 > > > > > > Ok. You are almost there :) > > > > This will overwrite the index files that you copied over for samza-a

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-27 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/ --- (Updated July 27, 2016, 6:12 p.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-27 Thread Jake Maes
> On July 27, 2016, 12:52 a.m., Navina Ramesh wrote: > > bin/generate-javadocs.sh, line 22 > > > > > > Ok. You are almost there :) > > > > This will overwrite the index files that you copied over for samza-a

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-26 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/#review143649 --- bin/generate-javadocs.sh (line 22)

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-26 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/ --- (Updated July 27, 2016, 12:28 a.m.) Review request for samza, Boris Shkolnik, C

Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-18 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina Rames