> On July 27, 2016, 9:37 p.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/rest/overview.md, line 104 > > <https://reviews.apache.org/r/50154/diff/4/?file=1455494#file1455494line104> > > > > Is there is no default log4j in the generate tar ball, it will good to > > move this "fyi" info above near the deployment steps.
Can you double check? I see the log4j file in the extracted dir: ``` samza[master] > cd samza-rest/build/distributions/deploy/samza-rest/bin/ bin[master] > ls total 32 drwxr-xr-x 5 jmaes 170B Jul 27 13:38 ./ drwxr-xr-x 9 jmaes 306B Jul 27 13:39 ../ -rw-r--r-- 1 jmaes 1.4K Jun 15 11:26 log4j.xml -rwxr-xr-x 1 jmaes 4.8K Apr 14 14:23 run-class.sh* -rwxr-xr-x 1 jmaes 1.0K Jul 11 11:49 run-samza-rest-service.sh* ``` - Jake ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/#review143826 ----------------------------------------------------------- On July 27, 2016, 8:47 p.m., Jake Maes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50154/ > ----------------------------------------------------------- > > (Updated July 27, 2016, 8:47 p.m.) > > > Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina > Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). > > > Bugs: SAMZA-976 > https://issues.apache.org/jira/browse/SAMZA-976 > > > Repository: samza > > > Description > ------- > > SAMZA-976 Samza REST Documentation > > > Diffs > ----- > > bin/generate-javadocs.sh da9f32da8f2a1f89ff28178ee703c4a065189da8 > docs/img/versioned/learn/documentation/rest/JobsResource.png PRE-CREATION > docs/learn/documentation/versioned/index.html > 1e79bd6f39ee67b5a2b74222d647342990bbbe23 > docs/learn/documentation/versioned/rest/monitors.md PRE-CREATION > docs/learn/documentation/versioned/rest/overview.md PRE-CREATION > docs/learn/documentation/versioned/rest/resource-directory.md PRE-CREATION > docs/learn/documentation/versioned/rest/resources.md PRE-CREATION > docs/learn/documentation/versioned/rest/resources/jobs.md PRE-CREATION > > Diff: https://reviews.apache.org/r/50154/diff/ > > > Testing > ------- > > Verified by building the local site documentation and browsing. I wasn't able > to verify the javadoc. If anyone knows why java doc would not be generated > for new classes, I'd be interested to know. > > > Thanks, > > Jake Maes > >
