Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review163545 --- Thanks Hai for the docs! Committed to master. - Jagadish Venkatra

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/ --- (Updated Jan. 28, 2017, 6:15 a.m.) Review request for samza. Bugs: SAMZA-1025

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review163355 --- Fix it, then Ship it! Some nits and comments. Otherwise, looks

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

> On Jan. 25, 2017, 10:36 p.m., Jagadish Venkatraman wrote: > > docs/learn/documentation/versioned/hdfs/consumer.md, line 67 > > > > > > The relationship between whitelist and blacklist was not very obvious > > to me

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

> On Jan. 25, 2017, 10:50 p.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/hdfs/consumer.md, line 26 > > > > > > Can you include the diagram from your design document? Or something > > similar to el

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review16 --- Ship it! Thanks! docs/learn/documentation/versioned/hdfs/cons

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

> On Jan. 27, 2017, 7:03 a.m., Jagadish Venkatraman wrote: > > This is looking pretty good. Thank you for the effort in writing the docs! Thank you for taking the time to review it. Really appreciate it:) > On Jan. 27, 2017, 7:03 a.m., Jagadish Venkatraman wrote: > > docs/learn/documentation/v

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/ --- (Updated Jan. 27, 2017, 5:48 p.m.) Review request for samza. Bugs: SAMZA-1025

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review163234 --- This is looking pretty good. Thank you for the effort in writing t

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/ --- (Updated Jan. 27, 2017, 12:03 a.m.) Review request for samza. Bugs: SAMZA-102

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

> On Jan. 26, 2017, 10:49 p.m., Jagadish Venkatraman wrote: > > docs/learn/documentation/versioned/hdfs/consumer.md, line 92 > > > > > > nit: Use capitalizations consistently > > > > 1. Is `id` of any signifi

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

> On Jan. 25, 2017, 10:36 p.m., Jagadish Venkatraman wrote: > > docs/learn/documentation/versioned/hdfs/consumer.md, line 97 > > > > > > Not clear to me how this differs from the whitelist (*.avro which > > specifies

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review163177 --- docs/learn/documentation/versioned/hdfs/consumer.md (line 22)

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/ --- (Updated Jan. 26, 2017, 6:47 p.m.) Review request for samza. Bugs: SAMZA-1025

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

> On Jan. 25, 2017, 10:50 p.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/hdfs/consumer.md, line 26 > > > > > > Can you include the diagram from your design document? Or something > > similar to el

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

> On Jan. 25, 2017, 10:36 p.m., Jagadish Venkatraman wrote: > > docs/learn/documentation/versioned/hdfs/consumer.md, line 67 > > > > > > The relationship between whitelist and blacklist was not very obvious > > to me

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review163036 --- Thanks for adding the documentation! docs/learn/documentation/ve

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review163011 --- docs/learn/documentation/versioned/hdfs/consumer.md (line 22)

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review162971 --- Fix it, then Ship it! Looks good. Have a few minor comments abo

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/ --- (Updated Jan. 24, 2017, 2:07 a.m.) Review request for samza. Bugs: SAMZA-1025

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review155740 --- docs/learn/documentation/versioned/hdfs/consumer.md (line 22)