> On Jan. 25, 2017, 10:50 p.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/hdfs/consumer.md, line 26 > > <https://reviews.apache.org/r/52570/diff/2/?file=1613256#file1613256line26> > > > > Can you include the diagram from your design document? Or something > > similar to elaborate how the setup should look like?
The diagram was mostly for the situation at LinkedIn where we have separte yarn clusters - one for Samza, one for Hadoop. "Your job needs to run on the same YARN cluster which hosts the HDFS you want to consume from." Is this statement not clear enough? What suggestion do you have in terms of the wording? > On Jan. 25, 2017, 10:50 p.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/hdfs/consumer.md, line 42 > > <https://reviews.apache.org/r/52570/diff/2/?file=1613256#file1613256line42> > > > > Can you add a snippet of the interface here as well? It is easier for > > the user to skim through. Linked to the java doc. > On Jan. 25, 2017, 10:50 p.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/hdfs/consumer.md, line 50 > > <https://reviews.apache.org/r/52570/diff/2/?file=1613256#file1613256line50> > > > > Replace "users" with "user application". > > > > We provide the capability for the user application to get notified when > > ... > > > > Rephrase "To do so, simply implement the interface > > [EndOfStreamListenerTask]" as "In order to receieve notications on > > EndOfStream with the task, the user application should simply implement the > > interface ..." I changed the wording as Jagadish suggested above. Let me know if you have further suggestion on top of that. - Hai ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review163036 ----------------------------------------------------------- On Jan. 24, 2017, 2:07 a.m., Hai Lu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52570/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 2:07 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-1025 > https://issues.apache.org/jira/browse/SAMZA-1025 > > > Repository: samza > > > Description > ------- > > documentation for hdfs system consumer > > > Diffs > ----- > > docs/learn/documentation/versioned/hdfs/consumer.md PRE-CREATION > docs/learn/documentation/versioned/hdfs/producer.md > b0e936f5b0a9c945ea7f02bfc2536ef50f017bf6 > docs/learn/documentation/versioned/index.html > d0b14ece94341e2cb937cf32db480e69f93303c2 > docs/learn/documentation/versioned/jobs/configuration-table.html > ba5ebbc54b5c64f82f35ed781dad7023a8f920e1 > > Diff: https://reviews.apache.org/r/52570/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Hai Lu > >
