> On Jan. 25, 2017, 10:36 p.m., Jagadish Venkatraman wrote: > > docs/learn/documentation/versioned/hdfs/consumer.md, line 67 > > <https://reviews.apache.org/r/52570/diff/2/?file=1613256#file1613256line67> > > > > The relationship between whitelist and blacklist was not very obvious > > to me. > > > > Is the behavior that the whitelist is applied first, and the blacklist > > is applied to the matched files later? (to determine which files are to be > > ignored).
The order doesn't matter. (X & whitelist) - blacklist == (X - blacklist) & whitelist > On Jan. 25, 2017, 10:36 p.m., Jagadish Venkatraman wrote: > > docs/learn/documentation/versioned/hdfs/consumer.md, line 97 > > <https://reviews.apache.org/r/52570/diff/2/?file=1613256#file1613256line97> > > > > Not clear to me how this differs from the whitelist (*.avro which > > specifies what files to process). They completely different: reader is the type of data encoded in the file content; whitelist is used to filter based on file name. Technically you can have an avro file that has ".java" as it's extention, right? > On Jan. 25, 2017, 10:36 p.m., Jagadish Venkatraman wrote: > > docs/learn/documentation/versioned/jobs/configuration-table.html, line 1819 > > <https://reviews.apache.org/r/52570/diff/2/?file=1613259#file1613259line1819> > > > > What's this configuration? Is this the number of messages? What are the > > implications of this? > > > > I'm not in favor of exposing this tunable if this is not > > super-significant. This is important for performance tuning in some cases. Added a bit more details to explain - Hai ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review163011 ----------------------------------------------------------- On Jan. 24, 2017, 2:07 a.m., Hai Lu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52570/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 2:07 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-1025 > https://issues.apache.org/jira/browse/SAMZA-1025 > > > Repository: samza > > > Description > ------- > > documentation for hdfs system consumer > > > Diffs > ----- > > docs/learn/documentation/versioned/hdfs/consumer.md PRE-CREATION > docs/learn/documentation/versioned/hdfs/producer.md > b0e936f5b0a9c945ea7f02bfc2536ef50f017bf6 > docs/learn/documentation/versioned/index.html > d0b14ece94341e2cb937cf32db480e69f93303c2 > docs/learn/documentation/versioned/jobs/configuration-table.html > ba5ebbc54b5c64f82f35ed781dad7023a8f920e1 > > Diff: https://reviews.apache.org/r/52570/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Hai Lu > >
