Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/ --- (Updated Sept. 22, 2016, 7:11 p.m.) Review request for samza, Chris Pettitt, Na

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

> On Sept. 16, 2016, 8:58 p.m., Yi Pan (Data Infrastructure) wrote: > > docs/learn/tutorials/versioned/samza-async-user-guide.md, line 71 > > > > > > The explanation of "processAsync() will always be invoked in a sing

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/ --- (Updated Sept. 19, 2016, 5:23 p.m.) Review request for samza, Chris Pettitt, Na

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review149262 --- Thanks for the detailed write-up! Really helpful document. Please

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/ --- (Updated Sept. 16, 2016, 5:37 p.m.) Review request for samza, Chris Pettitt, Na

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

> On Sept. 14, 2016, 12:43 a.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/api/overview.md, line 44 > > > > > > We need a more concrete example of how to use callback functionality > > here. It is n

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

> On Sept. 14, 2016, 12:37 a.m., Yi Pan (Data Infrastructure) wrote: > > docs/learn/documentation/versioned/container/event-loop.md, line 28 > > > > > > What about thread-safety among multiple process() operations?

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/ --- (Updated Sept. 16, 2016, 5:33 p.m.) Review request for samza, Chris Pettitt, Na

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review148826 --- Fix it, then Ship it! I think I have all my comments called out

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review148824 --- Fix it, then Ship it! lgtm overall. Thanks! docs/learn/docume

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

> On Sept. 7, 2016, 6:01 p.m., Yi Pan (Data Infrastructure) wrote: > > docs/learn/documentation/versioned/api/overview.md, line 49 > > > > > > This is a bit confusing. If I read these two comment lines as pseudo > >

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/ --- (Updated Sept. 13, 2016, 9 p.m.) Review request for samza, Chris Pettitt, Navin

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

> On Aug. 31, 2016, 12:54 a.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/jobs/configuration-table.html, line 357 > > > > > > Is it too late to comment on the config key pattern? Traditionally, we

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

> On Aug. 30, 2016, 1 a.m., Xinyu Liu wrote: > > docs/learn/documentation/versioned/jobs/configuration-table.html, line 368 > > > > > > oh, actually the job.container.single.thread.mode means using the old > > runl

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review148041 --- Thanks for the detailed doc. I mainly have question regarding to t

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/ --- (Updated Sept. 7, 2016, 5:16 p.m.) Review request for samza, Chris Pettitt, Nav

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

> On Aug. 31, 2016, 12:54 a.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/api/overview.md, line 49 > > > > > > // fire callback after process complete > > >> Is the user expected to invoke the c

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

> On Aug. 25, 2016, 12:31 a.m., Navina Ramesh wrote: > > Not that I intend to give you more work. However, adding an example of > > AsyncStreamTask to samza's hello-world will give a quick idea to the user > > on when to use it and how to use it. This can be augmented in a tutorial > > page, s

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

> On Aug. 25, 2016, 12:30 a.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/jobs/configuration-table.html, line 360 > > > > > > Isn't there a performance impact if we use AsyncStreamTask by default?

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

> On Aug. 25, 2016, 12:30 a.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/container/event-loop.md, line 49 > > > > > > Does anything change with respect to adding "task.subtask.class" in the > > pro

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review147388 --- docs/learn/documentation/versioned/api/overview.md (line 49)

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

> On Aug. 25, 2016, 12:30 a.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/container/event-loop.md, line 24 > > > > > > There is no sharing of task state in Samza. Each task guarantee > > isolation f

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

> On Aug. 25, 2016, 12:30 a.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/api/overview.md, line 22 > > > > > > "You should implement StreamTask for synchronous process, e.g. a > > computation that d

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review147252 --- docs/learn/documentation/versioned/jobs/configuration-table.html

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/ --- (Updated Aug. 30, 2016, 12:49 a.m.) Review request for samza, Chris Pettitt, Na

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review146739 --- Not that I intend to give you more work. However, adding an exampl

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review146554 --- docs/learn/documentation/versioned/api/overview.md (line 22)

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review143972 --- Ship it! Looks like this covers my comments. However, the docum

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review143847 --- docs/learn/documentation/versioned/api/overview.md (line 22)

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

> On July 20, 2016, 7:06 p.m., Chris Pettitt wrote: > > docs/learn/documentation/versioned/container/event-loop.md, line 43 > > > > > > s/in the a single thread/in a single thread/. > > > > A few other minor

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/ --- (Updated July 27, 2016, 11:05 p.m.) Review request for samza, Chris Pettitt, Na

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review142985 --- docs/learn/documentation/versioned/api/overview.md (line 22)