> On Sept. 7, 2016, 6:01 p.m., Yi Pan (Data Infrastructure) wrote: > > docs/learn/documentation/versioned/api/overview.md, line 49 > > <https://reviews.apache.org/r/50174/diff/4/?file=1493027#file1493027line49> > > > > This is a bit confusing. If I read these two comment lines as pseudo > > code, I would think that the same thread is going to call asynchronous > > calls and fire callback. Is it the case? I thought that the callback is > > triggered in a callback thread, not in the main thread invoking the > > asynchronous calls?
I agree. I modified the sentence to // fire callback upon completion, e.g. invoking callback from asynchronous call completion thread. Does it looks clear to you? > On Sept. 7, 2016, 6:01 p.m., Yi Pan (Data Infrastructure) wrote: > > docs/learn/documentation/versioned/container/event-loop.md, line 28 > > <https://reviews.apache.org/r/50174/diff/4/?file=1493028#file1493028line28> > > > > This section is a bit confusing to me. The description above in > > "Without..." sounds like that we are implementing read-after-write > > consistency on global variables. Here we are saying that global variables > > have to implement the sync method by the user. Good point. I read it again and it's pretty confusing. I think the latter part is for states within a task, like member variables. I updated the doc based on that. > On Sept. 7, 2016, 6:01 p.m., Yi Pan (Data Infrastructure) wrote: > > docs/learn/documentation/versioned/container/event-loop.md, line 36 > > <https://reviews.apache.org/r/50174/diff/4/?file=1493028#file1493028line36> > > > > So, this describes the AsyncRunLoop logic. Don't we still have the > > synchronous RunLoop in SamzaContainer? Since in default the RunLoop is not used anymore, so I remove its description. Since we are planning to deprecate the runLoop soon, I think we only need to describe the new run loop, right? > On Sept. 7, 2016, 6:01 p.m., Yi Pan (Data Infrastructure) wrote: > > docs/learn/documentation/versioned/container/event-loop.md, line 50 > > <https://reviews.apache.org/r/50174/diff/4/?file=1493028#file1493028line50> > > > > from *a* different user thread. Good catch! Thanks! - Xinyu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review148041 ----------------------------------------------------------- On Sept. 13, 2016, 9 p.m., Xinyu Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50174/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2016, 9 p.m.) > > > Review request for samza, Chris Pettitt, Navina Ramesh, and Yi Pan (Data > Infrastructure). > > > Repository: samza > > > Description > ------- > > Update samza web docs with new multithreading api, core and configs. > > > Diffs > ----- > > docs/learn/documentation/versioned/api/overview.md > 6712344e84e19883b857e00549db2acb101c7e0e > docs/learn/documentation/versioned/container/event-loop.md > 116238312df7071747cbbc14bc9c46f558755195 > docs/learn/documentation/versioned/jobs/configuration-table.html > 54c52981c3055b398ee60af50eeaf2592ed0e64f > > Diff: https://reviews.apache.org/r/50174/diff/ > > > Testing > ------- > > Test the web pages locally. > > > Thanks, > > Xinyu Liu > >
