> On Aug. 25, 2016, 12:30 a.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/jobs/configuration-table.html, line 360 > > <https://reviews.apache.org/r/50174/diff/2/?file=1455861#file1455861line360> > > > > Isn't there a performance impact if we use AsyncStreamTask by default? > > Esp. on jobs that don't need any async processing. > > Why is the default value false? > > > > If users upgrade to the new version and automatically start using > > multithreaded execution, will they see any performance impact? > > Xinyu Liu wrote: > The default of new AsyncRunLoop is still running in a single thread, and > the performance is on par with the previous RUnLoop. So the users shouldn't > see any perf difference.
Ok. I think the performance results are pretty important. Can you add a link to the performance test results pdf - https://issues.apache.org/jira/secure/attachment/12812335/perf-test-results.pdf, probably appropriate in the event-loop.md where you mention the guarantees that Samza provides. - Navina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review146554 ----------------------------------------------------------- On Aug. 30, 2016, 12:49 a.m., Xinyu Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50174/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 12:49 a.m.) > > > Review request for samza, Chris Pettitt, Navina Ramesh, and Yi Pan (Data > Infrastructure). > > > Repository: samza > > > Description > ------- > > Update samza web docs with new multithreading api, core and configs. > > > Diffs > ----- > > docs/learn/documentation/versioned/api/overview.md > 6712344e84e19883b857e00549db2acb101c7e0e > docs/learn/documentation/versioned/container/event-loop.md > 116238312df7071747cbbc14bc9c46f558755195 > docs/learn/documentation/versioned/jobs/configuration-table.html > 54c52981c3055b398ee60af50eeaf2592ed0e64f > > Diff: https://reviews.apache.org/r/50174/diff/ > > > Testing > ------- > > Test the web pages locally. > > > Thanks, > > Xinyu Liu > >
