Re: Review Request 37026: SAMZA-727: Support for Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/#review136744 --- samza-core/src/main/java/org/apache/samza/container/SecurityManag

Re: Review Request 37026: SAMZA-727: Support for Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/#review136742 --- samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaYarnSecu

Re: Review Request 37026: SAMZA-727: Support for Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/#review136733 --- Fix it, then Ship it! LGTM. We are also trying to test it inter

Re: Review Request 37026: SAMZA-727: Support for Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/ --- (Updated June 8, 2016, 7:10 p.m.) Review request for samza. Repository: samza

Re: Review Request 37026: SAMZA-727: Support for Kerberos

> On May 24, 2016, 3:31 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala, > > line 111 > > > > > > Instead of removing this completely, I think

Re: Review Request 37026: SAMZA-727: Support for Kerberos

> On April 27, 2016, 9:16 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java, line 131 > > > > > > This configuration is missing in the doc patch. > > Chen

Re: Review Request 37026: SAMZA-727: Support for Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/#review134608 --- I was able to build after fixing the test class methods. Please fi

Re: Review Request 37026: SAMZA-727: Support for Kerberos

> On May 24, 2016, 3:31 a.m., Yi Pan (Data Infrastructure) wrote: > > Hi, Chen, thanks for the update! One more comment: please rebase the patch > > against the latest master s.t. it can be applied cleanly. > > > > Thanks! > > Yi Pan (Data Infrastructure) wrote: > Before it is too late. I

Re: Review Request 37026: SAMZA-727: Support for Kerberos

> On May 24, 2016, 3:31 a.m., Yi Pan (Data Infrastructure) wrote: > > Hi, Chen, thanks for the update! One more comment: please rebase the patch > > against the latest master s.t. it can be applied cleanly. > > > > Thanks! Before it is too late. I tried to rebase and ran the compilation and no

Re: Review Request 37026: SAMZA-727: Support for Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/#review134501 --- Fix it, then Ship it! Hi, Chen, thanks for the update! One more

Re: Review Request 37026: SAMZA-727: Support for Kerberos

> On April 27, 2016, 9:16 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java, line 131 > > > > > > This configuration is missing in the doc patch. Will upd

Re: Review Request 37026: SAMZA-727: Support for Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/ --- (Updated May 8, 2016, 12:50 a.m.) Review request for samza. Changes ---

Re: Review Request 37026: SAMZA-727: Support for Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/ --- (Updated May 7, 2016, 10:38 p.m.) Review request for samza. Changes ---

Re: Review Request 37026: SAMZA-727: Support for Kerberos

> On April 27, 2016, 9:16 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala, > > line 271 > > > > > > Shouldn't the second be YarnConfig.YARN_KEBERO

Re: Review Request 37026: SAMZA-727: Support for Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/#review130672 --- Thanks, @Chen Song for pulling this off! Overall lgtm. I have a hi

Re: Review Request 37026: SAMZA-727: Support for Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/ --- (Updated April 14, 2016, 9:26 p.m.) Review request for samza. Repository: sam

Re: Review Request 37026: SAMZA-727: Support for Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/ --- (Updated April 14, 2016, 9:26 p.m.) Review request for samza. Repository: sam

Re: Review Request 37026: SAMZA-727: Support for Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/ --- (Updated April 14, 2016, 9:22 p.m.) Review request for samza. Repository: sam

Re: Review Request 37026: SAMZA-727: Support for Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/ --- (Updated Dec. 3, 2015, 9:05 p.m.) Review request for samza. Repository: samza