----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/#review134501 -----------------------------------------------------------
Fix it, then Ship it! Hi, Chen, thanks for the update! One more comment: please rebase the patch against the latest master s.t. it can be applied cleanly. Thanks! samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java (line 110) <https://reviews.apache.org/r/37026/#comment199364> nit: there are a mis-spelling of "keberos" in this string and the next one, which should be corrected: - YARN_KEBEROS_PRINCIPAL ==> YARN_KERBEROS_PRINCIPAL - YARN_KEBEROS_KEYTAB ==> YARN_KERBEROS_KEYTAB samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java (line 197) <https://reviews.apache.org/r/37026/#comment199365> Mis-spelling here as well: "keberos" should be "kerberos". samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala <https://reviews.apache.org/r/37026/#comment199370> Instead of removing this completely, I think it would be better to keep this code when the application exiting status is either "SUCCEEDED" or "KILLED" (defined in FinalApplicationStatus class). - Yi Pan (Data Infrastructure) On May 8, 2016, 12:50 a.m., Chen Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37026/ > ----------------------------------------------------------- > > (Updated May 8, 2016, 12:50 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Basic support for kerberization based on keytab authentication. > > > Diffs > ----- > > build.gradle 16facbb > samza-core/src/main/java/org/apache/samza/container/SecurityManager.java > PRE-CREATION > > samza-core/src/main/java/org/apache/samza/container/SecurityManagerFactory.java > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 4d5ca4d > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > 5462208 > samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java c556d83 > samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala > 74a0676 > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala > 80deb3b > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterSecurityManager.scala > PRE-CREATION > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterService.scala > 3adf86f > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaContainerSecurityManager.scala > PRE-CREATION > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaYarnSecurityManagerFactory.scala > PRE-CREATION > samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJob.scala 62ddb26 > samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestClientHelper.scala > PRE-CREATION > > samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterService.scala > 7f5d9f4 > > Diff: https://reviews.apache.org/r/37026/diff/ > > > Testing > ------- > > > Thanks, > > Chen Song > >
