> On May 24, 2016, 3:31 a.m., Yi Pan (Data Infrastructure) wrote: > > Hi, Chen, thanks for the update! One more comment: please rebase the patch > > against the latest master s.t. it can be applied cleanly. > > > > Thanks! > > Yi Pan (Data Infrastructure) wrote: > Before it is too late. I tried to rebase and ran the compilation and > notice that there are some :rat errors on the following two files: > Unknown license: > /home/yipan/workspace/samza_master/samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaYarnSecurityManagerFactory.scala > Unknown license: > /home/yipan/workspace/samza_master/samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestClientHelper.scala > > > Please add the Apache license headers to those files.
Please run gradlew clean check as well. I saw the following checkstyle errors: :samza-core_2.10:checkstyleMain [ant:checkstyle] /home/yipan/workspace/samza_master/samza-core/src/main/java/org/apache/samza/container/SecurityManager.java:26: method def return type at indentation level 4 not at correct indentation, 2 [ant:checkstyle] /home/yipan/workspace/samza_master/samza-core/src/main/java/org/apache/samza/container/SecurityManager.java:28: method def return type at indentation level 4 not at correct indentation, 2 [ant:checkstyle] /home/yipan/workspace/samza_master/samza-core/src/main/java/org/apache/samza/container/SecurityManagerFactory.java:28: method def return type at indentation level 4 not at correct indentation, 2 - Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/#review134501 ----------------------------------------------------------- On May 8, 2016, 12:50 a.m., Chen Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37026/ > ----------------------------------------------------------- > > (Updated May 8, 2016, 12:50 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Basic support for kerberization based on keytab authentication. > > > Diffs > ----- > > build.gradle 16facbb > samza-core/src/main/java/org/apache/samza/container/SecurityManager.java > PRE-CREATION > > samza-core/src/main/java/org/apache/samza/container/SecurityManagerFactory.java > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 4d5ca4d > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > 5462208 > samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java c556d83 > samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala > 74a0676 > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala > 80deb3b > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterSecurityManager.scala > PRE-CREATION > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterService.scala > 3adf86f > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaContainerSecurityManager.scala > PRE-CREATION > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaYarnSecurityManagerFactory.scala > PRE-CREATION > samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJob.scala 62ddb26 > samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestClientHelper.scala > PRE-CREATION > > samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterService.scala > 7f5d9f4 > > Diff: https://reviews.apache.org/r/37026/diff/ > > > Testing > ------- > > > Thanks, > > Chen Song > >
