Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

2017-01-26 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review163234 --- This is looking pretty good. Thank you for the effort in writing t

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

2017-01-26 Thread Hai Lu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/ --- (Updated Jan. 27, 2017, 12:03 a.m.) Review request for samza. Bugs: SAMZA-102

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

2017-01-26 Thread Hai Lu
> On Jan. 26, 2017, 10:49 p.m., Jagadish Venkatraman wrote: > > docs/learn/documentation/versioned/hdfs/consumer.md, line 92 > > > > > > nit: Use capitalizations consistently > > > > 1. Is `id` of any signifi

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

2017-01-26 Thread Jagadish Venkatraman
> On Jan. 25, 2017, 10:36 p.m., Jagadish Venkatraman wrote: > > docs/learn/documentation/versioned/hdfs/consumer.md, line 97 > > > > > > Not clear to me how this differs from the whitelist (*.avro which > > specifies

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

2017-01-26 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review163177 --- docs/learn/documentation/versioned/hdfs/consumer.md (line 22)

[GitHub] samza pull request #46: Upgraded RocksDB version to 5.0.1 and added configur...

2017-01-26 Thread prateekm
GitHub user prateekm opened a pull request: https://github.com/apache/samza/pull/46 Upgraded RocksDB version to 5.0.1 and added configuration for managing RocksDB logging You can merge this pull request into a Git repository by running: $ git pull https://github.com/prateekm/

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

2017-01-26 Thread Hai Lu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/ --- (Updated Jan. 26, 2017, 6:47 p.m.) Review request for samza. Bugs: SAMZA-1025

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

2017-01-26 Thread Hai Lu
> On Jan. 25, 2017, 10:50 p.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/hdfs/consumer.md, line 26 > > > > > > Can you include the diagram from your design document? Or something > > similar to el

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

2017-01-26 Thread Hai Lu
> On Jan. 25, 2017, 10:36 p.m., Jagadish Venkatraman wrote: > > docs/learn/documentation/versioned/hdfs/consumer.md, line 67 > > > > > > The relationship between whitelist and blacklist was not very obvious > > to me