[jira] [Created] (PROTON-2813) [Python] Make the python code pep8 clean

2024-04-12 Thread Andrew Stitcher (Jira)
Andrew Stitcher created PROTON-2813: --- Summary: [Python] Make the python code pep8 clean Key: PROTON-2813 URL: https://issues.apache.org/jira/browse/PROTON-2813 Project: Qpid Proton Issue Ty

[jira] [Assigned] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-12 Thread Andrew Stitcher (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher reassigned PROTON-2322: --- Assignee: Andrew Stitcher > Fix and remove ignores in flake8 configuration > --

[jira] [Updated] (PROTON-2813) [Python] Make the python code pep8 clean

2024-04-12 Thread Andrew Stitcher (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher updated PROTON-2813: Description: It's better if we only accept code that conforms to the minimal coding stand

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836756#comment-17836756 ] ASF GitHub Bot commented on PROTON-2322: astitcher opened a new pull request, #4

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-12 Thread via GitHub
astitcher commented on PR #423: URL: https://github.com/apache/qpid-proton/pull/423#issuecomment-2052649323 I want to be sure this didn't break any build, and especially any version of python from 3.9 onwards. But assuming is doesn't then I'll commit it to main. -- This is an automated

[PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-12 Thread via GitHub
astitcher opened a new pull request, #423: URL: https://github.com/apache/qpid-proton/pull/423 This is a broad but shallow change, that changes a lot of files in fairly minor ways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836757#comment-17836757 ] ASF GitHub Bot commented on PROTON-2322: astitcher commented on PR #423: URL: ht

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-12 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563727314 ## python/proton/_events.py: ## @@ -57,7 +57,6 @@ def more(self) -> bool: return pn_collector_more(self._impl) def pop(self) -> None: -ev =

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836766#comment-17836766 ] ASF GitHub Bot commented on PROTON-2322: jiridanek commented on code in PR #423:

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-12 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563729161 ## python/proton/_handlers.py: ## @@ -1305,15 +1305,15 @@ def update(transport: Transport, selectable: Selectable, now: float) -> None: try:

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836767#comment-17836767 ] ASF GitHub Bot commented on PROTON-2322: jiridanek commented on code in PR #423:

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-12 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563730121 ## python/setup.cfg: ## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the li

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-12 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563730787 ## python/setup.cfg: ## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the li

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-12 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563731989 ## python/setup.cfg: ## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the li

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836769#comment-17836769 ] ASF GitHub Bot commented on PROTON-2322: jiridanek commented on code in PR #423:

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836768#comment-17836768 ] ASF GitHub Bot commented on PROTON-2322: jiridanek commented on code in PR #423:

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836770#comment-17836770 ] ASF GitHub Bot commented on PROTON-2322: jiridanek commented on code in PR #423: