jiridanek commented on code in PR #423:
URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563729161
##########
python/proton/_handlers.py:
##########
@@ -1305,15 +1305,15 @@ def update(transport: Transport, selectable:
Selectable, now: float) -> None:
try:
capacity = transport.capacity()
selectable.reading = capacity > 0
- except:
+ except ProtonException:
Review Comment:
Note to self, check this again. This exception change
thing is risky.
##########
python/proton/_handlers.py:
##########
@@ -1305,15 +1305,15 @@ def update(transport: Transport, selectable:
Selectable, now: float) -> None:
try:
capacity = transport.capacity()
selectable.reading = capacity > 0
- except:
+ except ProtonException:
if transport.closed:
selectable.terminate()
selectable._transport = None
transport._selectable = None
try:
pending = transport.pending()
selectable.writing = pending > 0
- except:
+ except ProtonException:
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
