[
https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836767#comment-17836767
]
ASF GitHub Bot commented on PROTON-2322:
----------------------------------------
jiridanek commented on code in PR #423:
URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563729161
##########
python/proton/_handlers.py:
##########
@@ -1305,15 +1305,15 @@ def update(transport: Transport, selectable:
Selectable, now: float) -> None:
try:
capacity = transport.capacity()
selectable.reading = capacity > 0
- except:
+ except ProtonException:
Review Comment:
Note to self, check this again. This exception change
thing is risky.
##########
python/proton/_handlers.py:
##########
@@ -1305,15 +1305,15 @@ def update(transport: Transport, selectable:
Selectable, now: float) -> None:
try:
capacity = transport.capacity()
selectable.reading = capacity > 0
- except:
+ except ProtonException:
if transport.closed:
selectable.terminate()
selectable._transport = None
transport._selectable = None
try:
pending = transport.pending()
selectable.writing = pending > 0
- except:
+ except ProtonException:
Review Comment:
Ditto
> Fix and remove ignores in flake8 configuration
> ----------------------------------------------
>
> Key: PROTON-2322
> URL: https://issues.apache.org/jira/browse/PROTON-2322
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
> Affects Versions: proton-c-0.34.0
> Reporter: Jiri Daněk
> Assignee: Andrew Stitcher
> Priority: Major
>
> Fixes with autopep8 in PROTON-2320 resolved most of flake8 warnings. There
> are still warnings left that require human consideration and fixing.
> For example, usage of bare {{except}} in the code.
> This must be fixed manually. Fixed issues should then be removed from the
> tox.ini flake8 ignore section.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
