[DISCUSSION] PIP-124: Create init subscription before sending message to DLQ

2021-12-20 Thread Zike Yang
r. In this case, we can ignore that exception and create the deadLetterProducer. Prototype implementation PR: https://github.com/apache/pulsar/pull/13355 Thanks, Zike Yang

Re: [DISCUSSION] PIP-124: Create init subscription before sending message to DLQ

2021-12-21 Thread Zike Yang
Thanks for your review Michael. On Tue, Dec 21, 2021 at 5:48 AM Michael Marshall wrote: > > Thanks for creating this PIP Zike Yang. This sounds like an important > improvement. I have a couple thoughts. > > 1. Does the `retryLetterTopic` have the same problem with immediate >

Re: [DISCUSSION] PIP-124: Create init subscription before sending message to DLQ

2021-12-22 Thread Zike Yang
iption` seems more reasonable. > Regarding default authorization, this new command would require the > same level of permission for the client since the act of creating a > consumer and the act of creating a subscription both require the same > `AuthAction` permission: Consume. +1 Thanks

Re: [DISCUSSION] Produce chunk messages failed when topic level maxMessageSize is set

2021-12-27 Thread Zike Yang
maxMessageSize > > > > > - [PulsarApi.proto] Add a new Command like > > > > > CommandUpdateClientPolicy{producerId, maxMessageSize} to update > > > > > ProducerBase#maxMessageSize when topic level maxMessageSize is > updated. > > > > > Further more, some other data consistency issues need be handled > very > > > > > carefully when maxMessageSize is updated. > > > > > This alternative is complex but can also solve other topic level > > > > > maxMessageSize issue [3] when batching is enabled (non-batching > case is > > > > > solved with PR [4]). > > > > > > > > > > Any suggestions or other use cases of topic level maxMessageSize > will > > > be > > > > > appreciated. > > > > > > > > > > Thanks, > > > > > Haiting Jiang > > > > > > > > > > [1] https://github.com/apache/pulsar/issues/13360 > > > > > [2] https://github.com/apache/pulsar/pull/8732 > > > > > [3] https://github.com/apache/pulsar/issues/12958 > > > > > [4] https://github.com/apache/pulsar/pull/13147 > > > > > > > > > -- Zike Yang

Re: [DISCUSSION] PIP-124: Create init subscription before sending message to DLQ

2021-12-28 Thread Zike Yang
cations that dynamically create topics. > > Oh, that's a very interesting point. I think it'd be easy to add that > as "internal" feature, though I'm a bit puzzled on how to add that to > the producer API -- Zike Yang

Re: [VOTE] PIP 131: Resolve produce chunk messages failed when topic level maxMessageSize is set

2021-12-28 Thread Zike Yang
topic level > > maxMessageSize issue [3] when batching is enabled (non-batching case is > > solved with PR [4]). > > > > [1] https://github.com/apache/pulsar/issues/13360 > > [2] https://github.com/apache/pulsar/pull/8732 > > [3] https://github.com/apache/pulsar/issues/12958 > > [4] https://github.com/apache/pulsar/pull/13147 > > > > Thanks, > > Haiting Jiang > > -- Zike Yang

Re: [DISCUSSION] PIP-132: Include message header size when check maxMessageSize of non-batch message on the client side.

2022-01-03 Thread Zike Yang
; is 1KB, it's ok to send message with 1KB properties and 1KB payload. But > > with this PIP, the > > sending will fail with InvalidMessageException. > > > > One conservative way is to add a boolean config "includeHeaderInSizeCheck" > > to enable this > > feature. But I think it's OK to enable this directly as it's more > > reasonable, and I don't see good > > migration plan if we add a config for this. > > > > The compatibility issue is worth discussing. And any suggestions are > > appreciated. > > > > [1] https://github.com/apache/pulsar/issues/13560 > > > > Thanks, > > Haiting Jiang > > -- Zike Yang

Re: [DISCUSSION] PIP-132: Include message header size when check maxMessageSize of non-batch message on the client side.

2022-01-05 Thread Zike Yang
ame. On Tue, Jan 4, 2022 at 11:51 AM Haiting Jiang wrote: > > Good point, I think we should shrink chunk size to > "ClientCnx.getMaxMessageSize() - chunkMessageHeaderSize", as we have the same > header size for each chunk message. > > Thanks, > Haiting Jiang &g

Re: [VOTE] PIP-121: Pulsar cluster level auto failover on client side

2022-01-11 Thread Zike Yang
gt; > > > protected ControlledConfiguration fetchControlledConfiguration() > > > > > > throws IOException { > > > > > > // call the service to get controlled configuration > > > > > > } > > > > > > > > > > > > @Override > > > > > > public String getServiceUrl() { > > > > > > return this.currentPulsarServiceUrl; > > > > > > } > > > > > > > > > > > > @Override > > > > > > public void close() { > > > > > > this.executor.shutdown(); > > > > > > } > > > > > > > > > > > > protected static class ControlledConfiguration { > > > > > > private String serviceUrl; > > > > > > private String tlsTrustCertsFilePath; > > > > > > > > > > > > private String authPluginClassName; > > > > > > private String authParamsString; > > > > > > > > > > > > } > > > > > > ``` > > > > > > The configuration we get from the third url provider, we define it > > > > > > as > > > > > > java Bean by json format. In the configuration, we provide > > > > > > authentication-related parameters to support different clusters that > > > > > > have different authentication configurations. These > > > > > > authentication-related parameters can support all current > > > > > > authentication plugin types. > > > > > > > > > > > > In order to create an `ControlledClusterFailover` instance, we use > > > > > > the > > > > > > `ControlledClusterFailoverBuilder` interface to build the target > > > > > > instance. The `ControlledClusterFailoverBuilder` interface is > > > > > > located > > > > > > in the `pulsar-client-api` package. > > > > > > > > > > > > ### API Changes > > > > > > For the current `ServiceUrlProvider` interface, we should add a > > > > > > `close` method to close an allocated resource, such as a timer > > > > > > thread. > > > > > > ```Java > > > > > > public interface ServiceUrlProvider { > > > > > > /** > > > > > > * Close the resource that the provider allocated. > > > > > > * > > > > > > */ > > > > > > default void close() { > > > > > > // do nothing > > > > > > } > > > > > > > > > > > > /** > > > > > > * Update the authentication this client is using. > > > > > > * > > > > > > * @param authentication > > > > > > * > > > > > > * @throws IOException > > > > > > */ > > > > > > void updateAuthentication(Authentication authentication) > > > > > > throws IOException; > > > > > > > > > > > > /** > > > > > > * Update the tlsTrustCertsFilePath this client is using. > > > > > > * > > > > > > * @param tlsTrustCertsFilePath > > > > > > */ > > > > > > void updateTlsTrustCertsFilePath(String tlsTrustCertsFilePath); > > > > > > > > > > > > /** > > > > > > * Update the tlsTrustStorePath and tlsTrustStorePassword this > > > > > > client is using. > > > > > > * > > > > > > * @param tlsTrustStorePath > > > > > > * @param tlsTrustStorePassword > > > > > > */ > > > > > > void updateTlsTrustStorePathAndPassword(String > > > > > > tlsTrustStorePath, > > > > > > String tlsTrustStorePassword); > > > > > > > > > > > > } > > > > > > ``` > > > > > > > > > > > > ### Tests > > > > > > Add tests for the two service provider implementations. > > > > > > > > > > > > For `AutoClusterFailover`, when the primary cluster shuts down, it > > > > > > should switch to the secondary cluster. And then the primary cluster > > > > > > came back, we should switch back. > > > > > > > > > > > > For `ControlledClusterFailover`, when switching the service url on > > > > > > the > > > > > > http service side, it should switch to the newest service url. > > > > > > > > > > > > ### Implementation > > > > > > Prototype implementation PR: > > > > https://github.com/apache/pulsar/pull/13316 > > > > > > > > > > > -- Zike Yang

Re: [VOTE] PIP-132: Include message header size when check maxMessageSize of non-batch message on the client side.

2022-01-11 Thread Zike Yang
payload. But with > this PIP, the > sending will fail with InvalidMessageException. > > One conservative way is to add a boolean config "includeHeaderInSizeCheck" to > enable this > feature. But I think it's OK to enable this directly as it's more reasonable, > and I don't see good > migration plan if we add a config for this. > > [1] https://github.com/apache/pulsar/issues/13560 > > Thanks, > Haiting Jiang -- Zike Yang

Re: [Discuss] Create new issues to SDKs in different languages

2022-01-12 Thread Zike Yang
to support this function in other languages, and then the > > corresponding issue is created in the corresponding SDK, so that it is > > convenient for the maintainers of other language SDKs to further evaluate > > the priority of this function, and it can also attract more contributors > > who are good at certain languages to claim the corresponding issue and > > contribute the corresponding function. > > > > -- > > Thanks > > Xiaolong Ran > > -- Zike Yang

Re: [DISCUSSION] PIP-124: Create init subscription before sending message to DLQ

2022-01-21 Thread Zike Yang
22 at 8:38 AM PengHui Li wrote: > > > > > > +1 for adding the DLQ_init_sub to producer metadata so that we don't > > > need to introduce a new field in CommandProducer, and the new field > > > looks a little confusing > > > > > > Th

Re: [DISCUSSION] PIP-124: Create init subscription before sending message to DLQ

2022-01-23 Thread Zike Yang
dn't know we were already doing this. > > Thanks, > Michael > > > On Fri, Jan 21, 2022 at 3:35 AM Zike Yang > wrote: > > > > +1 for adding init_subscription filed to the metadata of CommandProducer. > > > > > > > > On Thu, Jan 20, 2022 a

[VOTE] PIP-124: Create init subscription before sending message to DLQ

2022-01-25 Thread Zike Yang
he subscription before creating the retryLetterProducer, so we don't need to create the initial subscription for it. Prototype implementation PR: https://github.com/apache/pulsar/pull/13355 ---- Thanks Zike Yang

Re: [VOTE] PIP-124: Create init subscription before sending message to DLQ

2022-01-26 Thread Zike Yang
+1 (binding) > > > > > > Thanks, > > > Hang > > > > > > Jia Zhai 于2022年1月26日周三 10:17写道: > > > > > > > > +1 > > > > > > > > > > > > > > > > On Tue, Jan 25, 2022 at 8:2

Re: [VOTE] PIP-124: Create init subscription before sending message to DLQ

2022-01-26 Thread Zike Yang
gt; open for at least 17 more hours. > > There has been discussion on the dev list about changing this rule, > but I don't believe we have reached any conclusions yet. > > Thanks, > Michael > > On Wed, Jan 26, 2022 at 6:04 AM Zike Yang > wrote: > > > > T

Re: [VOTE] PIP-124: Create init subscription before sending message to DLQ

2022-01-27 Thread Zike Yang
Hi all, Since there are no objections on this PIP and this vote has been staying open for 48 hours. Close the vote with 3 (+1) bindings and 2 (+1) non-bindings. Thanks for your participation. Thanks, Zike On Thu, Jan 27, 2022 at 10:09 AM Zike Yang wrote: > > Hi Michael, > > Sor

Re: [DISCUSS] PIP-139 : Support Broker send command to real close producer/consumer.

2022-01-29 Thread Zike Yang
merId(); > > ConsumerImpl consumer = consumers.get(consumerId); > > if (consumer != null) { > > consumer.connectionClosed(this); > > } else { > > log.warn("Consumer with id {} not found while closing consumer > > ", consumerId); > > } > > } > > ``` > > **After** > > ```java > > @Override > > protected void handleCloseConsumer(CommandCloseConsumer closeConsumer) > > { > > log.info("[{}] Broker notification of Closed consumer: {}", > > remoteAddress, closeConsumer.getConsumerId()); > > final long consumerId = closeConsumer.getConsumerId(); > > ConsumerImpl consumer = consumers.get(consumerId); > > if (consumer != null) { > > if (closeConsumer.isAllowReconnect) { > > consumer.connectionClosed(this); > > } else { > > consumer.closeAsync(); > > } > > } else { > > log.warn("Consumer with id {} not found while closing consumer > > ", consumerId); > > } > > } > > ``` > > > > > > ## Reject Alternatives > > > > none. -- Zike Yang

[DISCUSS] The default value of maxPendingChunkedMessage

2022-01-30 Thread Zike Yang
/ConsumerConfigurationData.java#L112-L113 [2] https://github.com/apache/pulsar/blob/1e2ff8a3941b7cc6d583f528ceedc393b7e607fb/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java#L690 Thanks, Zike Yang

Re: [DISCUSS] The default value of maxPendingChunkedMessage

2022-01-30 Thread Zike Yang
buffers will use N*500 MB. It could reach 1GB if N > 2. > > In addition, normally, only if at least 100 producers sent messages to a > partition would it be meaningful to configure maxPendingChunkedMessages to > 100. > IMO, it's hard to see so many producers on a partition in

Re: [DISCUSS] The default value of maxPendingChunkedMessage

2022-02-07 Thread Zike Yang
Thanks, Zike Yang On Sat, Feb 5, 2022 at 6:41 PM Haiting Jiang wrote: > > > I agree with updating the Javadoc to align with the actual code. This > > will lead to fewer surprises, > > +1. > > For further improvement, I think we can deprecate `maxPendingChunkedMess

Re: [DISCUSSION][PIP-146] ManagedCursorInfo compression

2022-03-02 Thread Zike Yang
we handle the old data format in the ZK. Could you explain the compatibility for this PIP? Thanks, Zike Yang On Wed, Mar 2, 2022 at 3:34 PM Zixuan Liu wrote: > > Hi Pulsar Community, > > I create a proposal that ManagedCursorInfo compression. The proposal can be > found: https:

Re: [VOTE][PIP-146] ManagedCursorInfo compression

2022-03-13 Thread Zike Yang
+1 Thanks, Zike Yang On Mon, Mar 14, 2022 at 11:27 AM r...@apache.org wrote: > > +1 > > -- > Thanks > Xiaolong Ran > > Hang Chen 于2022年3月14日周一 09:55写道: > > > +1 > > > > Thanks, > > Hang > > > > Haiting Jiang 于2022年3月

Re: [VOTE][PIP-146] ManagedCursorInfo compression

2022-03-14 Thread Zike Yang
Hi Zixuan, This proposal has 3 (+1) bindings and 0 (-1) and has stayed open for at least 48 hours. You can close this vote now and the proposal has been accepted. Thanks, Zike Yang On Tue, Mar 15, 2022 at 10:50 AM Zixuan Liu wrote: > > Hi Pulsar community, > > Thank you for your v

Re: [DISCUSS] PIP-143 : Standardize Admin REST API

2022-03-23 Thread Zike Yang
+1 Thanks, Zike Yang On Tue, Mar 22, 2022 at 8:32 PM 石宝迪 wrote: > > +1 > > > > 在 2022年3月22日,19:59,Haiting Jiang 写道: > > > > +1 > > > > Thanks, > > Haiting > > > >> On 2022/03/16 12:43:45 guo jiwei wrote: > >> Hello comm

Re: [VOTE] PIP-149: Making the REST Admin API fully async

2022-03-29 Thread Zike Yang
+1, Zike Yang On 2022/03/29 09:22:16 guo jiwei wrote: > +1 > > Regards > Jiwei Guo (Tboy) > > > On Tue, Mar 29, 2022 at 4:16 PM Enrico Olivelli wrote: > > > +1 (binding) > > > > Enrico > > > > Il giorno mar 29 mar 2022 all

Re: [DISSCUSS] [PIP-150] Support read the message of startMessageId position on the broker side

2022-03-31 Thread Zike Yang
e breaking change here. It would be better if the compatibility part could be described more specifically. Thanks, Zike Yang On Mon, Mar 28, 2022 at 11:37 AM Zixuan Liu wrote: > > Thanks Enrico, > > Good suggestion. > > > do you mean that you want to start reading from the

Re: [ANNOUNCE] New Committer: Zike Yang

2022-04-17 Thread Zike Yang
Thank you all! Very glad to be the pulsar committer. Thanks, Zike Yang On Fri, Apr 15, 2022 at 10:53 AM Huanli Meng wrote: > > Good for you, Zike. Congratulations. > > BR//Huanli > > > On Apr 14, 2022, at 9:28 AM, Yu wrote: > > > > Congrats Zike! Well deserved

Re: [VOTE] [PIP-152] Support subscription level dispatch rate limiter setting.

2022-04-19 Thread Zike Yang
+1 Thanks, Zike On Wed, Apr 20, 2022 at 9:20 AM Dezhi Liu wrote: > > +1 > > Dezhi Liu

Re: [DISCUSS] PIP-155: Drop support for Python2

2022-04-20 Thread Zike Yang
+1 Thanks, Zike On Wed, Apr 20, 2022 at 5:22 PM Christophe Bornet wrote: > > +1 > > Le ven. 15 avr. 2022 à 18:06, Matteo Merli a écrit : > > > https://github.com/apache/pulsar/issues/15185 > > > > - > > > > ## Motivation > > > > Python 2.x has been deprecated for many years now and it w

Re: [VOTE] PIP-155: Drop support for Python2

2022-04-20 Thread Zike Yang
+1 (no-binding) Thanks, Zike On Thu, Apr 21, 2022 at 9:24 AM Dezhi Liu wrote: > > +1 > > Dezhi Liu

Re: [DISCUSSION] PIP-156: Enable system topic by default

2022-04-26 Thread Zike Yang
+1 Please update this PIP number. It's duplicated with https://github.com/apache/pulsar/issues/15207 Zike On Tue, Apr 26, 2022 at 8:09 PM Enrico Olivelli wrote: > > Which are the downsides of enabling system topics? > > Enrico > > Il Mar 26 Apr 2022, 14:07 guo jiwei ha scritto: > > > Hi commun

Re: [VOTE] [PIP-150] Support read the message of startMessageId position on the broker side

2022-04-27 Thread Zike Yang
+1 (non-binding) Thanks, Zike On Wed, Apr 27, 2022 at 10:44 AM Lin Lin wrote: > > +1 > > Lin Lin

Re: [ANNOUNCE] New Committer: Nicolò Boschi

2022-04-27 Thread Zike Yang
Congrats, Nicolò! Best, Zike On Wed, Apr 27, 2022 at 2:34 PM Enrico Olivelli wrote: > > Congratulations ! > > Enrico > > Il giorno mer 27 apr 2022 alle ore 05:40 Hang Chen > ha scritto: > > > > Congrats, Nicolò! > > > > Best, > > Hang > > > > ZhangJian He 于2022年4月27日周三 11:35写道: > > > > > > Con

Re: Call for projects and mentors for OSPP 2022

2022-04-29 Thread Zike Yang
Level: - [ ] Basic - [x] Advanced Project Validation Items: Item 1: Write a proposal to describe your design Item 2: Implement the message chunking feature at the go client and push the PR out Item 3: Add unit tests to verify it Item 4: Add the documentation for this feature … Project Mentor: Zike Yang Your

Re: Call for projects and mentors for OSPP 2022

2022-04-29 Thread Zike Yang
...@apache.org Your Apache ID: zike On Sat, Apr 30, 2022 at 9:51 AM Yu wrote: > > Hi Zike, looks like your email and Apache ID are missing? > > On Fri, Apr 29, 2022 at 10:17 PM Zike Yang wrote: > > > Thanks all, here is my application: > > > > Project Name: Support proce

Re: [ANNOUNCE] New Committer: Dezhi Liu

2022-06-07 Thread Zike Yang
Congratulations! Best Regards, Zike Yang On Tue, Jun 7, 2022 at 3:52 PM ZhangJian He wrote: > Congratulations! > > Thanks > ZhangJian He > > Haiting Jiang 于2022年6月7日周二 15:46写道: > > > Congrats! > > > > BR, > > Haiting > > > > On 2022/06/

Re: [VOTE] PIP-165: Auto release client useless connections

2022-06-14 Thread Zike Yang
+1 Zike Yang On Wed, Jun 15, 2022 at 10:28 AM Haiting Jiang wrote: > +1 > > Haiting > > On 2022/06/14 10:28:22 Xiangying Meng wrote: > > +1 > > > > On Tue, Jun 14, 2022 at 3:52 PM Gavin Gao > wrote: > > > > > +1 > > > > > &

Re: [DISCUSS] [PIP-179] Support the admin API to check unknown request parameters

2022-06-26 Thread Zike Yang
+1 Zike Yang On Wed, Jun 22, 2022 at 11:26 AM PengHui Li wrote: > +1 > > Penghui > > On Wed, Jun 22, 2022 at 10:53 AM Yubiao Feng > wrote: > > > Hi, Pulsar community: > > > > I open a pip to discuss "Support the admin API to check unknown request

Re: [VOTE] [PIP-179] Support the admin API to check unknown request parameters

2022-06-29 Thread Zike Yang
+1 Zike Yang On Thu, Jun 30, 2022 at 12:38 PM mattison chao wrote: > +1(non-binding) > > Best, > Mattison > > On Thu, 30 Jun 2022 at 12:35, Michael Marshall > wrote: > > > +1 > > > > - Michael > > > > On Wed, Jun 29, 2022 at 9:29 PM Qia

Re: [ANNOUNCE] New Committer: Zixuan Liu

2022-07-08 Thread Zike Yang
Congratulations! Zixuan Zike Yang On Fri, Jul 8, 2022 at 10:47 PM PengHui Li wrote: > Congratulations! Zixuan > > Penghui > > On Fri, Jul 8, 2022 at 9:56 PM Qiang Huang > wrote: > > > Congratulations!!! Zixuan. > > > > Max Xu 于2022年7月8日周五 21:

Re: [DISCUSS] PIP-184: Topic specific consumer priorityLevel

2022-07-11 Thread Zike Yang
/org/apache/pulsar/client/impl/conf/ConsumerConfigurationData.java#L58 Zike Yang Zike Yang On Sat, Jul 9, 2022 at 12:10 AM Dave Maughan wrote: > > Hi Enrico, > > Why can't you create multiple independent Consumers ? > > They will share the same resources (memory pools,

Re: CI - remove cmd line test retries?

2022-07-12 Thread Zike Yang
> for a > > > > > > given pull but they actually hide test failures (that may be flakies > > > or > > > > > > real issues!!). > > > > > > > > > > > > Another issue is that you can't easily see the failed test and most > > > of the > > > > > > time the quickest solution is just to blindly restart the failed > > > jobs. This > > > > > > is not the correct behaviour and it will make the CI less stable > > > over time. > > > > > > > > > > > > The plan would be: > > > > > > - Remove the retries (see > > > https://github.com/apache/pulsar/pull/16524) > > > > > > - Create issue for flaky tests > > > > > > - Fix them / move to quarantine > > > > > > > > > > > > WDYT? > > > > > > > > > > > > Thanks, > > > > > > Nicolò Boschi > > > > > > > > > -- Zike Yang

Re: [VOTE] Enable GitHub Discussion for user-facing discussion

2022-07-13 Thread Zike Yang
+1 On Wed, Jul 13, 2022 at 3:21 PM tison wrote: > > Thanks for your feedback. To be clear, I'll conclude the result after 72 > hours from the first email sent if there's no objections. > > Best, > tison. > > > Qiang Huang 于2022年7月13日周三 14:10写道: > > > +1 > > > > guo jiwei 于2022年7月13日周三 10:11写道:

Re: [VOTE] PIP-184: Topic specific consumer priorityLevel

2022-07-17 Thread Zike Yang
+1 Thanks On Fri, Jul 15, 2022 at 3:58 PM Dave Maughan wrote: > > Hi Pulsar Community > > I would like to start a VOTE on "PIP-184: Topic specific consumer > priorityLevel". > > The proposal can be read at https://github.com/apache/pulsar/issues/16481 > > and the discussion thread is available

Re: [DISCUSS] PIP 194 : Pulsar client: seek command add epoch

2022-07-26 Thread Zike Yang
t looks like there is not much described above. What kind of status needs to be checked, and what kind of behavior will the broker take? > > 1. Consumer reconnect need reset epoch. Why do we need to reset the epoch when the consumer reconnects? Thanks! Zike Yang On Tue, Jul 26, 2022 at

Re: [VOTE]PIP-189: No batching if only one message in batch.

2022-07-26 Thread Zike Yang
eature > ProducerBuilder batchingSingleMessage(boolean batchingSingleMessage); // > default value is true Zike Yang On Tue, Jul 26, 2022 at 6:05 PM Qiang Huang wrote: > > +1(non-binding) > > BR, > Qiang Huang > > mattison chao 于2022年7月25日周一 13:17写道: > > >

Re: [VOTE]PIP-189: No batching if only one message in batch.

2022-07-26 Thread Zike Yang
+1 (non-binding) Great work! Thanks Zike Yang On Tue, Jul 26, 2022 at 7:31 PM Enrico Olivelli wrote: > > +1 (binding) > > This is a small improvement but a great impact !! > > Enrico > > Il giorno mar 26 lug 2022 alle ore 12:48 Anon Hxy > ha scritto: > > &g

Re: [DISCUSS] Restart Release Pulsar 2.7.5

2022-07-26 Thread Zike Yang
+1 Thanks Zike Yang On Tue, Jul 26, 2022 at 7:46 PM Hang Chen wrote: > > +1 > > Thanks, > Hang > > Enrico Olivelli 于2022年7月26日周二 19:21写道: > > > > +1 > > > > thank you > > > > Enrico > > > > Il giorno mar 26 lug 2022 a

Re: [ANNOUNCE] Micheal Marshall as a new PMC member in Pulsar

2022-07-26 Thread Zike Yang
Congratulations, Michael! BR Zike Yang On Wed, Jul 27, 2022 at 10:04 AM guo jiwei wrote: > > Congrats Michael! > > > Regards > Jiwei Guo (Tboy) > > > On Wed, Jul 27, 2022 at 9:56 AM Haiting Jiang > wrote: > > > Congratulations, Michael! > > >

Re: [VOTE] PIP-190: Simplify Pulsar documentation release and maintenance strategy

2022-07-28 Thread Zike Yang
+1 (non-binding) This will greatly reduce the amount of work that contributors have to do to update and maintain the documentation. Thanks Zike Yang On Thu, Jul 28, 2022 at 4:04 PM Max Xu wrote: > > +1 > > > Best, > > Max Xu > > > On Thu, Jul 28, 2022 at 9:35 A

Re: [DISCUSS] PIP 194 : Pulsar client: seek command add epoch

2022-07-28 Thread Zike Yang
er to add this explanation to the PIP. > The reconnected consumer can regard as a new consumer with new epoch. The consumer will reconnect to the broker during the seek operation. And this will change the existing behavior. It doesn't seem to make sense. Please correct me if I have misundersto

Re: [Vote] PIP 198: Standardize PR Naming Convention using GitHub Actions

2022-08-07 Thread Zike Yang
+1 (non-binding) Thanks Zike Yang On Mon, Aug 8, 2022 at 1:06 PM Xiangying Meng wrote: > > +1(non-binding) > > yours sincerely, > xiangying Meng > > On Thu, Aug 4, 2022 at 4:13 PM Yu wrote: > > > Hi team, > > > > It has been 4 months since we

[DISCUSS] Skip unnecessary tests when there are only cpp/python related changes

2022-08-10 Thread Zike Yang
. Thanks! [0] https://github.com/apache/pulsar/pull/16988 [1] https://github.com/RobertIndie/pulsar-ci-test/pull/1 [2] https://github.com/RobertIndie/pulsar-ci-test/actions/runs/2829525510 [3] https://github.com/apache/pulsar/blob/master/.github/workflows/pulsar-ci.yaml#L380 Best, Zike Yang

Re: [Discussion] PIP 198 - How to define [type] and [scope]?

2022-08-17 Thread Zike Yang
LGTM. > - Cherry pick changes [4] > Choice A: [fix][broker][branch-2.9] xxx > Choice B: [fix][broker] xxx. And add "cherry pick xxx to branch-2.9" in the > PR description. I prefer A. Thanks, Zike Yang Zike Yang On Wed, Aug 17, 2022 at 7:41 PM Qiang Huang wrote: &g

[DISCUSS] Use Github project to track the multi clients development

2022-08-21 Thread Zike Yang
ts project. Please let me know what you think. Thanks! [0] https://github.com/apache/pulsar/projects/12 [1] https://github.com/apache/pulsar/pull/17201 Best, Zike Yang

Re: [DISCUSS] Enable message deduplication for replicator by default

2022-08-22 Thread Zike Yang
+1 Thanks, Zike Yang On Mon, Aug 22, 2022 at 3:16 PM mattison chao wrote: > > +1 > > Best, > Mattison > > On Fri, 19 Aug 2022 at 01:40, Enrico Olivelli wrote: > > > I agree > > > > Enrico > > > > Il Gio 18 Ago 2022, 18:23 PengHui Li ha

Re: [DISCUSS] Use Github project to track the multi clients development

2022-08-25 Thread Zike Yang
ill be a lot of features that we need to develop. If there is no objection, please help review and merge this PR: https://github.com/apache/pulsar/pull/17201 Thanks. Best, Zike Yang On Wed, Aug 24, 2022 at 9:20 PM Enrico Olivelli wrote: > > I think that the main problem is that in our com

Re: [DISCUSS] Use Github project to track the multi clients development

2022-08-28 Thread Zike Yang
Thanks for your information. I will mark this PR as a draft until the improvement of `add-to-project` is done. Zike Yang On Mon, Aug 29, 2022 at 9:36 AM PengHui Li wrote: > > More context can be found here > https://lists.apache.org/thread/q49r2blh1wmvnr0mqx2lxxkhd8c306bm > > Th

[DISCUSS] Return the message ID of the first chunk when sending chunked messages

2021-09-21 Thread Zike Yang
could return the message ID of the first chunk when sending chunked messages. I would like to know if this solution will bring other problems. Any ideas on this? Thanks -- Zike Yang

Re: [DISCUSS] Return the message ID of the first chunk when sending chunked messages

2021-09-22 Thread Zike Yang
en the consumer should be able to receive and consume the next complete > chunk and deliver it to the application. This behavior should not require > any server side change but should expect the client to consume the next > correct chunked message after the given messageId. > > Thanks,

RE: [DISCUSS] Return the message ID of the first chunk when sending chunked messages

2021-09-26 Thread Zike Yang
I submitted a PR to demonstrate the solution:https://github.com/apache/pulsar/pull/12171 <https://github.com/apache/pulsar/pull/12171>. If you have any suggestions, please feel free to comment on it. Thanks, Zike Yang On 2021/09/22 03:55:44 Zike Yang wrote: > Hi Pulsar

[VOTE] PIP 107: Introduce the chunk message ID

2021-10-31 Thread Zike Yang
Hi Pulsar Community, I would like to start a VOTE for PIP 107: Introduce the chunk message ID. The issue for this PIP is here: https://github.com/apache/pulsar/issues/12402 Please VOTE within 72 hours. Thanks, Zike Yang

Re: [DISCUSS]PIP-295: Fixing Chunk Message Duplication Issue

2023-08-22 Thread Zike Yang
n for the last chunk of the large message. The consumer only gets the whole message after receiving the last chunk. We don't need to check the deduplication for all previous chunks. Also by doing this we only need bug fixes, we don't need to introduce a new PIP. BR, Zike Yang On Fri,

Re: [DISCUSS]PIP-295: Fixing Chunk Message Duplication Issue

2023-08-23 Thread Zike Yang
ssages will still be persisted. The consumer already handles this case. The above 5 messages will all be persisted but the consumer will skip message 1 and 2. For messages 3, 4, and 5. The producer can guarantee these chunks are in order. BR, Zike Yang On Thu, Aug 24, 2023 at 11:48 AM Yubiao Feng

Re: [DISCUSS]PIP-295: Fixing Chunk Message Duplication Issue

2023-08-24 Thread Zike Yang
behavior and introduce more complexity to this configuration. [0] https://github.com/apache/pulsar/pull/14007 BR, Zike Yang On Thu, Aug 24, 2023 at 2:21 PM Zike Yang wrote: > > Hi, xiangying > > > it will find that the message > is out of order and rewind the cursor. Loop this operation,

Re: [DISCUSS] PIP-293: Add configuration for batching/chunking for retry letter and dead letter producers

2023-08-24 Thread Zike Yang
ng to enable chunking and disable batching for retry and DLQ producers. PTAL. Thanks. BR, Zike Yang On Sat, Aug 19, 2023 at 5:28 AM Rin Davis wrote: > > Hi Pulsar Community, This is the discussion thread for PIP > https://github.com/apache/pulsar/pull/20959 > This PIP will allow user

Re: [DISCUSS]PIP-295: Fixing Chunk Message Duplication Issue

2023-08-25 Thread Zike Yang
e reproduced. BR, Zike Yang On Thu, Aug 24, 2023 at 8:48 PM Xiangying Meng wrote: > > >IIUC, this may change the existing behavior and may introduce > >inconsistencies. > >Suppose that we have a large message with 3 chunks. But the producer > >crashes and resends th

Re: [VOTE] PIP 296: Introduce the `getLastMessageIds` API to Reader

2023-08-25 Thread Zike Yang
+1 (non-binding) Thanks, Zike Yang On Fri, Aug 25, 2023 at 2:52 PM Xiangying Meng wrote: > > Hi Pulsar Community, > > This is the vote thread for PIP 296: > https://github.com/apache/pulsar/pull/21052 > > This PIP will help to improve the flexibility of Reader usage. > > Thanks, > Xiangying

Re: [DISCUSS]PIP-295: Fixing Chunk Message Duplication Issue

2023-08-26 Thread Zike Yang
is we only need bug fixes, we don't need to introduce a new PIP. Could you explain or show a case in what cases would lead to this simpler solution not working? Thanks, Zike Yang On Sat, Aug 26, 2023 at 1:38 PM Heesung Sohn wrote: > > > In this case, the consumer only can receive m1

Re: [DISCUSS]PIP-295: Fixing Chunk Message Duplication Issue

2023-08-26 Thread Zike Yang
mer should assemble the message using 3,4,5. Thanks for pointing this out. BR, Zike Yang On Sat, Aug 26, 2023 at 3:58 PM Xiangying Meng wrote: > > >> Consumer receive: > >1. SequenceID: 0, ChunkID: 0 > >2. SequenceID: 0, ChunkID: 1 > >3. SequenceID: 0, ChunkID: 0

Re: [DISCUSS] Release DotPulsar 3.0.0

2023-08-27 Thread Zike Yang
+1 I am looking forward to this new release. Thanks, Zike Yang On Mon, Aug 28, 2023 at 9:15 AM PengHui Li wrote: > > +1 > > Thanks for driving the release. > > Penghui > > On Fri, Aug 25, 2023 at 9:48 PM David Jensen wrote: > > > Dear Apache PMC and

[DISCUSS] PIP-297: Support raising exceptions using Function & Connector context

2023-08-28 Thread Zike Yang
Hi, all I opened a new PIP: https://github.com/apache/pulsar/pull/21079 This PIP is to improve the current function exception handler. It will be applied to both Pulsar Function and Pulsar IO Connector. Please feel free to give your feedback. Thanks! BR, Zike Yang

Re: [DISCUSS] PIP-297: Support raising exceptions using Function & Connector context

2023-08-29 Thread Zike Yang
Hi, Enrico Thanks for your review. I have replied under the PR. BR, Zike Yang On Mon, Aug 28, 2023 at 6:39 PM Enrico Olivelli wrote: > > Zike, > > Il giorno lun 28 ago 2023 alle ore 11:53 Zike Yang ha > scritto: > > > > Hi, all > > > > I opened a ne

[VOTE] PIP-297: Support terminating Function & Connector with the fatal exception

2023-09-04 Thread Zike Yang
Hi, all Since there are no other concerns in the discussion, I'm delighted to start the voting process for the PIP-297. Here is the link to the PIP: https://github.com/apache/pulsar/pull/21079 BR, Zike Yang

Re: [VOTE] Pulsar DotPulsar Release 3.0.0 Candidate 1

2023-09-05 Thread Zike Yang
+1 (non-binding) - Verified signature and checksums - Install the nupkg file - Build the client from the source - Run examples But I find that the dotpulsar 3.0.0 has already been published to the nuget.org: https://www.nuget.org/packages/DotPulsar/3.0.0 BR, Zike Yang On Sun, Sep 3, 2023 at 11

Re: [VOTE] PIP-297: Support terminating Function & Connector with the fatal exception

2023-09-06 Thread Zike Yang
Thank you all. Close this vote by 3 binding +1s: - Enrico - Penghui Li - Mattison And 1 non-binding +1: Baodi Shi Thanks, ZIke Yang On Tue, Sep 5, 2023 at 9:25 AM wrote: > > +1 (binding) > > Best, > Mattison > On 5 Sep 2023 at 09:07 +0800, PengHui Li , wrote: > > +1

Re: [VOTE] PIP-277: Add `current` option in the Clusters list cmd

2023-09-06 Thread Zike Yang
+1 (non-binding) BR, Zike Yang On Wed, Sep 6, 2023 at 11:47 PM tison wrote: > > +1 (binding) > > Trivial with low risk. > > Best, > tison. > > > mattison chao 于2023年9月6日周三 22:50写道: > > > +1 (binding) > > > > Best, > > Mattison >

[VOTE] Pulsar Client Go Release 0.11.1 Candidate 1

2023-09-11 Thread Zike Yang
Hi everyone, Please review and vote on the release candidate #1 for the version 0.11.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) This is the first release candidate for Apache Pulsar Go client, version 0.11.1. It fixes the follo

Re: [DISCUSS] PIP-286: Add findNewestPosition method in the TopicCompactionService API

2023-09-11 Thread Zike Yang
+1 for me. Thanks, Zike Yang On Mon, Sep 11, 2023 at 11:13 AM Cong Zhao wrote: > > Hi, guys > > I noticed that the only globally ordered fields in the metadata are > 'publishTime' and 'entryIndex' (offset), so I split the previous method i

Re: [VOTE] Pulsar DotPulsar Release 3.0.0 Candidate 1

2023-09-12 Thread Zike Yang
ke the release validation easier. Thanks, Zike Yang On Tue, Sep 12, 2023 at 9:30 PM tison wrote: > > Thanks for your participants! > > The release is moved to > https://dist.apache.org/repos/dist/release/pulsar/pulsar-dotpulsar-3.0.0. > > Here are several follow-ups for the

Re: [VOTE] PIP-286: Make the TopicCompactionService to support find entry based on publishTime or index

2023-09-17 Thread Zike Yang
+1 (non-binding) BR, Zike Yang On Mon, Sep 18, 2023 at 9:35 AM mattison chao wrote: > > +1 (binding) > > Best, > Mattison > On 18 Sep 2023 at 09:19 +0800, PengHui Li , wrote: > > +1 (binding) > > > > Thanks, > > Penghui > > > > On Thu, S

Re: [DISCUSS] Release Pulsar 3.0.2

2023-09-24 Thread Zike Yang
+1 BR, Zike Yang On Sun, Sep 24, 2023 at 11:58 PM Dave Fisher wrote: > > Please use the correct name of the project - Apache Pulsar. > > Thanks, > Dave > > Sent from my iPhone > > > On Sep 24, 2023, at 7:08 AM, Yubiao Feng > > wrote: > > > > 

Re: [VOTE] PIP-302 Add new API readAllExistingMessages for TableView

2023-09-25 Thread Zike Yang
-45c655583d6c0c73d87afd3df3fe67f77caadbf1bd691cf8f8211cc89728a1ceR34-R36 And the PR title doesn't seem relevant. “PIP-302 Add alwaysRefresh Configuration Option for TableView to Read Latest Values” BR, Zike Yang On Mon, Sep 25, 2023 at 3:25 PM Xiangying Meng wrote: > > Hi dev, >This thread is to start a vote for PIP-3

Re: [DISCUSS] Release Pulsar 3.1.1

2023-09-25 Thread Zike Yang
+1 Zike Yang On Mon, Sep 25, 2023 at 2:55 PM Enrico Olivelli wrote: > > +1 > > Enrico > > Il giorno lun 25 set 2023 alle ore 05:08 Yubiao Feng > ha scritto: > > > > +1 > > > > Thanks > > Yubiao Feng > > > > On Mon, Sep 18, 2023 at

Re: [DISCUSS] Unload Rate Limiting during Graceful Shutdown of Pulsar

2023-09-25 Thread Zike Yang
And I agree that we need a new PIP for this change. BR, Zike Yang On Mon, Sep 25, 2023 at 3:54 PM Xiangying Meng wrote: > > Hi Donglai, Heesung > > >brokerShutdownMaxNumberOfGracefulBundleUnloadPerMinute=60 is the same as > brokerShutdownMaxNumberOfGracefulBundleUnloadPerSec=1 So,

Re: [DISCUSS] PIP-300: Add custom dynamic configuration for plugins

2023-09-25 Thread Zike Yang
building the pulsar for your own to meet this need? Does it make sense to you? BR, Zike Yang On Mon, Sep 25, 2023 at 12:23 AM mattison chao wrote: > > Hi, Zixuan > > I am afraid I can't support you in cherry-picking this feature for all of the > active branches by the cu

Re: [VOTE] PIP-302 Introduce refreshAsync API for TableView

2023-09-27 Thread Zike Yang
+1 BR, Zike Yang On Wed, Sep 27, 2023 at 3:05 PM Xiangying Meng wrote: > > Hi dev, >This thread is to start a vote for PIP-302 Add new API > refreshAsync for TableView. > Discuss thread: > https://lists.apache.org/thread/o085y2314o0fymvx0x8pojmgjwcwn59q > PIP: http

Re: [Discuss] Release Pulsar C++ Client 3.4.0

2023-10-22 Thread Zike Yang
+1, BR, Zike Yang On Mon, Oct 23, 2023 at 1:10 PM PengHui Li wrote: > > Thanks for driving the release, > > +1 > > Penghui > > On Mon, Oct 23, 2023 at 11:00 AM Yunze Xu wrote: > > > I would like to propose releasing the Pulsar C++ Client 3.4.0. It has >

Re: [DISCUSS] Auto release Nuget artifacts for DotPulsar

2023-10-30 Thread Zike Yang
Hi, David Thanks for initializing this discussion. I'm +1 for making the auto-release process for the DotPulsar. I have left some comments in the PR. Thanks, Zike Yang On Thu, Oct 26, 2023 at 5:39 PM David Jensen wrote: > > Hi everyone, > I have worked with Tison to make the r

Re: Question about Pulsar gRPC client(s)

2023-10-31 Thread Zike Yang
Another point is that there are many features implemented on the client side, including batching, chunking, DLQ, etc. This makes it hard to replace the existing pulsar clients completely. Zike Yang On Wed, Nov 1, 2023 at 4:43 AM Christophe Bornet wrote: > > Hi Kiryl, > > Thanks fo

Re: [VOTE] Pulsar Client Go Release 0.11.1 Candidate 1

2023-11-07 Thread Zike Yang
> The KEYS file link is dead, I think it should be https://downloads.apache.org/pulsar/KEYS Thanks for your reminder. Yes, that should be the correct link. I have also pushed a PR to fix the release process: https://github.com/apache/pulsar-client-go/pull/1127 PTAL. Thanks! BR, Zike Yang On

Re: [VOTE] Pulsar Client Go Release 0.11.1 Candidate 1

2023-11-07 Thread Zike Yang
Close this vote by 3 binding +1: - Yunze - Penghui - Mattison BR, Zike Yang On Tue, Nov 7, 2023 at 4:43 PM Zike Yang wrote: > > > The KEYS file link is dead, I think it should be > https://downloads.apache.org/pulsar/KEYS > > Thanks for your reminder. Yes, that should be t

[ANNOUNCE] Apache Pulsar Go Client 0.11.1 released

2023-11-07 Thread Zike Yang
The Apache Pulsar team is proud to announce Apache Pulsar Go Client version 0.11.1. Pulsar is a highly scalable, low latency messaging platform running on commodity hardware. It provides simple pub-sub semantics over topics, guaranteed at-least-once delivery of messages, automatic cursor managemen

Re: [ANNOUNCE] Yubiao Feng as new PMC member in Apache Pulsar

2023-11-13 Thread Zike Yang
Congratulations! BR, Zike Yang On Tue, Nov 14, 2023 at 3:34 AM Heesung Sohn wrote: > > Congrats! > Heesung > > On Mon, Nov 13, 2023 at 6:57 AM Yubiao Feng > wrote: > > > Thank you all > > > > Yubiao Feng > > > > > > > > On Mon, N

Re: [VOTE] PIP-312 Use StateStoreProvider to manage state in Pulsar Functions endpoints

2023-11-15 Thread Zike Yang
+1(no-binding) Thanks, Zike Yang On Wed, Nov 15, 2023 at 4:01 PM Baodi Shi wrote: > > +1(non-binding) > > > Thanks, > Baodi Shi > > > On Nov 15, 2023 at 11:49:24, Neng Lu wrote: > > > +1 > > > > On 2023/11/15 03:39:42 Pengcheng Jiang wrote: >

Re: [Discuss] Release Pulsar C++ Client 3.4.1

2023-11-16 Thread Zike Yang
+1 Thanks for your fixes. BR, Zike Yang On Thu, Nov 16, 2023 at 5:48 PM Yunze Xu wrote: > > There is another critical issue introduced by 3.4.0: > https://github.com/apache/pulsar-client-python/issues/162 > > I will open another fix for it. > > Thanks, > Yunze > &

Re: [VOTE] Pulsar Release 3.0.2 Candidate 4

2023-11-20 Thread Zike Yang
) has been blocked for some time. We need to move this PR forward. BR, Zike Yang On Mon, Nov 20, 2023 at 5:07 PM Yubiao Feng wrote: > > Sorry, the SHA-512 checksums are wrong by mistake. Correct it below: > > apache-pulsar-3.0.

Re: Pulsar 3.0.2 docker image only supports arm64 platform

2023-12-03 Thread Zike Yang
We need to use the following commands to push the images: ```sh regctl image copy 9947090/pulsar:3.0.2-12c92fe apachepulsar/pulsar:3.0.2 regctl image copy 9947090/pulsar-all:3.0.2-12c92fe apachepulsar/pulsar-all:3.0.2 ``` It's missing in the release doc. I will update it later. Thanks, Zike

[DISCUSS] Release Pulsar Python clieng 3.4.0

2023-12-03 Thread Zike Yang
the C++ client for the Python client to 3.4.1: https://github.com/apache/pulsar-client-python/pull/167 We need to cut a new release. Please let me know if you have any important fixes that need to be included in Pulsar Python client 3.4.0. Thanks, Zike Yang

  1   2   3   4   >