+1 (non-binding) Great work! Thanks Zike Yang
On Tue, Jul 26, 2022 at 7:31 PM Enrico Olivelli <eolive...@gmail.com> wrote: > > +1 (binding) > > This is a small improvement but a great impact !! > > Enrico > > Il giorno mar 26 lug 2022 alle ore 12:48 Anon Hxy > <anonhx...@gmail.com> ha scritto: > > > > Hi Zike > > > > Thanks for your reminding. I just forgot to update the issue and have > > updated it now. I am not going to add the configuration > > `batchingSingleMessage ` to the producer. > > > > Thanks, > > Xiaoyu Hou > > > > Zike Yang <z...@apache.org> 于2022年7月26日周二 18:16写道： > > > > > Hi, Anon > > > > > > So are you going to add the configuration `batchingSingleMessage ` to > > > the producer? I saw that it was still in the PIP: > > > > > > > So this may cause ((BatchMessageIdImpl) messageId) throw > > > ClassCastException. we need to add a switch for the producer to enable or > > > disable this feature > > > > ProducerBuilder<T> batchingSingleMessage(boolean > > > batchingSingleMessage); // default value is true > > > > > > > > > > > > > > > Zike Yang > > > > > > On Tue, Jul 26, 2022 at 6:05 PM Qiang Huang <qiang.huang1...@gmail.com> > > > wrote: > > > > > > > > +1(non-binding) > > > > > > > > BR, > > > > Qiang Huang > > > > > > > > mattison chao <mattisonc...@apache.org> 于2022年7月25日周一 13:17写道： > > > > > > > > > +1(non-binding) > > > > > > > > > > Best, > > > > > Mattison > > > > > > > > > > On Mon, 25 Jul 2022 at 10:35, Haiting Jiang <jianghait...@apache.org> > > > > > wrote: > > > > > > > > > > > > +1 > > > > > > Thanks, > > > > > > Haiting > > > > > > > > > > > > On 2022/07/25 02:23:20 Anon Hxy wrote: > > > > > > > Dear Community, > > > > > > > > > > > > > > I would like to start a VOTE on "PIP-189: No batching if only one > > > > > message > > > > > > > in batch." > > > > > > > > > > > > > > The proposal can be read at [0] and the discussion thread is > > > available > > > > > at > > > > > > > [1] and the PR link is available at [2] > > > > > > > > > > > > > > Voting will stay open for at least 48h. > > > > > > > > > > > > > > [0] https://github.com/apache/pulsar/issues/16619 > > > > > > > [1] > > > https://lists.apache.org/thread/dbq1lrv03bhtk0lr5nwm5txo9ndjplv0 > > > > > > > [2] https://github.com/apache/pulsar/pull/16605 > > > > > > > > > > > > > > Thanks, > > > > > > > Xiaoyu > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > BR, > > > > Qiang Huang > > >
