Re: [VOTE] Pulsar Release 2.11.0 Candidate-5

2023-01-03 Thread PengHui Li
> I found there are both apache-pulsar-shell-2.11.0-bin.tar.gz and apache-pulsar-shell-2.11.0-bin.zip, are they duplicates? I noticed here is the discussion about this part in Slack https://apache-pulsar.slack.com/archives/C5ZSVEN4E/p1672411025574369 Penghui On Wed, Jan 4, 2023 at 2:35 PM Yunze

Re: [VOTE] Pulsar Release 2.11.0 Candidate-5

2023-01-04 Thread PengHui Li
ithub.com/apache/pulsar/pull/17243#discussion_r1061199501. > Not sure if it's a blocker so I didn't give +1 or -1 until someone > could explain it. > > Thanks, > Yunze > > On Wed, Jan 4, 2023 at 2:37 PM PengHui Li wrote: > > > > > I found there are bot

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-08 Thread PengHui Li
Sorry for the late reply. We can leverage the `ProtocolVersion` [1] to handle the compatibility issue. It looks like only if the protocol_version >= 21, subscribe with the auto_consume schema IMO, both the new key-value of the subscribe command, and a specific representative are API changes. It's

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-15 Thread PengHui Li
Rather than which ones need to be set and which ones do not need to be set. Thanks, Penghui On Mon, Jan 9, 2023 at 11:32 AM SiNan Liu wrote: > This design also has serious compatibility problems between old and new > pulsar clients and new and old brokers. > > > Thanks, > Sinan >

Re: [DISCUSS] KeyShared routing additions/configuration

2023-01-15 Thread PengHui Li
Hi Tim, > The proposal is two-fold: first, we would like to implement a new KeyShared routing mechanism which tracks outstanding messages and their consumers, routing messages with outstanding keys to the current consumer handling that key, and any messages with new keys to any arbitrary consumer

Re: [DISCUSS] Add unified newTableView method in PulsarClient

2023-01-15 Thread PengHui Li
+1 And It might be a typo when adding the table view APIs >From the example: https://github.com/apache/pulsar/blob/246c2701e5c43e02e9783c82d4d107d06b019951/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClient.java#L232-L238 And from the proposal, the method name is newTableV

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-15 Thread PengHui Li
ed on the > broker side. Making it positive makes AUTO_CONSUME different with > other implicit schema types like BYTES, AUTO and AUTO_PUBLISH. > > Thanks, > Yunze > > On Mon, Jan 16, 2023 at 9:36 AM PengHui Li wrote: > > > > > This design also has serious compatib

Re: [DISCUSS] Make the default value of param "--get-subscription-backlog-size" of admin API "topics stats" true

2023-01-16 Thread PengHui Li
+1 Penghui > On Jan 16, 2023, at 23:36, Yubiao Feng > wrote: > > Hi community > > I am starting a DISCUSS for making the default value of the parameter > "--get-subscription-backlog-size" of admin API "topics stats" true. > > In the PR https://github.com/apache/pulsar/pull/9302, the property

Re: [DISCUSS] PIP-240 A new API to unload subscriptions

2023-01-17 Thread PengHui Li
I agree that if we encounter a stuck consumption issue, we should continue to find the root cause of the problem. Subscription unloading is just an option to mitigate the impact first. Maybe it can mitigate the issue for 1 hour sometimes. Especially in key_shared subscription. Sometimes it's not a

Re: [DISCUSS] PIP-240 A new API to unload subscriptions

2023-01-17 Thread PengHui Li
ng to fix? > And why cannot that be solved by client-side fixes? > > In shared sub issues, it's hard to pinpoint which consumer/where > the problem lies, and to reset that one at the client. The totality of > state spread between the brokers and all the consumers of the shared sub >

[ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-18 Thread PengHui Li
Hi all, The Apache Pulsar Project Management Committee (PMC) has invited Bo Cong (https://github.com/congbobo184) as a member of the PMC and we are pleased to announce that he has accepted. He is very active in the community in the past few years and made a lot of great contributions such as tran

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-18 Thread PengHui Li
I see the updated PR adopts this suggestion to set the enum value with > > 100. But I'm still wondering why not just use the next enum value > > (21)? What makes AUTO_CONSUME schema different from other schema types > > like ProtobufNativeSchema (20). > > > > Thanks

Re: [DISCUSS] Redundant ServiceUrlProvider design and improper use of PIP-121

2023-01-19 Thread PengHui Li
Is it better to introduce a service URL detect interval to the service URL provider? I think the `updateServiceUrl` is not the initial purpose of exposing to the Client API. It looks like users just provide the interval of checking whether the service URL is changed. The Pulsar client will check i

Re: [VOTE] PIP-236: Record schema in the request and carry to the broker when subscribing with AUTO_CONSUME schema.

2023-01-27 Thread PengHui Li
+1 (binding) Penghui On Mon, Jan 23, 2023 at 9:53 PM Enrico Olivelli wrote: > +1 (binding) > > Enrico > > Il giorno lun 23 gen 2023 alle ore 14:44 Yunze Xu > ha scritto: > > > > +1 (binding) > > > > Thanks, > > Yunze > > > > On Fri, Jan 20, 2023 at 7:06 PM SiNan Liu > wrote: > > > > > > Hello

Re: [VOTE] PIP-241: TopicEventListener / topic events for the BrokerService.

2023-01-27 Thread PengHui Li
+1 (binding) Penghui On Wed, Jan 25, 2023 at 7:31 PM Yunze Xu wrote: > +1 (binding) > > Thanks, > Yunze > > On Wed, Jan 25, 2023 at 4:22 PM Enrico Olivelli > wrote: > > > > +1 (binding) > > > > Enrico > > > > Il giorno mer 25 gen 2023 alle ore 09:14 Nicolò Boschi > > ha scritto: > > > > > > +

Re: [DISCUSS] Code freeze for Pulsar 2.12

2023-01-28 Thread PengHui Li
I have updated the milestone name from 2.12.0 to 3.0.0. https://github.com/apache/pulsar/milestone/34 Penghui On Fri, Jan 20, 2023 at 7:07 PM Nicolò Boschi wrote: > From my understanding we should follow PIP-175. > Actually it has not been officially voted on but we can address that > easily.

Re: [ANNOUNCE] Apache Pulsar 2.9.4 released

2023-01-30 Thread PengHui Li
I have pushed it again. Maybe it has been pushed failed or something on my laptop when pushing all the images. Penghui On Tue, Jan 31, 2023 at 4:44 AM Nicolò Boschi wrote: > Hei > > I can't find the "-all" docker image on dockerhub: > https://hub.docker.com/r/apachepulsar/pulsar-all/tags?page=1

Re: [Vote] PIP-242: Introduce enableStrictTopicName to reject creating topic with -partition- keyword.

2023-01-31 Thread PengHui Li
+1 (binding) Penghui On Tue, Jan 31, 2023 at 3:52 PM Nitin Goyal wrote: > +1 (non-binding) > > On Tue, Jan 31, 2023 at 12:29 PM guo jiwei wrote: > > > +1 (binding) > > > > > > Regards > > Jiwei Guo (Tboy) > > > > On Tue, Jan 31, 2023 at 2:36 PM Yunze Xu > > wrote: > > > > > > +1 (binding) > >

Re: [DISCUSS] PIP-245: Subscriptions expiration for NonPersistentTopic only

2023-02-07 Thread PengHui Li
I think we are talking about the durable subscription of the non-persistent topic, right? For the Reader API (non-durable subscription), the subscription will be removed after the reader disconnects. If not, it should be BUG. IMO, we should remove the subscription automatically if all the consumer

Re: [VOTE] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-02-09 Thread PengHui Li
+1 (binding) Penghui > On Feb 9, 2023, at 17:26, Nicolò Boschi wrote: > > +1 binding > Nicolò > > Il giorno gio 9 feb 2023 alle 04:48 Zike Yang ha scritto: > >> +1 (non-binding) >> >> Thanks, >> Zike Yang >> >> On Wed, Feb 8, 2023 at 11:08 PM Baodi Shi wrote: >>> >>> +1 (non-binding) >>>

Re: [VOTE] PIP-175: Extend time based release process

2023-02-09 Thread PengHui Li
+1 (binding) Penghui > On Feb 9, 2023, at 17:24, Nozomi Kurihara wrote: > > +1 > > The LTS plan seems clear and helpful for users. > > Thanks, > Nozomi > > 2023年2月9日(木) 5:44 Matteo Merli : > >> https://github.com/apache/pulsar/issues/15966 >> >> >>

Re: [VOTE][PIP-226] Add JWKS support for AuthenticationProviderToken

2023-02-14 Thread PengHui Li
+1 Penghui > On Feb 15, 2023, at 10:16, guo jiwei wrote: > > +1 (binding) > > > Regards > Jiwei Guo (Tboy) > > On Wed, Feb 15, 2023 at 10:11 AM wrote: >> >> +1, (non-binding) >> >> Best, >> Mattison >> On Dec 22, 2022, 11:24 +0800, Zixuan Liu , wrote: >>> Hi all, >>> >>> Voting for https

Re: [VOTE] Pulsar Client C++ Release 3.1.2 Candidate 1

2023-02-14 Thread PengHui Li
+1 binding The tests failed with curl 7.84. upgrading to 7.87 fixed the issue. Thanks, Penghui On Wed, Feb 15, 2023 at 10:36 AM 丛搏 wrote: > +1 (binding) > > - Build from source (macos x86_64 12.6) > - Run pulsar-tests with apachepulsar/pulsar:2.11.0 docker images > > https://github.com/apache/

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread PengHui Li
The pulsarctl is an admin CLI tool for Pulsar, written in go. Does it match your requirement? Penghui > On Feb 17, 2023, at 09:47, ZhangJian He wrote: > > I would like to express that the current Pulsar client for Go > (pulsar-client-go) is missing the pulsar Admin API. As such, I would like >

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-17 Thread PengHui Li
I checked with Sijie today. StreamNative can contribute the pulsarctl project to Apache Foundation. Regards, Penghui On Fri, Feb 17, 2023 at 4:02 PM Enrico Olivelli wrote: > I agree to add an admin API to the go client, this would be very helpful. > > Il giorno ven 17 feb 2023 alle ore 08:44 Zi

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-17 Thread PengHui Li
The admin CLI tool written in Go > > Thanks, > Yunze > > On Fri, Feb 17, 2023 at 4:22 PM PengHui Li wrote: >> >> I checked with Sijie today. >> StreamNative can contribute the pulsarctl project to Apache Foundation. >> >> Regards, >> Penghui >

Re: Modern look for the website

2023-02-19 Thread PengHui Li
It looks super cool! I just found some links that don't work. The button "Learn more" and "QuickStart" in the index page will forward to 404 page [image: image.png] And the case study page looks not coordinated well. https://pulsar-site-three.vercel.app/case-studies Thanks for the great job.

Re: [VOTE][PIP-242] Topic name restriction

2023-02-19 Thread PengHui Li
+1(binding) Thanks, Penghui On Mon, Feb 20, 2023 at 11:54 AM Cong Zhao wrote: > +1 (non-binding) > > Thanks, > Cong > > On 2023/02/18 08:58:26 mattisonc...@gmail.com wrote: > > Hi, All > > > > After a fascinating discussion, I would start the vote of PIP-242. > > > > We have chosen to drop out

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 3

2023-02-27 Thread PengHui Li
+1 (binding) - install on macos - start a standalone (latest master) - run the example https://github.com/apache/pulsar-client-python#running-examples Regards, Penghui On Thu, Feb 23, 2023 at 11:00 PM Enrico Olivelli wrote: > Thank you Yunze for double checking. > > I don't have time to test t

Re: [Discuss] PIP-248: Add backlog eviction metric

2023-02-27 Thread PengHui Li
Maybe we can use `pulsar_subscription_backlog_quota_percentage`? Add _subscription here because this metric is only for subscriptions. Aggregated by topic/namespace level is meaningless. We should also mention the new metrics only be exposed if the subscription level metrics is enabled. And we sho

Re: Please stop cherry-picking (breaking) changes to the released branches

2023-02-27 Thread PengHui Li
Hi enrico, +1 for your point. Do you know the details of the breaking change? I can't find any discussions under the mailing list about the breaking change. I have added the `release/important-notice ` label to the PR, and we should also discuss first, better to have a proposal if we are making

Re: [DISCUSS]Add an internal class to `TransactionBufferStats` to record the snapshot status uniformly.

2023-02-27 Thread PengHui Li
Hi Xiangying, If the change applies to users, we should start with a proposal to provide the background, the goal and the related API changs. Thanks, Penghui On Sun, Feb 26, 2023 at 11:38 PM Asaf Mesika wrote: > On Fri, Feb 24, 2023 at 5:33 AM Xiangying Meng > wrote: > > > Hi Asaf, > > > How

Re: [DISCUSS] Change PIP template

2023-02-27 Thread PengHui Li
+1 Penghui On Mon, Feb 27, 2023 at 9:24 PM Asaf Mesika wrote: > Mails don't support things like markdown diagrams or images and are > generally less easy to read. > My proposal includes a required section called Links in which you need to > fill in the discussion thread in DEV mailing list and

Re: Please stop cherry-picking (breaking) changes to the released branches

2023-02-27 Thread PengHui Li
for PRs cherry-picked he/she made. As we > > take compatibility in a high priority, if it's unclear a fix (patch) > > without breaking changes, the RM can ask for confirmation. > > > > Best, > > tison. > > > > > > PengHui Li 于2023年2月28日周二

Re: Please stop cherry-picking (breaking) changes to the released branches

2023-02-27 Thread PengHui Li
the PR is trying to introduce potential breaking changes. The committer mergingthe PR might also miss the comment (not change request). Thanks, Penghui On Tue, Feb 28, 2023 at 1:18 PM PengHui Li wrote: > > At least the RM is responsible for PRs cherry-picked he/she made. As we > take c

Re: Please stop cherry-picking (breaking) changes to the released branches

2023-02-27 Thread PengHui Li
before releasing it. > >>> > >>> At least the RM is responsible for PRs cherry-picked he/she made. As we > >>> take compatibility in a high priority, if it's unclear a fix (patch) > >>> without breaking changes, the RM can ask for confirmation. &g

Re: Please stop cherry-picking (breaking) changes to the released branches

2023-02-28 Thread PengHui Li
> By the way the main point in this email thread is that we should totally stop to do cherry-picks of stuff that it is not strictly needed Yes, the main issue we need to resolve is how we can define if the stuff strictly needed to cherry-pick. Do you think the author to provide the cherry-pick in

Re: [Discuss] PIP-248: Add backlog eviction metric

2023-03-01 Thread PengHui Li
Ah, I forgot this one "pulsar_storage_backlog_quota_limit" As Asaf said, users can just divide the two to get a percentage. I think we don't need to expose more metrics for the size-based backlog quota. And only exposing the topic-level metrics looks good to me. Users can get the alert and then che

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

2023-03-02 Thread PengHui Li
+1 (binding) Penghui > On Feb 13, 2023, at 14:56, Jiuming Tao wrote: > > Hi all, > > I would like to start a VOTE on `PIP-245: Make subscriptions of > non-persistent topic non-durable`. > > Motivation: > > There are two types of subscriptions for a topic: Durable and Non-durable. > > We cr

Re: [Discussion] Allowing configure if function consumer should skip to latest

2023-03-02 Thread PengHui Li
Hi Neng, Thanks for raising up the discussion > In certain failure cases, the function needs to skip all the content between the last successfully acked message and the latest message in the topic in order to skip the huge backlog and quick recovery. Do you have some real cases that can help us

Re: [VOTE] Pulsar Node.js Client Release 1.8.1 Candidate 2

2023-03-05 Thread PengHui Li
+1 (binding) - Verified checksum and signature - Install from npm - Start a standalone and run the example following here [0] We should mention the following in the verification steps. 1. The pulsar_binary_host_mirror is required for the RC version 2. The example in README needs to copy to a .js

Re: [DISCUSS] Critical problem report - session notification thread deadlock

2023-03-08 Thread PengHui Li
Thanks, Qiang, And for the upcoming patch releases 2.11.1, 2.10.4, 2.9.5 Please ship the fix to the release. Although it's not a fix for breaking change. But it fixed a critical issue from previous releases. Thanks, Penghui On Thu, Mar 9, 2023 at 11:44 AM wrote: > Hi, All > > We found a crit

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 4

2023-03-10 Thread PengHui Li
+1(binding) - Install the wheel on macOS (python 3.9) - Start a standalone - Run the consumer and producer example Thanks, Penghui On Fri, Mar 10, 2023 at 4:25 PM Zike Yang wrote: > Hi, Yunze > > > However, with the latest example, the output should be the following > > logs if you pressed the

Re: [Discussion] Allowing configure if function consumer should skip to latest

2023-03-13 Thread PengHui Li
nvironment. Manually resetting > the cursor is not scalable and is a heavy burden for the on-call person in > such cases. > > > > Hope the above use case can help provide some more context regarding the > change. > > > > On 2023/03/03 03:51:35 PengHui Li wrote:

Re: Release 2.11.1

2023-03-15 Thread PengHui Li
+1 Just a reminder, this one [0] might be a blocker for the subsequent patch releases since it has introduced a new rule of the rule_name. Here [1] is the discussion under the private mailing thread. IMO, we should revert this change first before starting the release. And I also hope more PMCs ca

Re: [VOTE] PIP-259: Make the config httpMaxRequestHeaderSize of the pulsar web server to configurable

2023-03-21 Thread PengHui Li
+1(binding) Thanks, Penghui On Tue, Mar 21, 2023 at 3:21 PM Yunze Xu wrote: > +1 (binding) > > Thanks, > Yunze > > On Tue, Mar 21, 2023 at 2:59 PM 丛搏 wrote: > > > > +1 (binding) > > > > Thanks, > > Bo > > > > Yubiao Feng 于2023年3月20日周一 17:11写道: > > > > > > Hi Pulsar Community > > > > > > This

Re: [DISCUSS] PIP-260: Client consumer filter received messages

2023-03-23 Thread PengHui Li
Hi Bo, > Only support Consumer#redeliverUnacknowledgedMessages() > > If we redeliver individual messages, they will be filtered. Because we can't clear the record latest message in the consumer when redelivering individual messages. It will make this config unclear, and if every redeliver method c

Re: [VOTE] PIP-254: Support configuring client version with a description suffix

2023-03-26 Thread PengHui Li
+1 (binding) Regards, Penghui On Fri, Mar 24, 2023 at 5:22 PM Yunze Xu wrote: > Bump. Please take a look and vote for this proposal. > > Thanks, > Yunze > > On Mon, Mar 20, 2023 at 3:13 PM Zike Yang wrote: > > > > +1 (non-binding) > > > > Thanks, > > Zike Yang > > > > On Wed, Mar 15, 2023 at 3

Re: [DISCUSS] Cherry-pick #15121 into branch-2.10 to solve the issue sasl authentication failure

2023-03-28 Thread PengHui Li
Looks good to me to make it optional in branch-2.10 since we don't want to introduce any break behaviors in the subsequent patch releases. Thanks, Penghui On Tue, Mar 28, 2023 at 9:39 PM Dezhi Liu wrote: > I agree with cherry-picking PR 15121 to branch-2.10 and keep compatibility. > > > Best, >

Re: [DISCUSS] We must change the way we review PIPs

2023-03-30 Thread PengHui Li
+1 for creating a folder named "pip" in the main pulsar repo So far, it is good enough to solve the problems we've had. If it is really worth moving to another repo in the future. We can move it maybe 3, 5 years later. Thanks, Penghui On Fri, Mar 31, 2023 at 8:29 AM tison wrote: > Hi Asaf, >

Re: [DISCUSS] Add checklist for PMC binding vote of PIP

2023-03-30 Thread PengHui Li
It looks like we can try to add a new section to https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md like "Review the proposal" and it is not only for PMCs, all the reviewers can follow the checklist to cast a solemn vote. And I totally support the motivation of this discussion. Re

Re: [ANNOUNCE] Qiang Zhao as new PMC member in Apache Pulsar

2023-03-30 Thread PengHui Li
Congrats! Regards, Penghui On Thu, Mar 30, 2023 at 10:21 PM Zixuan Liu wrote: > Congrats! > > Thanks, > Zixuan > > 太上玄元道君 于2023年3月30日周四 01:40写道: > > > Congrats!! > > > > Thanks, > > Tao Jiuming > > > > > 2023年3月29日 23:51,Devin Bost 写道: > > > > > > Congrats! > > > > > > Devin G. Bost > > > > >

Re: [VOTE] Pulsar Release 2.11.1 Candidate-1

2023-03-30 Thread PengHui Li
+1 (binding) - Checked the signature - Run standalone - Run Pulsar perf - Verified function and state function - Verified Cassandra connector Regards, Penghui On Mon, Mar 27, 2023 at 8:07 PM 丛搏 wrote: > +1 (binding) > > system: mac os 12.6, Apple M1 > maven: 3.8.5 > java: OpenJDK 17.0.3 > > -

Re: [VOTE] Pulsar Release 2.9.5 Candidate 2

2023-04-02 Thread PengHui Li
+1 (binding) - Start standalone - Use pulsar-perf to produce and consume - Function and state function works - Cassandra connector works Regards, Penghui On Sun, Apr 2, 2023 at 10:57 PM wrote: > +1 (Binding) > > • Built from the source package (maven 3.8.6 OpenJDK 11.0) > • Ran binary package

Re: [DISCUSS] PIP-255: Assign topic partitions to bundle by round robin

2023-04-10 Thread PengHui Li
Hi Lin, > The load managed by each Bundle is not even. Even if the number of partitions managed by each bundle is the same, there is no guarantee that the sum of the loads of these partitions will be the same. Do we expect that the bundles should have the same loads? The bundle is the base

Re: [DISCUSS] forbid user to upload `BYTES` schema

2023-04-16 Thread PengHui Li
> Did we consider making a call to upload a Bytes schema a no-op? It was a BUG that the PR fixed. You will not be able to get the uploaded schema as expected. Please take a look at the details from the GitHub issue. What is the challenge for the Flink connector now? The changes only take effect o

Re: [DISCUSS] forbid user to upload `BYTES` schema

2023-04-16 Thread PengHui Li
ion. Best, Penghui On Mon, Apr 17, 2023 at 10:16 AM PengHui Li wrote: > > Did we consider > making a call to upload a Bytes schema a no-op? > > It was a BUG that the PR fixed. > You will not be able to get the uploaded schema as expected. > Please take a look at the details from th

Re: [Discuss] Suggestion for a "clear" parameter in Pulsar-admin to simplify tenant and namespace cleanup

2023-04-17 Thread PengHui Li
The new operation will delete all the data and the metadata under a tenant or namespace. I would like to suggest to use `delete-all-namespaces` and `delete-all-topics` The `delete` actually acts as a fact of deleting metadata and data. And `truncate` is for deleting the data. IMO, we'd better not

Re: [DISCUSS] Add checklist for PMC binding vote of PIP

2023-04-17 Thread PengHui Li
gt; to take before casting your vote. > > -1 to requiring this checklist when we cast a vote > > > > Thanks > > Enrico > > > > > > > > Il Dom 16 Apr 2023, 15:47 Asaf Mesika ha > scritto: > > > > > Would love additional feedback on this sug

Re: [VOTE] Pulsar Release 2.11.1 Candidate-2

2023-04-17 Thread PengHui Li
The RC version failed to verify the state function The output: ``` ~/Downloads/release_2.11.1/apache-pulsar-2.11.1 » bin/pulsar-admin functions status --tenant test --namespace test-namespace --name word_count { "numInstances" : 1, "numRunning" : 1, "instances" : [ { "instanceId" : 0,

Re: [VOTE] Pulsar Release 2.10.4 Candidate 4

2023-04-17 Thread PengHui Li
+1 (binding) - Checked the signature - Build from the source package - Start standalone - Checked cassandra connector - Checked state function Regards, Penghui On Sat, Apr 15, 2023 at 5:37 PM wrote: > +1 (Binding) > > • Built from the source package (maven 3.8.6 OpenJDK 11) > • Ran binary pa

Re: [VOTE] Pulsar Release 2.9.5 Candidate 3

2023-04-17 Thread PengHui Li
+1 (binding) - Checked the signature - Build from the source package - Start standalone - Checked cassandra connector - Checked state function Regards, Penghui On Sat, Apr 15, 2023 at 6:08 PM wrote: > +1 (Binding) > > • Built from the source package (maven 3.8.6 OpenJDK 11.0) > • Ran binary

Re: [VOTE] Pulsar Release 2.11.1 Candidate-2

2023-04-17 Thread PengHui Li
verifying > Stateful Functions ? > > Thanks, > Haiting > > On Mon, Apr 17, 2023 at 7:48 PM PengHui Li wrote: > > > > The RC version failed to verify the state function > > > > The output: > > > > ``` > > ~/Downloads/release_2.11.1/apache-pulsar-2.1

Re: [DISCUSS] forbid user to upload `BYTES` schema

2023-04-17 Thread PengHui Li
erations of the topic level metadata store. We can > truly drop the use of uploading the BYTES schema in the Flink > connector. > > On Mon, Apr 17, 2023 at 12:12 PM PengHui Li wrote: > > > > I'm sorry. I have provided the wrong description of the changes from the > PR.

Re: [DISCUSS] forbid user to upload `BYTES` schema

2023-04-17 Thread PengHui Li
I have pushed out a PR to revert this change first. https://github.com/apache/pulsar/pull/20123 Please help review. Thanks, Penghui On Tue, Apr 18, 2023 at 11:36 AM PengHui Li wrote: > > Flink uses the schema to store some kv based properties. If we can > expose all the operatio

Re: [VERIFY] Pulsar Release 3.0.0 Candidate 2

2023-04-19 Thread PengHui Li
There is a discussion about the new API introduced in 3.0.0 but it should not be a public API. Details to see: https://github.com/apache/pulsar/issues/18950 Yunze is checking more details. Regards, Penghui On Wed, Apr 19, 2023 at 7:02 PM Zike Yang wrote: > This is the second release candidate

Re: [NOTICE] Please don't cherry-pick commits to branch-3.0 without consensus

2023-04-24 Thread PengHui Li
Can we cherry-pick fixes for the new features that were introduced to 3.0.0? We do lots of chaos testing, stress testing for new delayed messages, and load balancer before the 3.0.0 release. Is it reasonable to have the fixes without releasing buggy features? Or the testing should be completed bef

Re: [NOTICE] Please don't cherry-pick commits to branch-3.0 without consensus

2023-04-24 Thread PengHui Li
t, regular releases, this should not be an issue for users. > Of course this must be discussed in the community and we should make the > release process more clear about that. > We learn as we do the things 🙂. > > > Le lun. 24 avr. 2023 à 12:48, Enrico Olivelli a > écrit > :

Re: [VOTE] Pulsar Release 3.0.0 Candidate 4

2023-04-28 Thread PengHui Li
+1 (binding) - Checked the signature - Build from the source package - Start a standalone - Checked the Cassandra connection - Checked the stateful function - Checked the Pulsar SQL Thanks, Penghui On Thu, Apr 27, 2023 at 7:47 PM Christophe Bornet wrote: > This is the fourth release candidate

Re: [DISCUSS] Add checklist for PMC binding vote of PIP

2023-05-08 Thread PengHui Li
e checklist be meaningful, like the PIP-192, which > >>>> is a very complicated proposal. > >>>> > >>>>> Moreover, this checklist can ensure that all participants have > >>>> thoroughly reviewed the PIP, > >>>> > >>

Re: [VOTE] PIP-255: Make the partition assignment strategy pluggable

2023-05-08 Thread PengHui Li
I'm sorry for not getting back to you sooner. >From the description of the proposal. You have figured out the problems with the current solution. From my understanding, only the first one is in the scope of this proposal. The other two problems, one is about the issue from ThresholdShedder and ano

Re: [VOTE] PIP-261: Restructure Getting Started section

2023-05-08 Thread PengHui Li
I have one question about the ready-made applications under the Getting Started section. Should we consider putting the application's source code into another repo? So that users can fork the repo to play the application and check how it works. Otherwise, users must follow the steps to build the ap

Re: [DISCUSS] PIP-265: PR-based system for managing and reviewing PIPs

2023-05-08 Thread PengHui Li
Thanks for driving the improvements in proposal managing and reviewing. The proposal looks good to me. I have only one question about the dir name for the pips. For now, we have https://github.com/apache/pulsar/tree/master/wiki/proposals Is it better to use the existing one? Or change the existing

Re: [VOTE] PIP-255: Make the partition assignment strategy pluggable

2023-05-08 Thread PengHui Li
Hi Lin, I noticed the PIP is updated, and thanks for addressing my comments. It looks good to me now. +1 (binding) Regards, Penghui On Mon, May 8, 2023 at 5:16 PM PengHui Li wrote: > I'm sorry for not getting back to you sooner. > > From the description of the proposal. You ha

Re: [VOTE] PIP-265: PR-based system for managing and reviewing PIPs

2023-05-14 Thread PengHui Li
+1 (binding) Thanks, Penghui On Wed, May 10, 2023 at 6:52 PM Asaf Mesika wrote: > Hi, > > I'm starting the vote process for PIP-265. > > Link: https://github.com/apache/pulsar/issues/20207 > > Thanks! > > Asaf >

Re: [VOTE] Pulsar Client C++ Release 3.2.0 Candidate 3

2023-05-15 Thread PengHui Li
+1 (binding) - Checked the signature - Build from source codes on MacOS (13.3.1) with (M2 Pro) - Ran pulsar-tests under the tests/ dir Regards, Penghui On Thu, May 11, 2023 at 6:43 PM Nozomi Kurihara wrote: > +1 (binding) > > - verified signature and checksum > - built from source codes on Cen

Re: [VOTE] PIP-261: Restructure Getting Started section

2023-05-15 Thread PengHui Li
Hi Asaf, I have updated the wiki page. Thanks, Penghui On Wed, May 10, 2023 at 12:53 AM Asaf Mesika wrote: > Who can help me update in https://github.com/apache/pulsar/wiki > that it has passed? > > > On Tue, May 9, 2023 at 5:01 PM Asaf Mesika wrote: > > > The vote has passed with 4 of bindin

Re: [DISCUSS] PIP-268: Add support of topic stats/stats-internal using client api

2023-05-15 Thread PengHui Li
I have no strong objection. Just a few questions. How do we handle the stats/internal-stats of a partitioned topic? As I understand, the client side will combine the stats/internal-stats of the partitions? It's better to clarify in the proposal. Do we need a compatibility section to clarify the b

Re: [DISCUSS] PIP-267: Support multi-topic messageId deserialization to ack messages

2023-05-15 Thread PengHui Li
I think the topic name will not be transmitted to the broker. The client side used the class generated by the protobuf message. Or, we can create another class to avoid coupling issues, but it will introduce more changes and copy data from one structure to another. For the long-term, I think it sho

Re: [VOTE] PIP-270 Add config to set metadata size threshold for compression

2023-05-15 Thread PengHui Li
It looks good to me. Just a minor suggestion about the name of the configuration. managedLedgerInfoCompressionSizeThreshold -> managedLedgerInfoCompressionThresholdInBytes managedCursorInfoCompressionSizeThreshold -> managedCursorInfoCompressionThresholdInBytes And is it better to introduce a mi

Re: [VOTE] PIP-251 Enhancing Transaction Buffer Stats and Introducing TransactionBufferInternalStats API

2023-05-21 Thread PengHui Li
+1 binding Thanks, Penghui On Fri, May 12, 2023 at 10:34 AM 丛搏 wrote: > +1(binding) > > Thanks, > Bo > > Nicolò Boschi 于2023年5月11日周四 16:38写道: > > > > +1 binding > > > > I'm happy that we're going to improve the monitoring tools for > > transactions, > > which is probably the aspect that is lac

Re: [DISCUSS] PIP-255: Support for Idempotent Commit and Abort.

2023-05-25 Thread PengHui Li
Can we follow the same mechanism in transaction buffer for maintaining the aborted transactions? The idea is if we can't find the transaction ID in the aborted transaction ID set, it means the transaction is committed. So that, we can have a aborted transaction set in transaction metadata store. M

Re: [Discuss] Release Pulsar Python Client 3.2.0

2023-05-28 Thread PengHui Li
+1, thanks for driving the release Regards, Penghui On Thu, May 25, 2023 at 9:48 PM Yunze Xu wrote: > Hi all, > > I would like to propose releasing the Pulsar Python Client 3.2.0. > > It has been over 2 months since the last release (3.1.0). There have > been some new features and bug fixes sin

Re: [VOTE] PIP-266: Support batch deletion of tenants, namespaces, topics, and subscriptions using input files and regex in Pulsar CLI

2023-05-28 Thread PengHui Li
+1(binding) Thanks, Penghui On Mon, May 29, 2023 at 9:05 AM guo jiwei wrote: > +1 (binding) > > > Regards > Jiwei Guo (Tboy) > > On Fri, May 5, 2023 at 11:12 AM Xiangying Meng > wrote: > > > > Hello Pulsar community, > > > > This thread is to start a vote for PIP-266: Support batch deletion of

Re: Re: [DISCUSS] PIP-270 Add config to set metadata size threshold for compression.

2023-05-28 Thread PengHui Li
> managedLedgerInfoCompressionThresholdInBytes managedLedgerInfoCompressionThresholdInBytes It should be managedLedgerInfoCompressionThresholdInBytes managedCursorInfoCompressionThresholdInBytes And it is better to add a link to the data structure to help reviewers to understand the proposal. R

Re: [VOTE] Pulsar Client Python Release 3.2.0 Candidate 1

2023-06-02 Thread PengHui Li
+1 (binding) - Checked the signature - Install pulsar_client-3.2.0-cp311-cp311-macosx_10_15_universal2.whl - Start standalone (master) - Start consumer (python3 ./examples/consumer.py) - Start producer (python3 ./examples/producer.py) - The consumer can receive all the published messages by produc

Re: [DISCUSS] Release Pulsar 3.0.1

2023-06-04 Thread PengHui Li
+1 Thanks for driving the release. Penghui On Thu, Jun 1, 2023 at 7:38 PM Zike Yang wrote: > Hi all, > > I would like to propose releasing the Pulsar 3.0.1. > > Currently, there are 95 new commits in branch-3.0: > https://github.com/apache/pulsar/compare/v3.0.0...branch-3.0 > > And we have fou

Re: [DISCUSS] forbid user to upload `BYTES` schema

2023-06-04 Thread PengHui Li
saving nothing? > > > > On Mon, Apr 17, 2023 at 8:42 PM PengHui Li wrote: > > > I have pushed out a PR to revert this change first. > > > > https://github.com/apache/pulsar/pull/20123 > > > > Please help review. > > > > Thanks

Re: [DISCUSS] Release Pulsar 3.0.1

2023-06-11 Thread PengHui Li
gt; > > Il Sab 10 Giu 2023, 16:15 Christophe Bornet ha > scritto: > > > +1 > > > > Le lun. 5 juin 2023 à 03:44, Zixuan Liu a écrit : > > > > > +1 > > > > > > Thanks, > > > Zixuan > > > > > > Hang C

Re: [VOTE] PIP-276: Add metric `pulsar_topic_load_times

2023-06-19 Thread PengHui Li
+1 (binding) Thanks, Penghui On Tue, Jun 20, 2023 at 10:40 AM Yubiao Feng wrote: > Voting +1 (non-binding) > > Thanks > Yubiao Feng > > On Mon, Jun 19, 2023 at 5:21 PM Asaf Mesika wrote: > > > Voting +1 (non-binding) > > > > On Fri, Jun 16, 2023 at 12:23 PM guo jiwei wrote: > > > > > @Asaf Th

Re: [VOTE] PIP-267: Support multi-topic messageId deserialization to ack messages

2023-06-21 Thread PengHui Li
Hi Rajan, I think we discuss the newly added field in the PulsarApi.proto at https://github.com/apache/pulsar/pull/19944#discussion_r1153963425 But the proposal doesn't mention it. Although I know why we need to add that field to the proto file to avoid introducing many changes to the client side

Re: [VOTE] PIP-268: Add support of topic stats/stats-internal using

2023-06-21 Thread PengHui Li
> However, stats retrieval over HTTP API doesn’t work well in use cases when users would like to access this API at a higher scale when a large number of application nodes would like to use it over HTTP which could overload brokers and sometimes makes broker irresponsive and impact admin API perfor

Re: [VOTE] PIP-268: Add support of topic stats/stats-internal using

2023-06-24 Thread PengHui Li
find the response inline. > > On Wed, Jun 21, 2023 at 5:53 PM PengHui Li wrote: > > > > However, stats retrieval over HTTP API doesn’t work well in use cases > > when users would like to access this API at a higher scale when a large > > number of application nodes

Re: [DISCUSS] PIP-278: Support pluggable topic compaction service

2023-06-24 Thread PengHui Li
Hi Cong, I have left some comments on the GH PR. PTAL Thanks, Penghui On Wed, Jun 21, 2023 at 9:12 AM Cong Zhao wrote: > Hi Pulsar Community, > > I am writing to start the discussion on PIP 278 to support pluggable > compaction service > > PR with PIP contents: https://github.com/apache/pulsar

Re: [DISCUSS] PIP-277: Clusters list API return clusters with local flag

2023-06-25 Thread PengHui Li
Hi Jiwei, Do you need to change the REST API? or will it just apply to the Admin CLI? If it requires REST API changes, you should also reflect them in the proposal. And yes, using the local and remote will be confusing because users can have multiple clusters without geo-replication. Maybe we sho

Re: [VOTE] PIP-278: Support pluggable topic compaction service

2023-06-26 Thread PengHui Li
+1 (binding) Regards, Penghui On Mon, Jun 26, 2023 at 12:19 PM Yunze Xu wrote: > I have left some comments in the proposal so please hold this vote > until the comments are addressed. > > Thanks, > Yunze > > On Mon, Jun 26, 2023 at 10:47 AM wrote: > > > > +1 (binding) > > > > Best, > > Mattiso

Re: [VOTE] PIP-268: Add support of topic stats/stats-internal using

2023-06-26 Thread PengHui Li
e can consider > any suggestion but we have multiple usecaes which need this API and we > should implement it in a way where it can provide a consistent definition > view across other APIs without maintenance efforts while making any stat > response changes. > > Thanks, > Rajan

Re: [DISCUSS] Cherry-pick PR-16059 to 2.10 to prevent infinite unloading

2023-06-30 Thread PengHui Li
+1 for cherry-pick to branch-2.10 since users don't have a workaround for this issue, and the change is well-understand, low risk. I agree with making it false for the next major version release by default. Thanks, Penghui On Sat, Jul 1, 2023 at 9:26 AM Heesung Sohn wrote: > Hi dev, > > I real

Re: [DISCUSS] Cherry-pick PR-16059 to 2.10 to prevent infinite unloading

2023-07-02 Thread PengHui Li
nfig in the next version instead of change > > the default value to `false`, which will make Pulsar's configuration > > keep increasing. > > > > Thanks, > > Hang > > > > [1] https://github.com/apache/pulsar/pull/388 > > > > PengHui Li 于202

Re: [DISCUSS] Release Pulsar 3.0.1

2023-07-02 Thread PengHui Li
Hi Zike, I have cherry-picked 3 PRs intro branch-3.0. All of them of well-understand bugs and performance issues. https://github.com/apache/pulsar/pull/20647 https://github.com/apache/pulsar/pull/20669 https://github.com/apache/pulsar/pull/20607 Thanks, Penghui On Fri, Jun 30, 2023 at 2:48 PM Y

<    4   5   6   7   8   9   10   11   >