It looks good to me. Just a minor suggestion about the name of the configuration.
managedLedgerInfoCompressionSizeThreshold -> managedLedgerInfoCompressionThresholdInBytes managedCursorInfoCompressionSizeThreshold -> managedCursorInfoCompressionThresholdInBytes And is it better to introduce a minimum available value like 16KB to avoid mistakes from the user? I don't think the compaction will help much when the data is lower than 16KB. Thanks, Penghui On Fri, May 12, 2023 at 3:02 AM Asaf Mesika <asaf.mes...@gmail.com> wrote: > 30 minutes is not enough time to read a pip :) > > > > On Thu, 11 May 2023 at 19:04 lifepuzzlefun <wjl_is_...@163.com> wrote: > > > Hello Pulsar community, > > > > This thread is to start a PIP-270 Add config to set metadata size > > threshold for compression > > > > > > Discussion thread: > > https://lists.apache.org/thread/6930c74m31rflrql9y3dpjmm0sbccqkb Issue: > > https://github.com/apache/pulsar/issues/20307 > > Voting will be open for at least 48 hours. Thanks! > > : - ) > > > > >
