Re: [DISCUSS] Redundant ServiceUrlProvider design and improper use of PIP-121

2023-01-19 Thread PengHui Li
Is it better to introduce a service URL detect interval to the service URL provider? I think the `updateServiceUrl` is not the initial purpose of exposing to the Client API. It looks like users just provide the interval of checking whether the service URL is changed. The Pulsar client will check i

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-19 Thread Haiting Jiang
Congrats! Bo Best, Haiting On Thu, Jan 19, 2023 at 2:35 PM Xiangying Meng wrote: > > Congratulations > > Thanks > Xiangying > > On Thu, Jan 19, 2023 at 1:54 PM Zixuan Liu wrote: > > > Congrats! Bo > > > > Best, > > Zixuan > > > > ZhangJian He 于2023年1月19日周四 12:33写道: > > > > > Congratulations >

Re: [ANNOUNCE] New Committer: Baodi Shi

2023-01-19 Thread Haiting Jiang
Congratulations! Best regards Haiting On Thu, Jan 19, 2023 at 1:53 PM Zixuan Liu wrote: > > Congrats! Baodi > > Best, > Zixuan > > ZhangJian He 于2023年1月19日周四 12:34写道: > > > Congratulations > > > > Thanks > > ZhangJian He > > > > > > On Thu, 19 Jan 2023 at 11:47, r...@apache.org > > wrote: > >

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-19 Thread Yan Zhao
congratulation! On 2023/01/18 13:50:12 PengHui Li wrote: > Hi all, > > The Apache Pulsar Project Management Committee (PMC) has invited Bo Cong > (https://github.com/congbobo184) as a member of the PMC and we are > pleased to announce that he has accepted. > > He is very active in the community

Re: [ANNOUNCE] New Committer: Baodi Shi

2023-01-19 Thread Yan Zhao
congratulation! On 2023/01/18 13:35:41 Yunze Xu wrote: > The Project Management Committee (PMC) for Apache Pulsar has invited > Baodi Shi (https://github.com/shibd) to become a committer and we are > pleased to announce that he has accepted. > > Being a committer enables easier contribution to th

Re: [DISCUSS] PIP-240 A new API to unload subscriptions

2023-01-19 Thread Haiting Jiang
I agree with Penghui & Xiaolong, 1. Restarting a service is usually the most common and effective option for service maintainers to recover a service and minimize the business loss. With this subscription unloading, we can reduce the impact significantly, as unloading topics will affect message wr

Re: [DISCUSS] Make the default value of param "--get-subscription-backlog-size" of admin API "topics stats" true

2023-01-19 Thread Haiting Jiang
+1 Haiting On Tue, Jan 17, 2023 at 5:50 PM Yubiao Feng wrote: > > Hi Asaf > > > It's worth noting that the estimated backlog size of a subscription is > estimated since it doesn't consider any acknowledged messages between the > mark delete position and the last message. It simply assumes all me

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-19 Thread Jiuming Tao
Congrats! > 2023年1月18日 21:50,PengHui Li 写道: > > Hi all, > > The Apache Pulsar Project Management Committee (PMC) has invited Bo Cong > (https://github.com/congbobo184) as a member of the PMC and we are > pleased to announce that he has accepted. > > He is very active in the community in the pa

Re: [ANNOUNCE] New Committer: Baodi Shi

2023-01-19 Thread Jiuming Tao
Congrats > 2023年1月18日 21:35,Yunze Xu 写道: > > The Project Management Committee (PMC) for Apache Pulsar has invited > Baodi Shi (https://github.com/shibd) to become a committer and we are > pleased to announce that he has accepted. > > Being a committer enables easier contribution to the project

Re: [DISCUSS] PIP-239: Retry Mechanism per Message

2023-01-19 Thread Haiting Jiang
Hi Nitin, Michael's point about the decoupling of producer and consumer makes sense. Your use case is more like a queue model, not a pub-sub model. So the decoupling is not the issue for you. But Pulsar is mainly a pub-sub system by nature. So we must take it into more consideration. As in your

Re: [DISCUSS] PIP-241: TopicEventListener / topic events for the BrokerService

2023-01-19 Thread Haiting Jiang
Hi Andrey, This PIP makes sense to me. A small question: Is it better to define `TopicEvent` and `EventStage` outside of `TopicEventsListener`? Thanks, Haiting On Tue, Jan 17, 2023 at 3:51 PM Enrico Olivelli wrote: > > I support this PIP. > This will allow Protocol Handlers to have better kno

Re: [DISCUSS] PIP-235: Add metric for subscription back size

2023-01-19 Thread Haiting Jiang
Hi Xiao, > New metric pulsar_subscription_back_log_size The metric name is better as `pulsar_subscription_backlog_size`, to keep consistent with `pulsar_storage_backlog_size`. > Since 0 is a valid value for subscription backlog size, change > subscriptionStats.backlogSize to -1 from 0 if reque

Re: [DISCUSS] Add unified newTableView method in PulsarClient

2023-01-19 Thread Haiting Jiang
+1 Haiting On Mon, Jan 16, 2023 at 3:14 PM Enrico Olivelli wrote: > > +1 > > Enrico > > Il Lun 16 Gen 2023, 03:11 PengHui Li ha scritto: > > > +1 > > > > And It might be a typo when adding the table view APIs > > From the example: > > > > > > https://github.com/apache/pulsar/blob/246c2701e5c43e

Re: [DISCUSS] PIP-232: Introduce thread monitor to check if thread is blocked for long time.

2023-01-19 Thread Haiting Jiang
I support the motivation and goal. Thanks for driving this feature. Suggestion: 1. Split this PIP into parts, and start with low overhead metrics, like Heesung mentions. 2. Do some solid performance tests to assess the impact of this monitor. I am not sure if we would have performance reduction ev

Re: [ANNOUNCE] New Committer: Baodi Shi

2023-01-19 Thread Zike Yang
Congratulations! Baodi BR, Zike Yang On Thu, Jan 19, 2023 at 6:11 PM Jiuming Tao wrote: > > Congrats > > > 2023年1月18日 21:35,Yunze Xu 写道: > > > > The Project Management Committee (PMC) for Apache Pulsar has invited > > Baodi Shi (https://github.com/shibd) to become a committer and we are > > ple

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-19 Thread Zike Yang
Congratulations! Bo Cong BR, Zike Yang On Thu, Jan 19, 2023 at 6:11 PM Jiuming Tao wrote: > > Congrats! > > > 2023年1月18日 21:50,PengHui Li 写道: > > > > Hi all, > > > > The Apache Pulsar Project Management Committee (PMC) has invited Bo Cong > > (https://github.com/congbobo184) as a member of the

Re: [DISCUSS] PIP-241: TopicEventListener / topic events for the BrokerService

2023-01-19 Thread Andrey Yegorov
Hi Haiting, Currently there are no plans to use TopicEvent/EventStage outside of the TopicEventsListener. We can refactor that if the situation changes and if these will be reusable (which I doubt at least for the TopicEvent). I'd keep it contained in one file/namespace. On Thu, Jan 19, 2023 at 2

Pulsar Cpp client 3.1.1 release

2023-01-19 Thread Matteo Merli
There is a serious regression bug in Pulsar C++ client 3.1.0 where the client lib is not passing the "authoritative" flag after a lookup redirect. This causes the client to end up in an infinite loop of redirects. The problem was already fixed in https://github.com/apache/pulsar-client-cpp/pull/1

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-19 Thread Neng Lu
Congratulations! On Thu, Jan 19, 2023 at 7:18 AM Zike Yang wrote: > Congratulations! Bo Cong > > BR, > Zike Yang > > On Thu, Jan 19, 2023 at 6:11 PM Jiuming Tao > wrote: > > > > Congrats! > > > > > 2023年1月18日 21:50,PengHui Li 写道: > > > > > > Hi all, > > > > > > The Apache Pulsar Project Manage

[DISCUSS] Code freeze for Pulsar 2.12

2023-01-19 Thread Christophe Bornet
Hi Pulsar community, It's great that we released Pulsar 2.11. It has taken quite some time to stabilize the release branch and now we have more than 5 months of awesome features and commits on the master branch that would benefit a lot to our users. That's why I'd like to propose to start a code f

Re: [DISCUSS] Code freeze for Pulsar 2.12

2023-01-19 Thread mattisonchao
Isn't the next version LTS 3.0? Best Mattison On Jan 20, 2023, 07:11 +0800, Christophe Bornet , wrote: > Hi Pulsar community, > > It's great that we released Pulsar 2.11. It has taken quite some time to > stabilize the release branch and now we have more than 5 months of awesome > features and com

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-19 Thread guo jiwei
Congratulations! Bo Cong Regards Jiwei Guo (Tboy) On Fri, Jan 20, 2023 at 6:36 AM Neng Lu wrote: > > Congratulations! > > On Thu, Jan 19, 2023 at 7:18 AM Zike Yang wrote: > > > Congratulations! Bo Cong > > > > BR, > > Zike Yang > > > > On Thu, Jan 19, 2023 at 6:11 PM Jiuming Tao > > wrote: > >

[VOTE] Pulsar Client C++ Release 3.1.1 Candidate 1

2023-01-19 Thread Matteo Merli
This is the first release candidate for Apache Pulsar Client C++, version 3.1.1. It fixes the following issues: https://github.com/apache/pulsar-client-cpp/issues?q=label%3Arelease%2F3.1.1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Note

Re: [DISCUSS] Code freeze for Pulsar 2.12

2023-01-19 Thread Yunze Xu
I would like to include PIP-224 (even and PIP-229) in the next major releases. These two PIPs have some impacts on the API and could bring many benefits to ecosystem developers. But unfortunately the first PR of PIP-224 [1] is still not reviewed by anyone. The code has already been added locally an

Re: [VOTE] PIP-224: Introduce TopicMessageId for consumer's MessageId related APIs

2023-01-19 Thread Yunze Xu
Hi guys, Please help review https://github.com/apache/pulsar/pull/19158, which has been pending for a while. I see 2.12.0 (or 3.0.0?) is coming, I hope we can include this PIP in the next major release. Thanks, Yunze On Wed, Dec 28, 2022 at 10:40 PM Yunze Xu wrote: > > Hi Enrico, > > Yeah, I've

Re: [DISCUSS] Code freeze for Pulsar 2.12

2023-01-19 Thread Yunze Xu
In addition, next week is the Chinese New Year [1] in China and there is a long holiday (a week) for Chinese developers. I hope we can delay this release for a while. [1] https://en.wikipedia.org/wiki/Chinese_New_Year Thanks, Yunze On Fri, Jan 20, 2023 at 10:23 AM Yunze Xu wrote: > > I would li

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-19 Thread Nitin Goyal
Congratulations! Bo Cong On Fri, Jan 20, 2023 at 7:17 AM guo jiwei wrote: > Congratulations! Bo Cong > > Regards > Jiwei Guo (Tboy) > > On Fri, Jan 20, 2023 at 6:36 AM Neng Lu wrote: > > > > Congratulations! > > > > On Thu, Jan 19, 2023 at 7:18 AM Zike Yang wrote: > > > > > Congratulations!

Re: [DISCUSS] Code freeze for Pulsar 2.12

2023-01-19 Thread Dave Fisher
Christophe, Given the Chinese New Year what freeze date is being proposed? Best, Dave Sent from my iPhone > On Jan 19, 2023, at 6:31 PM, Yunze Xu wrote: > > In addition, next week is the Chinese New Year [1] in China and there > is a long holiday (a week) for Chinese developers. I hope we ca

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-19 Thread Dave Fisher
Bo Cong! Congratulations! Best Regards, Dave Sent from my iPhone > On Jan 18, 2023, at 5:50 AM, PengHui Li wrote: > > Hi all, > > The Apache Pulsar Project Management Committee (PMC) has invited Bo Cong > (https://github.com/congbobo184) as a member of the PMC and we are > pleased to announc

Re: [DISCUSS] Code freeze for Pulsar 2.12

2023-01-19 Thread Matteo Merli
On Thu, Jan 19, 2023 at 3:11 PM Christophe Bornet wrote: > It's great that we released Pulsar 2.11. It has taken quite some time to > stabilize the release branch and now we have more than 5 months of awesome > features and commits on the master branch that would benefit a lot to our > users. That

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-19 Thread Yunze Xu
Congratulations! Thanks, Yunze On Fri, Jan 20, 2023 at 10:42 AM Dave Fisher wrote: > > Bo Cong! Congratulations! > > Best Regards, > Dave > > Sent from my iPhone > > > On Jan 18, 2023, at 5:50 AM, PengHui Li wrote: > > > > Hi all, > > > > The Apache Pulsar Project Management Committee (PMC) ha

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-19 Thread Yubiao Feng
Congratulations! Thanks, Yubiao Feng On Wed, Jan 18, 2023 at 9:50 PM PengHui Li wrote: > Hi all, > > The Apache Pulsar Project Management Committee (PMC) has invited Bo Cong > (https://github.com/congbobo184) as a member of the PMC and we are > pleased to announce that he has accepted. > > He i

Re: [ANNOUNCE] New Committer: Baodi Shi

2023-01-19 Thread houxiaoyu
Congratulations ! Zike Yang 于2023年1月19日周四 23:18写道: > Congratulations! Baodi > > BR, > Zike Yang > > On Thu, Jan 19, 2023 at 6:11 PM Jiuming Tao > wrote: > > > > Congrats > > > > > 2023年1月18日 21:35,Yunze Xu 写道: > > > > > > The Project Management Committee (PMC) for Apache Pulsar has invited > >