Hi Xiao,

> New metric pulsar_subscription_back_log_size

The metric name is better as `pulsar_subscription_backlog_size`, to
keep consistent with `pulsar_storage_backlog_size`.


> Since 0 is a valid value for subscription backlog size, change 
> subscriptionStats.backlogSize to -1 from 0 if request the stats of topic with 
> subscriptionBacklogSize=false.

I am not sure why we need -1 for the case that this feature is turned off.
Does the metric just don't appear in the Prometheus result?

Thanks,
Haiting

On Sun, Jan 15, 2023 at 6:44 PM Jiuming Tao
<jm...@streamnative.io.invalid> wrote:
>
> Hi Xiao,
>
> Seems `backlogSize` already existed in the `SubscriptionStatsImpl`, but 
> didn’t expose in Prometheus,
>
> We just need to expose it in Prometheus.
>
> It should exposed in Prometheus when the configuration named 
> `exposeTopicLevelMetricsInPrometheus` and 
> `exposeSubscriptionBacklogSizeInPrometheus` is enabled.
>
> +1
>
> Thanks,
> Tao Jiuming
>
> > 2022年12月30日 23:25,萧 易客 <km...@live.com> 写道:
> >
> > can
>

Reply via email to