On 2024/11/26 10:03:06 WenZhi Feng wrote:
> I am not specialized in shading dependency of the pulsar, it will be great if
> you can help to accomplish this pip together.
Regarding the shading configuration, I have cleaned up the existing shading
configuration in https://github.com/apache/pulsar/
It's fine to split the implementation in multiple PRs.
One detail about the implementation PR title. Please don't add "[pip]"
in the PR title of PIP implementations. That prefix is meant to be
used for the PIP document PR.
-Lari
On Tue, 26 Nov 2024 at 12:03, WenZhi Feng wrote:
>
> Hi Lari.
> Tha
Hi Lari.
Thanks for feedback. It is necessary to reduce the size of dependency which has
been added in high level design of the pip.
> Would it be possible to cover this important aspect as part of PIP-393
> before taking it to voting?
Do you means that we fix this problem as part of the implemen
Great work, Wenzhi.
The PIP-393 document should include the high level plan of avoiding to
increase the size of the Pulsar client by the size of fastutil jar
file. The fastutil jar file is very large, 23MB. We use only a few
classes of fastutil. There's fastutil-core library which is smaller,
abou
This is a very nice improvement and well described
No comments.
I will be +1 on VOTE
Enrico
Il giorno mar 26 nov 2024 alle ore 05:12 WenZhi Feng
ha scritto:
> Hello, Pulsar Community.
> I add the space complexity analysis of the new data structure in the PIP:
> https://github.com/apache/pulsar/
Hello, Pulsar Community.
I add the space complexity analysis of the new data structure in the PIP:
https://github.com/apache/pulsar/pull/23601.
Before this PIP, the space complexity is 48N byte in best case, 213N byte in
worst case, where N is the number of entries.
After this PIP, the space comp
