This is a very nice improvement and well described No comments. I will be +1 on VOTE
Enrico Il giorno mar 26 nov 2024 alle ore 05:12 WenZhi Feng <thetumb...@apache.org> ha scritto: > Hello, Pulsar Community. > I add the space complexity analysis of the new data structure in the PIP: > https://github.com/apache/pulsar/pull/23601. > Before this PIP, the space complexity is 48N byte in best case, 213N byte > in worst case, where N is the number of entries. > After this PIP, the space complexity is 0.163N byte in best case( > 0.163/48=0.3% of the origrinal), 4N byte in worst case(4/213=1.8% of the > origrinal), which is a huge improvement! > Feel free to leave your comments and push this improvement into the pulsar. > > Thanks, > Wenzhi Feng.(thetumbled) > > On 2024/11/15 08:47:33 thetumbled wrote: > > Hi, Pulsar Community. > > I open a new PIP to fix several issues with negative ack feature. > Most importantly, the memory occupation is less than 1% of the original > implementation, which make it practical to work in the production > enviroment. > > Some experiment data is listed in the PR, you can also verify the > improvement with the test code i show. > > link: https://github.com/apache/pulsar/pull/23601 > > > > Thanks, > > Wenzhi Feng(thetumbled) >
