Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

+1 (binding) Thanks, Bo guo jiwei 于2023年3月6日周一 19:10写道： > > +1 (binding) > > Regards > Jiwei Guo (Tboy) > > On Mon, Mar 6, 2023 at 9:59 AM Yunze Xu wrote: > > > > +1 (binding) > > > > Thanks, > > Yunze > > > > On Fri, Mar 3, 2023 at 11:46 AM PengHui Li wrote: > > > > > > +1 (binding) > > > > >

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

+1 (binding) Regards Jiwei Guo (Tboy) On Mon, Mar 6, 2023 at 9:59 AM Yunze Xu wrote: > > +1 (binding) > > Thanks, > Yunze > > On Fri, Mar 3, 2023 at 11:46 AM PengHui Li wrote: > > > > +1 (binding) > > > > Penghui > > > > > On Feb 13, 2023, at 14:56, Jiuming Tao > > > wrote: > > > > > > Hi all

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

+1 (binding) Thanks, Yunze On Fri, Mar 3, 2023 at 11:46 AM PengHui Li wrote: > > +1 (binding) > > Penghui > > > On Feb 13, 2023, at 14:56, Jiuming Tao > > wrote: > > > > Hi all, > > > > I would like to start a VOTE on `PIP-245: Make subscriptions of > > non-persistent topic non-durable`. > >

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

+1 (binding) Penghui > On Feb 13, 2023, at 14:56, Jiuming Tao wrote: > > Hi all, > > I would like to start a VOTE on `PIP-245: Make subscriptions of > non-persistent topic non-durable`. > > Motivation: > > There are two types of subscriptions for a topic: Durable and Non-durable. > > We cr

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

Bump > 2023年2月13日 14:56，Jiuming Tao > 写道： > > Hi all, > > I would like to start a VOTE on `PIP-245: Make subscriptions of > non-persistent topic non-durable`. > > Motivation: > > There are two types of subscriptions for a topic: Durable and Non-durable. > > We

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

bump On 2023/02/13 06:56:09 Jiuming Tao wrote: > Hi all, > > I would like to start a VOTE on `PIP-245: Make subscriptions of > non-persistent topic non-durable`. > > Motivation: > > There are two types of subscriptions for a topic: Durable and Non-durable. > > We create a Consumer with a Dura

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

Hi Rajan, Even we don't persistent NonPersistentSubscription's state, but it has a `isDurable` field ``` public NonPersistentSubscription(NonPersistentTopic topic, String subscriptionName, boolean isDurable, Map properties) { this.topic = topic;

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

> But for NonPersistentTopic, creating a Durable subscription is meaningless, NonPersistentSubscription doesn't have a ManagedCursor to persistent its data. After its consumer disconnected, the subscription couldn't be removed automatically if we didn't set the value of subscriptionExpirationTimeMi

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

+1 (non-binding) Thanks, Zike Yang On Wed, Feb 22, 2023 at 10:12 PM Jiuming Tao wrote: > > It makes sense > > > 2023年2月20日 17:32，Zike Yang 写道： > > > > Hi, Jiuming, > > > > Overall looks good to me. Left some comments for the Compatibility section: > > > >> In the next release after 2.11.1, if u

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

It makes sense > 2023年2月20日 17:32，Zike Yang 写道： > > Hi, Jiuming, > > Overall looks good to me. Left some comments for the Compatibility section: > >> In the next release after 2.11.1, if users want to create Durable >> subscriptions on NonPersistentTopic, will throw an exception. > > I think

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

Hi, Jiuming, Overall looks good to me. Left some comments for the Compatibility section: > In the next release after 2.11.1, if users want to create Durable > subscriptions on NonPersistentTopic, will throw an exception. I think this is an improvement but not a bug fix. Right? The next feature

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

+1 (non-binding) Thanks, Baodi Shi 在 2023年2月16日 21:44:17 上，Asaf Mesika 写道： > +1 (non-binding) > > > On Thu, Feb 16, 2023 at 11:11 AM Jiuming Tao > > wrote: > > > I’ve added the `Compatibility` selection into the PIP, please help review > > and vote the PIP > > > Thanks, > > Tao Jiuming > > >

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

+1 (non-binding) On Thu, Feb 16, 2023 at 11:11 AM Jiuming Tao wrote: > > I’ve added the `Compatibility` selection into the PIP, please help review > and vote the PIP > > Thanks, > Tao Jiuming > > > > > 2023年2月15日 14:58，Zike Yang 写道： > > > > Hi, Jiuming > > > >> bump > > > > As for the discussi

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

I’ve added the `Compatibility` selection into the PIP, please help review and vote the PIP Thanks, Tao Jiuming > 2023年2月15日 14:58，Zike Yang 写道： > > Hi, Jiuming > >> bump > > As for the discussion here[0], could you add a `Compatibility` section > to talk about compatibility in more detai

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

Hi, Jiuming > bump As for the discussion here[0], could you add a `Compatibility` section to talk about compatibility in more detail? WDYT? Then we could start the vote again. [0] https://lists.apache.org/thread/2bjg39zh7z38bzbnqngbo5l4jzkjttrq Thanks, Zike Yang On Wed, Feb 15, 2023 at 1:34 PM

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

bump On 2023/02/13 06:56:09 Jiuming Tao wrote: > Hi all, > > I would like to start a VOTE on `PIP-245: Make subscriptions of > non-persistent topic non-durable`. > > Motivation: > > There are two types of subscriptions for a topic: Durable and Non-durable. > > We create a Consumer with a Du

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

I made a small comment on the PIP just now. On Mon, Feb 13, 2023 at 8:56 AM Jiuming Tao wrote: > Hi all, > > I would like to start a VOTE on `PIP-245: Make subscriptions of > non-persistent topic non-durable`. > > Motivation: > > There are two types of subscriptions for a topic: Durable and Non

[Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

Hi all, I would like to start a VOTE on `PIP-245: Make subscriptions of non-persistent topic non-durable`. Motivation: There are two types of subscriptions for a topic: Durable and Non-durable. We create a Consumer with a Durable subscription and a Reader with a Non-durable subscription. But