Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-15 Thread Ran Gao
Yes, all necessary PRs are cherry-picked to branch-2.9, and the test pass, refer to https://github.com/apache/pulsar/commits/branch-2.9, I'm cutting the new RC from the current branch-2.9. On 2022/02/15 14:57:25 Enrico Olivelli wrote: > Ran, > Are we cutting the new RC from the current branch-2.

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-15 Thread Enrico Olivelli
Ran, Are we cutting the new RC from the current branch-2.9? Enrico Il Mar 15 Feb 2022, 14:57 PengHui Li ha scritto: > Hi Ran, > > I think all the PRs that block the 2.9.2 release are merged. > Could you please help cherry-pick the PRs and start a new RC? > > Thanks, > Penghui > > On Mon, Feb 14

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-15 Thread PengHui Li
Hi Ran, I think all the PRs that block the 2.9.2 release are merged. Could you please help cherry-pick the PRs and start a new RC? Thanks, Penghui On Mon, Feb 14, 2022 at 8:25 PM PengHui Li wrote: > Hi Lari, > > We have another issue that needs to confirm if it will introduce break > changes i

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-14 Thread PengHui Li
Hi Lari, We have another issue that needs to confirm if it will introduce break changes in 2.9.2, Expected to have a result tomorrow, it related to https://github.com/apache/pulsar/pull/13383, We're doing more testing to make sure it doesn't introduce unexpected behavior. Regards, Penghui On Mon

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-14 Thread Lari Hotari
When is 2.9.2 Candidate 3 planned? What changes will it include? All current changes in branch-2.9 ? The version has already been set to 2.9.3-SNAPSHOT in branch-2.9 with https://github.com/apache/pulsar/pull/14089 . If we do 2.9.2 with all current changes from branch-2.9, the commit for PR 14089

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-11 Thread PengHui Li
Now, there is a regression introduced in 2.9.2 I have pushed out the fix https://github.com/apache/pulsar/pull/14231, PTAL. -1 from my side Need to get the fix merged and roll out the new RC3 @Ran Regards, Penghui On Thu, Feb 10, 2022 at 9:54 PM Nicolò Boschi wrote: > Penghui, > > > I didn't

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-10 Thread Nicolò Boschi
Penghui, I didn't know that there were so many known bugs around transactions scheduled for 2.9.3, my bad. However, as Enrico pointed out, the issue impacts Pulsar clients that are not using the transactions, so we can't just say - ok, just another bug about transactions, it's not critical since

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-10 Thread PengHui Li
> Please go ahead with the release, I won't VOTE on this thread. But I hope we can follow up soon with a new release, otherwise due to that bug you cannot enable transactions on your Pulsar cluster if you have to support Pulsar client that do not enable transactions Yes, agree. We will follow up

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-10 Thread Lin Lin
+1(binding) 1. Checked the signature 2. Start standalone 3. Publish and consume successfully 4. Checked function

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-10 Thread Enrico Olivelli
Il giorno gio 10 feb 2022 alle ore 11:25 PengHui Li ha scritto: > > > wow, this is incredible, we really should slow down in cherry-picking > stuff to release branches. > But this is off-topic, as this is a VOTE thread. > > Yes, as discussed here > https://lists.apache.org/thread/b4wr2chgdrqjgjq4o

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-10 Thread PengHui Li
> wow, this is incredible, we really should slow down in cherry-picking stuff to release branches. But this is off-topic, as this is a VOTE thread. Yes, as discussed here https://lists.apache.org/thread/b4wr2chgdrqjgjq4omf6mtfc3g2f9cnx 2.9.1 almost equals 2.9.0, 2.9.1 contains the security issue f

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-10 Thread Hang Chen
Hi Enrico, In my opinion, the transactions is still in developing state and not stable yet. For those critical bug fixes, we'd better prepare 2.9.3 release earlier instead of blocking the current 2.9.2 release. Otherwise, if we make new release candidate for any new find bugs, It will be a hug

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-10 Thread Enrico Olivelli
Il giorno gio 10 feb 2022 alle ore 08:39 PengHui Li ha scritto: > > Enrico, > > There are 40 closed PRs > https://github.com/apache/pulsar/pulls?q=is%3Apr+label%3Arelease%2F2.9.3+is%3Aclosed > and most of them cherry-picked to branch-2.9, so you mean the 2.9.2 wow, this is incredible, we really s

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-09 Thread PengHui Li
Enrico, There are 40 closed PRs https://github.com/apache/pulsar/pulls?q=is%3Apr+label%3Arelease%2F2.9.3+is%3Aclosed and most of them cherry-picked to branch-2.9, so you mean the 2.9.2 contains all of them? or just contain https://github.com/apache/pulsar/pull/14192 ? I have no objection if we rol

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-09 Thread Enrico Olivelli
Gao, The patch https://github.com/apache/pulsar/pull/14192 has been merged. I believe that is better to roll out a new RC and have Pulsar 2.9.2 released Thanks for the good discussion Enrico Il giorno gio 10 feb 2022 alle ore 05:11 PengHui Li ha scritto: > > It should not be a blocking issue,

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-09 Thread PengHui Li
It should not be a blocking issue, as I mentioned before we can work around and the issue happens for specific conditions And there are some other ongoing transaction fixes, for transactions using the latest branch-2.9 is the best option, not 2.9.2 even contain https://github.com/apache/pulsar/pull

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-09 Thread Lin Lin
My personal opinion: If this is a blocking issue, we should tag the issue and raise it in the discussion stage, not in the final release stage, which will waste a lot of time of the release manager. But I see this issue is already closed. https://github.com/apache/pulsar/pull/14097 We can eva

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-09 Thread PengHui Li
> given the fact that Transactions are not something that you can use in production in 2.9 Yes, for transactions, it's better to use the latest branch-2.9, not 2.9.1 or 2.9.2. > If it is a matter of fixing the problem reported by Nicolò, then we should fix it and let people try out transactions.

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-09 Thread Enrico Olivelli
Peng Hui, given the fact that Transactions are not something that you can use in production in 2.9, then we could move forward with this release. But this would be a real pity, because we are stating that users should not use transactions because they are not stable. If it is a matter of fixing t

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-09 Thread PengHui Li
> Does this mean that transactions are not yet stable in 2.9? I think we need to clarify this point and then communicate that to our users. At least currently it is not a stable version, all the components have been completed but at least not verified on a large scale, the performance needs to be

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-08 Thread Michael Marshall
I am -0 for this release because of the transaction regression, assuming it is as bad as Enrico described. I don't know enough about the transaction feature's stability to give a "-1". > There are some other ongoing transaction fixes, we can't wait for all of > them to be completed Does this mean

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-08 Thread PengHui Li
Hi enrico, There are some other ongoing transaction fixes, we can't wait for all of them to be completed Please move them to 2.9.3 and don't block the 2.9.2 release. And https://github.com/apache/pulsar/pull/14097 also in the discussion stage, We should keep calm at this time, no need to hurry to

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-08 Thread Enrico Olivelli
Penghui, Gao, see my comments below please Il giorno mar 8 feb 2022 alle ore 09:16 Hang Chen ha scritto: > > +1 (binding) > > Verified the following context. > 1. Checked the checksum and licenses > 2. Build from the source code successfully > 3. Start standalone and run pulsar-perf with produce

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-08 Thread Hang Chen
+1 (binding) Verified the following context. 1. Checked the checksum and licenses 2. Build from the source code successfully 3. Start standalone and run pulsar-perf with produce and consume 4. Checked the Pulsar function and stateful functions 5. Run Pulsar with KOP and publish and consume success

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-07 Thread PengHui Li
+1 (binding) 1. Checked the signature 2. Build from the source successfully 3. Start standalone 4. Publish and consume successfully 5. Cassandra connect works well 6. Checked state function And passed our internal integration tests. Regards, Penghui On Mon, Feb 7, 2022 at 4:37 PM PengHui Li wr

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-07 Thread PengHui Li
It's not a regression in 2.9.2, we should not block the 2.9.2 release. Instead, we can have the fix in 2.9.3. Penghui On Thu, Feb 3, 2022 at 8:42 PM Nicolò Boschi wrote: > Hi Ran, thanks for driving the release. > > I haven't tested the rc yet but I firmly believe we should include this > pull

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-03 Thread Nicolò Boschi
Hi Ran, thanks for driving the release. I haven't tested the rc yet but I firmly believe we should include this pull [1] which fixes a regression introduced in Pulsar 2.9.0 [1] https://github.com/apache/pulsar/pull/14097 Il giorno mer 2 feb 2022 alle ore 08:34 Enrico Olivelli ha scritto: > (

Re: [VOTE] Pulsar Release 2.9.2 Candidate 2

2022-02-01 Thread Enrico Olivelli
(sorry for the late reply, I am still testing, I had some other priorities). I hope that the community will test this RC and report back Enrico Il giorno mar 25 gen 2022 alle ore 15:07 Ran Gao ha scritto: > > Sorry, the 2.9.2 release candidate-1 has a wrong sign certificate. > > This is the se

[VOTE] Pulsar Release 2.9.2 Candidate 2

2022-01-25 Thread Ran Gao
Sorry, the 2.9.2 release candidate-1 has a wrong sign certificate. This is the second release candidate for Apache Pulsar, version 2.9.2. *** Please download, test, and vote on this release. This vote will stay open for at least 72 hours *** Note that we are voting upon the source (tag), binarie