Il giorno gio 10 feb 2022 alle ore 11:25 PengHui Li <peng...@apache.org> ha scritto: > > > wow, this is incredible, we really should slow down in cherry-picking > stuff to release branches. > But this is off-topic, as this is a VOTE thread. > > Yes, as discussed here > https://lists.apache.org/thread/b4wr2chgdrqjgjq4omf6mtfc3g2f9cnx > 2.9.1 almost equals 2.9.0, 2.9.1 contains the security issue fixes, > but without any other issue fixes(Includes fixes for some serious issues) > so commits in 2.9.2 is from 2.9.0 to 2.9.2 lasted more than 2 months. > > Most of the PRs cherry-picked to branch-2.9 are bug fixes or important > enhancements > such as performance issues. The reason is not we cherry-picked too fast, > is released too slow. The slower we publish, users have to build by > themselves, > if we slow down the cherry-picking, ignore some fixes, this is tantamount > to pushing users > to a situation where they maintain their own branches. > This is definitely not what we want to see. > > We should carefully consider whether is it worth delaying the release, > Explain again, https://github.com/apache/pulsar/pull/14192 is happening in > specific conditions, > This often does not occur with the normal use of topics, only for the topic > will not get a new message. > The data will not be lost, and we have a way to work around it.l
Please go ahead with the release, I won't VOTE on this thread. But I hope we can follow up soon with a new release, otherwise due to that bug you cannot enable transactions on your Pulsar cluster if you have to support Pulsar client that do not enable transactions Enrico > > Penghui > > On Thu, Feb 10, 2022 at 5:03 PM Hang Chen <chenh...@apache.org> wrote: > > > Hi Enrico, > > In my opinion, the transactions is still in developing state and > > not stable yet. For those critical bug fixes, we'd better prepare > > 2.9.3 release earlier instead of blocking the current 2.9.2 release. > > Otherwise, if we make new release candidate for any new find bugs, It > > will be a huge task for the release manager and make the release > > process delay too much time. > > I suggest to move them to 2.9.3 instead of blocking the 2.9.2 release. > > > > Best, > > Hang > > > > Enrico Olivelli <eolive...@gmail.com> 于2022年2月10日周四 16:15写道： > > > > > > Il giorno gio 10 feb 2022 alle ore 08:39 PengHui Li > > > <peng...@apache.org> ha scritto: > > > > > > > > Enrico, > > > > > > > > There are 40 closed PRs > > > > > > https://github.com/apache/pulsar/pulls?q=is%3Apr+label%3Arelease%2F2.9.3+is%3Aclosed > > > > and most of them cherry-picked to branch-2.9, so you mean the 2.9.2 > > > > > > wow, this is incredible, we really should slow down in cherry-picking > > > stuff to release branches. > > > But this is off-topic, as this is a VOTE thread. > > > > > > > contains all of them? or just contain > > > > https://github.com/apache/pulsar/pull/14192 ? > > > > I have no objection if we roll out the new RC based on current > > branch-2.9 > > > > since > > > > there are some critical fixes for transactions(Of course, I don't think > > > > there will be any problems moving them to 2.9.3) > > > > If only for https://github.com/apache/pulsar/pull/14192, I don't > > think it's > > > > necessary to roll out the new RC. > > > > > > I believe it is better to cut a new release candidate out of branch-2.9 > > > > > > Enrico > > > > > > > > > > > Thanks, > > > > Penghui > > > > > > > > On Thu, Feb 10, 2022 at 2:28 PM Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > > > > > > > Gao, > > > > > The patch https://github.com/apache/pulsar/pull/14192 has been > > merged. > > > > > I believe that is better to roll out a new RC and have Pulsar 2.9.2 > > > > > released > > > > > > > > > > > > > > > Thanks for the good discussion > > > > > > > > > > Enrico > > > > > > > > > > Il giorno gio 10 feb 2022 alle ore 05:11 PengHui Li > > > > > <peng...@apache.org> ha scritto: > > > > > > > > > > > > It should not be a blocking issue, as I mentioned before we can > > work > > > > > around > > > > > > and the issue happens for specific conditions > > > > > > And there are some other ongoing transaction fixes, for > > transactions > > > > > using > > > > > > the latest branch-2.9 is the best option, not 2.9.2 even contain > > > > > > https://github.com/apache/pulsar/pull/14097 > > > > > > > > > > > > So I suggest moving forward with the 2.9.2 release and focusing on > > the > > > > > > transaction fixes in 2.9.3. > > > > > > > > > > > > Regards, > > > > > > Penghui > > > > > > > > > > > > On Thu, Feb 10, 2022 at 11:02 AM Lin Lin <lin...@apache.org> > > wrote: > > > > > > > > > > > > > > > > > > > > My personal opinion: > > > > > > > > > > > > > > If this is a blocking issue, we should tag the issue and raise > > it in > > > > > the > > > > > > > discussion stage, not in the final release stage, which will > > waste a > > > > > lot of > > > > > > > time of the release manager. But I see this issue is already > > closed. > > > > > > > https://github.com/apache/pulsar/pull/14097 > > > > > > > > > > > > > > We can evaluate the repair time of this issue. If it does not > > take too > > > > > > > much time, I think it can be merged into 2.9.2. If it is too > > late, I > > > > > > > suggest move it to 2.9.3, since there are other serious issues > > waiting > > > > > to > > > > > > > be released, we can run in small steps. > > > > > > > > > > > > > >
