Hi Zike,
Thank you for clarifying the issues.
Sounds good if we can remove dependency on SVN.
> In addition, I suddenly thought that we also needed to upload the npm
package file `pulsar-client-1.X.0.tgz` to the SVN repo during the
release process. This file could be generated from `npm pack` com
Hi, Baodi,
> I don't think it's a good idea to upload (napi-xx.tar.gz) to npm, these files
> are tens of MB in total, and it doesn't solve the problem that the release rc
> version needs to change the address.
If we add `Pulsar.node` (which currently included in napi-xx.tar.gz)
to npm package f
Hi, Zike:
> However, doing so also creates some inconvenience for the release
> process. I was wondering if we could put these files(napi-xxx.tar.gz)
> in the npm package file.
> Do you have any ideas?
I don't think it's a good idea to upload (napi-xx.tar.gz) to npm, these files
are tens of MB
Hi Nozomi,
> * What is the "inconvenience" for the release?
This inconvenience is mainly from the process of uploading release
candidates to npm. For example, when we upload the 1.8.0-rc.X to npm,
the npm need to download files from SVN when installing. Therefore, we
need to change the `binary.ho
Hi Nozomi,
AFAIK, the napi-xxx.tar.gz will be uploaded to SVN so that `npm
install` can download these pre-built binaries directly. I didn't look
deeper into the `npm install` process, it might also download the
pre-built binaries from the temporary download links from the
candidate directory.
Th
Hi Zike,
Thank you for managing this release.
> However, doing so also creates some inconvenience for the release
process. I was wondering if we could put these files(napi-xxx.tar.gz)
in the npm package file.
I'm sorry I don't get the point of your suggestion yet...
Could you explain
* What is t
Thank you for verifying this release. Closing the vote
3 binding +1s:
* PengHui Li
* Yunze Xu
* Hang Chen
2 non-binding +1s:
* Baodi Shi
* Ran Gao
> However, I'm still wondering whether we still need to upload the
`napi-xxx.tar.gz` files? These files seem totally useless for users,
no matter in
Supplement check:
- Node.js version 10.24.1
- Ubuntu 20.04
- Install the NPM package via `npm install pulsar-client@1.8.0-rc.2`
- Verify the producer and consumer.
Thanks,
Baodi Shi
> 2022年12月30日 15:11，Hang Chen 写道：
>
> +1 (binding)
>
> - Check signatures
> - Install from source on ubuntu 2
+1 (binding)
- Check signatures
- Install from source on ubuntu 20.04 (node version >= 16.18 and npm
version >= 8.19.2)
- Run node producer and consumer to pub-sub messages
Thanks,
Hang
Yunze Xu 于2022年12月30日周五 10:54写道：
>
> +1 (binding)
> - Check signatures
> - Install from source
> - Install th
+1 (binding)
- Check signatures
- Install from source
- Install the NPM package via `npm install pulsar-client@1.8.0-rc.2`
- Verify the producer, consumer, custom_logger examples with both two
installation methods bove
However, I'm still wondering whether we still need to upload the
`napi-xx
+1 (binding)
Verify following the steps from
https://github.com/RobertIndie/pulsar-client-node-validation
- Start standalone (master branch)
- Start consumer (node ./examples/consumer.js)
- Start producer (node ./examples/producer.js)
- The consumer can receive the messages
Regards,
Penghui
On
+1 (non-binding)
- Checked npm package https://www.npmjs.com/package/pulsar-client/v/1.8.0-rc.2
- Checked source code + napi-darwin-unknown-arm64 work on macOS 12.6 (M1 Pro
chip)
Thanks,
Ran Gao
On 2022/12/27 08:29:35 Zike Yang wrote:
> Hi everyone,
>
> This is the second release candidate for
Here is a repo to help you verify:
https://github.com/RobertIndie/pulsar-client-node-validation
You can read the README file for more information.
The automatic release validation workflow on multiple platforms has been passed:
https://github.com/RobertIndie/pulsar-client-node-validation/actions/ru
+1(non-binding)
- Checked package run on ubuntu x64
- Checked package run on windows x64
- Checked package run on macOS arm64
Thanks,
Baodi Shi
> 2022年12月27日 16:29，Zike Yang 写道：
>
> Hi everyone,
>
> This is the second release candidate for the Apache Pulsar Node.js
> client, version 1.8.0.
+1(non-binding)
- Checked the source file shasum.
- Checked package run on ubuntu x64
- Checked package run on windows x64
Thanks,
Baodi Shi
> 2022年12月27日 16:29，Zike Yang 写道：
>
> Hi everyone,
>
> This is the second release candidate for the Apache Pulsar Node.js
> client, version 1.8.0.
>
Hi everyone,
This is the second release candidate for the Apache Pulsar Node.js
client, version 1.8.0.
It fixes the following issues:
https://github.com/apache/pulsar-client-node/milestone/13?closed=1
Please download the source files and review this release candidate:
- Download the source packa
16 matches
Mail list logo
