Hi Nozomi, > * What is the "inconvenience" for the release?
This inconvenience is mainly from the process of uploading release candidates to npm. For example, when we upload the 1.8.0-rc.X to npm, the npm need to download files from SVN when installing. Therefore, we need to change the `binary.host` and `binary.remote_path` in `package.json`[0] before publishing the release candidate. If there are any mistakes in this step, the rc version will not work anymore. In addition, The path for the SVN dev repo[1] is unstable. It may be removed and bring some issues. For example, the rc package `1.8.0-rc.2` will not work after we publish the final release 1.8.0. > * Will you upload napi-xxx.tar.gz to "both" npm and SVN? (In my understanding, uploading to SVN is necessary according to the Apache guideline) Yes. I have uploaded them. > * What is the benefit of uploading to npm? The above issues would be solved if we could combine these files into the npm package file. Then this package file will work just like the python client's wheel file[2]. It will decouple the npm and SVN repo. The npm no longer needs to download files from the apache SVN repo. In addition, I suddenly thought that we also needed to upload the npm package file `pulsar-client-1.X.0.tgz` to the SVN repo during the release process. This file could be generated from `npm pack` command. WDYT? [0] https://github.com/apache/pulsar-client-node/blob/0bef7999874f35df9229d2b2fce8d6f5df4f053d/package.json#L62-L63 [1] https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-node/pulsar-client-node-1.8.0-candidate-1/ [2] https://archive.apache.org/dist/pulsar/pulsar-client-python-3.0.0/macos/ BR, Zike Yang Zike Yang On Thu, Jan 5, 2023 at 6:31 PM Yunze Xu <y...@streamnative.io.invalid> wrote: > > Hi Nozomi, > > AFAIK, the napi-xxx.tar.gz will be uploaded to SVN so that `npm > install` can download these pre-built binaries directly. I didn't look > deeper into the `npm install` process, it might also download the > pre-built binaries from the temporary download links from the > candidate directory. > > Thanks, > Yunze > > On Thu, Jan 5, 2023 at 5:55 PM Nozomi Kurihara <nkuri...@apache.org> wrote: > > > > Hi Zike, > > > > Thank you for managing this release. > > > > > However, doing so also creates some inconvenience for the release > > process. I was wondering if we could put these files(napi-xxx.tar.gz) > > in the npm package file. > > > > I'm sorry I don't get the point of your suggestion yet... > > Could you explain > > * What is the "inconvenience" for the release? > > * Will you upload napi-xxx.tar.gz to "both" npm and SVN? (In my > > understanding, uploading to SVN is necessary according to the Apache > > guideline) > > * What is the benefit of uploading to npm? > > > > Best Regards, > > Nozomi
