Supplement check: - Node.js version 10.24.1 - Ubuntu 20.04 - Install the NPM package via `npm install pulsar-client@1.8.0-rc.2` - Verify the producer and consumer.
Thanks, Baodi Shi > 2022年12月30日 15:11，Hang Chen <chenh...@apache.org> 写道： > > +1 (binding) > > - Check signatures > - Install from source on ubuntu 20.04 (node version >= 16.18 and npm > version >= 8.19.2) > - Run node producer and consumer to pub-sub messages > > Thanks, > Hang > > Yunze Xu <y...@streamnative.io.invalid> 于2022年12月30日周五 10:54写道： >> >> +1 (binding) >> - Check signatures >> - Install from source >> - Install the NPM package via `npm install pulsar-client@1.8.0-rc.2` >> - Verify the producer, consumer, custom_logger examples with both two >> installation methods bove >> >> ---- >> >> However, I'm still wondering whether we still need to upload the >> `napi-xxx.tar.gz` files? These files seem totally useless for users, >> no matter in verification or using. We should not upload these files >> to our release SVN repo. >> >> Thanks, >> Yunze >> >> On Wed, Dec 28, 2022 at 9:14 PM PengHui Li <peng...@apache.org> wrote: >>> >>> +1 (binding) >>> >>> Verify following the steps from >>> https://github.com/RobertIndie/pulsar-client-node-validation >>> - Start standalone (master branch) >>> - Start consumer (node ./examples/consumer.js) >>> - Start producer (node ./examples/producer.js) >>> - The consumer can receive the messages >>> >>> Regards, >>> Penghui >>> >>> >>> On Wed, Dec 28, 2022 at 1:45 PM Ran Gao <r...@apache.org> wrote: >>> >>>> +1 (non-binding) >>>> >>>> - Checked npm package >>>> https://www.npmjs.com/package/pulsar-client/v/1.8.0-rc.2 >>>> - Checked source code + napi-darwin-unknown-arm64 work on macOS 12.6 (M1 >>>> Pro chip) >>>> >>>> Thanks, >>>> Ran Gao >>>> >>>> On 2022/12/27 08:29:35 Zike Yang wrote: >>>>> Hi everyone, >>>>> >>>>> This is the second release candidate for the Apache Pulsar Node.js >>>>> client, version 1.8.0. >>>>> >>>>> It fixes the following issues: >>>>> https://github.com/apache/pulsar-client-node/milestone/13?closed=1 >>>>> >>>>> Please download the source files and review this release candidate: >>>>> - Download the source package, verify shasum and asc >>>>> - Follow the README.md to build and run the Pulsar Node.js client. >>>>> >>>>> The rc package has been published to the npm registry: >>>>> https://www.npmjs.com/package/pulsar-client/v/1.8.0-rc.2 >>>>> You can install it by `npm i pulsar-client@1.8.0-rc.2` and verify the >>>> package. >>>>> >>>>> The vote will be open for at least 72 hours. It is adopted by majority >>>>> approval, with at least 3 PMC affirmative votes. >>>>> >>>>> Source files: >>>>> >>>> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-node/pulsar-client-node-1.8.0-candidate-2/ >>>>> >>>>> Pulsar's KEYS file containing PGP keys we use to sign the release: >>>>> https://dist.apache.org/repos/dist/dev/pulsar/KEYS >>>>> >>>>> SHA-512 checksum: >>>>> >>>> 80f9de8ca73b9a0bc7d083c6ba92e86721d381aa0689858270e074ff505f887533c40c5625b85a8b0943ced352e93eaafe67eb9bcb5afefadb4bd29b594620c4 >>>>> pulsar-client-node-1.8.0.tar.gz >>>>> >>>>> The tag to be voted upon: >>>>> v1.8.0-rc.2 >>>>> https://github.com/apache/pulsar-client-node/releases/tag/v1.8.0-rc.2 >>>>> >>>>> Please review and vote on the release candidate #2 for the version >>>>> 1.8.0, as follows: >>>>> [ ] +1, Approve the release >>>>> [ ] -1, Do not approve the release (please provide specific comments) >>>>> >>>>> Thanks, >>>>> Zike Yang >>>>> >>>>
