Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread WenZhi Feng
I'm good to only revert from branch-4.0 too. Thanks, Wenzhi Feng. On 2025/06/19 00:36:18 PengHui Li wrote: > > the main problem is that this kind of optimization should never have been > cherry-picked into a stable branch. > > > We should be way more strict in onl

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread WenZhi Feng
Hi Penghui, Thanks for your reply and the evidence provided. We can fix this problem by improving the implementation of method `getNumberOfDelayedMessages()`, which is a simple patch. I can help to do this. thanks, Wenzhi Feng. On 2025/06/18 23:26:08 PengHui Li wrote: > Hi Wenzhi, > &

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread WenZhi Feng
-1 until much clearer proof is shown. On 2025/06/18 22:26:26 PengHui Li wrote: > Hi team, > > I am writing to propose an urgent revert of PR #23611 > > - https://github.com/apache/pulsar/pull/23611 > > *Reason for Revert:* > > This PR has introduced a significant performance regression in the

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread WenZhi Feng
based solely on suspicion. Thanks, Wenzhi Feng. On 2025/06/18 22:26:26 PengHui Li wrote: > Hi team, > > I am writing to propose an urgent revert of PR #23611 > > - https://github.com/apache/pulsar/pull/23611 > > *Reason for Revert:* > > This PR has introduce

Re: New PMC member: Zixuan Liu

2025-05-05 Thread WenZhi Feng
Congratulations! Best Regards, Feng Wenzhi On 2025/05/02 11:04:39 Lari Hotari wrote: > The Project Management Committee (PMC) for Apache Pulsar > is delighted to announce that Zixuan Liu has joined the PMC! > > Zixuan has been an active contributor to Apache Pulsar, particularly > focusing on im

Re: Call for projects and mentors for OSPP 2025

2025-04-10 Thread WenZhi Feng
Project Name: Optimize NegativeAck feature of Pulsar C++/Go Client. Project Mentor: Feng Wenzhi Mentor Name: Feng Wenzhi Mentor Email: thetumb...@apache.org Project Description: Pulsar provides sdk in many promgaming language, like Java, C++, Go... The most cutting-edge features and optimizatio

Re: [VOTE] PIP-409: support producer configuration for retry/dead letter topic producer

2025-03-02 Thread WenZhi Feng
The vote is approved with 4 binding votes and close now. Votes: - Yunze Xu(binding) - Baodi Shi(binding) - Yubiao Feng(binding) - Lari Hotari(binding) - Zixuan Liu(non-binding) - Tao Jiuming(non-binding) Thank you all for verifying and voting! Wenzhi Feng. On 2025/03/03 02:45:07 WenZhi Feng

Re: [VOTE] PIP-409: support producer configuration for retry/dead letter topic producer

2025-03-02 Thread WenZhi Feng
Hi, Lari. thanks for your feedback, i reply your comments in the implementation pr. We may close this vote thread and continue the discussion in the pr. Thanks. Wenzhi Feng. On 2025/02/28 14:38:25 Lari Hotari wrote: > +1 (binding), with implementation level detail change suggestion. >

Re: [DISCUSS] Do we need to update the documents for PIP and LTS releases?

2025-02-25 Thread WenZhi Feng
Same confusion about the criterion of PIP. Wenzhi Feng. On 2025/02/26 04:42:27 Yunze Xu wrote: > Hi all, > > I noticed two PRs were merged recently and cherry-picked into > branch-3.0 and branch-4.0, where 3.0 and 4.0 are LTS releases. > > https://github.com/apache/pulsar/

Re: [DISCUSS] Doubt about the widely used Netty Recycler in Pulsar

2025-02-23 Thread WenZhi Feng
Totally agree with this. No more unnecessary complexity into the code base. Wenzhi Feng. On 2025/02/22 09:01:55 Yunze Xu wrote: > Bump this thread again. > > I really suffered from the use of Netty recyclers. It makes code much > really harder to maintain. I also made a bench

Re: [DISCUSS] PIP-408: add maxRetryRequestTimes in ClientConfigurationData and remove duplicate retry logic

2025-02-23 Thread WenZhi Feng
LGTM, i leave some comments in pr. On 2025/02/18 02:05:48 吕泓瑾 wrote: > Dear Apache Pulsar Community, > I would like to propose introducing a configuration property in > ClientConfigurationData through PIP-408,which aims to eliminate redundant > request retry logic between AsyncHttpClient and Async

Re: [VOTE] PIP-407 Add a newMessage API to create a message with a schema and transaction

2025-02-11 Thread WenZhi Feng
+1 nonbinding. On 2025/02/10 18:20:56 Ómar Yasin wrote: > Hi, > > I'd like to start the voting thread for PIP-407: Add a newMessage API to > create a message with a schema and transaction > > Proposal PR: https://github.com/apache/pulsar/pull/23942 > Rendered PIP document: > https://github.com

Re: [VOTE] PIP-399: Fix Metric Name for Delayed Queue

2025-01-12 Thread WenZhi Feng
The vote is approved with 3 binding votes and close now. Votes: - Yubiao Feng(binding) - Lari Hotari(binding) - Yunze Xu(binding) - Zixuan Liu(non-binding) - Yike Xiao(non-binding) Thank you all for verifying and voting! Wenzhi Feng. On 2025/01/11 14:04:59 Lari Hotari wrote: > +1 (bind

Re: [DISCUSS] PIP-399: Fix Metric Name for Delayed Queue

2025-01-03 Thread WenZhi Feng
volves > > changing metirc name and a pip is needed. > > pip link: https://github.com/apache/pulsar/pull/23789 > > implementation link: https://github.com/apache/pulsar/pull/23712 > > > > Thanks, > > Wenzhi Feng(thetumbled) >

Re: [VOTE] PIP-393: Improve performance of Negative Acknowledgement.

2024-12-02 Thread WenZhi Feng
Hi, Pulsar Community. The vote is approved with 2 binding votes and close now. Votes: - Lari Hotari(binding) - Enrico Olivelli(binding) - Zixuan Liu(non-binding) Thank you all for verifying and voting! Wenzhi Feng. On 2024/12/02 07:29:41 Zixuan Liu wrote: > +1 (non-binding) > > O

Re: [DISCUSS] PIP-393: Improve performance of Negative Acknowledgement

2024-11-26 Thread WenZhi Feng
hading dependency of the pulsar, it will be great if you can help to accomplish this pip together. Thanks. Wenzhi Feng(thetumbled) On 2024/11/26 09:01:59 Lari Hotari wrote: > Great work, Wenzhi. > > The PIP-393 document should include the high level plan of avoiding to > increa

Re: [DISCUSS] PIP-393: Improve performance of Negative Acknowledgement

2024-11-25 Thread WenZhi Feng
complexity is 0.163N byte in best case( 0.163/48=0.3% of the origrinal), 4N byte in worst case(4/213=1.8% of the origrinal), which is a huge improvement! Feel free to leave your comments and push this improvement into the pulsar. Thanks, Wenzhi Feng.(thetumbled) On 2024/11/15 08:47:33 thetumbled

Re: [DISCUSS] PIP-391: Enable batch index ACK by default

2024-11-07 Thread WenZhi Feng
+1. On 2024/11/06 12:44:42 Yunze Xu wrote: > Hi all, > > I wrote a PIP (https://github.com/apache/pulsar/pull/23567) to enable > batch index ACK by default. > > From my experiences, the default ACK semantics are really confusing > and it's hard to explain the implementation details to users. Eve

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

2024-07-22 Thread WenZhi Feng
features to apache community, enriching the ecosystem. I think we should find out a good way to realize it. Thanks, Wenzhi Feng. On 2024/07/22 17:40:24 xiangying meng wrote: > Thank you for your feedback, let's further clarify this matter. > > The original design of this proposal is a n

Re: [DISCUSS] Cherry-pick PIP-364: Introduce a new load balance algorithm AvgShedder.

2024-07-17 Thread WenZhi Feng
Hi all, The thread will keep open for 48 hours. If there is no objections,I will perform the cherry-picking. Thanks, Wenzhi Feng. On 2024/07/16 09:43:30 WenZhi Feng wrote: > link: https://github.com/apache/pulsar/pull/22949 > > On 2024/07/16 09:41:17 thetumbled wrote: > >

Re: [DISCUSS] Cherry-pick PIP-364: Introduce a new load balance algorithm AvgShedder.

2024-07-16 Thread WenZhi Feng
e a new load balance algorithm with higher bundle switching > accuracy and stablity. > > Thanks, > Wenzhi Feng.