Hi, Lari. thanks for your feedback, i reply your comments in the implementation pr. We may close this vote thread and continue the discussion in the pr.
Thanks. Wenzhi Feng. On 2025/02/28 14:38:25 Lari Hotari wrote: > +1 (binding), with implementation level detail change suggestion. > > I didn't have a chance to review this before the voting started due to > being busy with urgent Pulsar releases 3.0.10, 3.3.5 and 4.0.3. > I have provided a suggestion to change in an implementation detail. > Instead of using java.util.function.Function, I'd suggest using a > richer interface so that more context parameters can be added besides > the topic name. This pattern would also allow adding more context > parameters later without breaking the API in backwards incompatible > ways. > > This feedback is shared in the review of the implementation PR, > https://github.com/apache/pulsar/pull/24020#discussion_r1975495488. > > I'm looking forward to this improvement which will resolve the long > time issues such as https://github.com/apache/pulsar/issues/19463 and > https://github.com/apache/pulsar/issues/21954. > > Great work, Wenzhi. Thanks for making this happen! > > -Lari > > > On Thu, 27 Feb 2025 at 06:02, thetumbled <wof...@qq.com.invalid> wrote: > > > > Hi, Pulsar Community. > > I would like to start the voting thread for PIP-409: support producer > > configuration for retry/dead letter topic producer. > > pip link: https://github.com/apache/pulsar/pull/24022 > > implementation link: https://github.com/apache/pulsar/pull/24020 > > Discussion Thread: > > https://lists.apache.org/thread/h6jjf9wn2h4zmpjw5zjtnl5ds1r4nknq > > > > Thanks, > > Wenzhi Feng >
