Re: [VOTE] PIP-300: Add custom dynamic configuration for plugins

2023-11-05 Thread Zixuan Liu
Close this vote with 4 +1(binding) and 1 +1(non-binding). Thanks, Zixuan Liu Zixuan Liu 于2023年9月26日周二 10:54写道： > Zixuan Liu 于2023年9月26日周二 10:54写道： > Hi Pulsar Community, > > Voting for PIP-300: https://github.com/apache/pulsar/pull/21127 > Discussion thread: > https://lists.apache.org/thread

Re: [Discuss] Disable `Rebase and Merge` on Pulsar Repo

2023-11-05 Thread Heesung Sohn
Hi, Thank you for the quick resonse. Raised a PR here, https://github.com/apache/pulsar/pull/21517. If there is no other opinion, I guess we can disable it. Thanks, Heesung On Sun, Nov 5, 2023 at 8:14 PM tison wrote: > As it's a low traffic requirement, I agree that we can disable it and > e

Re: [Discuss] Disable `Rebase and Merge` on Pulsar Repo

2023-11-05 Thread tison
As it's a low traffic requirement, I agree that we can disable it and enable it temporarily when necessary. Although it introduces a bit chore commits to toggle the button, due to its low frequency, it should be fine. Best, tison. Heesung Sohn 于2023年11月6日周一 12:07写道： > Hi, > > This is the previ

Re: [Discuss] Disable `Rebase and Merge` on Pulsar Repo

2023-11-05 Thread Heesung Sohn
Hi, This is the previous discussion of why we enabled the `rebase and merge` option. https://github.com/apache/pulsar/pull/20325 The example(https://github.com/apache/pulsar/pull/20321) seems to be a legit case for `rebase and merge.` Maybe we should be just careful(especially when using github

Re: [Discuss] Disable `Rebase and Merge` on Pulsar Repo

2023-11-05 Thread Rajan Dhabalia
I remember, It was always disabled since we open sourced Pulsar. Who enabled it and what was the reason for enabling that option? It's definitely not a good option and we should disable it asap. Thanks, Rajan On Sun, Nov 5, 2023 at 7:36 PM Heesung Sohn wrote: > Hi, > > I recently merged my PR w

[Discuss] Disable `Rebase and Merge` on Pulsar Repo

2023-11-05 Thread Heesung Sohn
Hi, I recently merged my PR without squash by mistake. https://github.com/apache/pulsar/pull/21408 To prevent this human error, can we disable `rebase and merge` option, like below? [image: Screen Shot 2023-11-05 at 7.21.34 PM.png] How to disable Rebase and merge: https://docs.github.com/en/re

Re: [VOTE] PIP-300: Add custom dynamic configuration for plugins

2023-11-05 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Mon, Nov 6, 2023 at 10:47 AM guo jiwei wrote: > > +1 (binding) > > > Regards > Jiwei Guo (Tboy) > > > On Sun, Oct 8, 2023 at 2:13 PM 太上玄元道君 wrote: > > > +1 (no-binding) > > > > > > Zixuan Liu 于2023年9月26日 周二10:54写道： > > > > > Hi Pulsar Community, > > > > > > Voting

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 1

2023-11-05 Thread Yunze Xu
I want to include an important fix (https://github.com/apache/pulsar/pull/21144) for the latest PR in 3.4.0 (https://github.com/apache/pulsar-client-cpp/pull/336). So I will open another candidate after that. Thanks, Yunze On Thu, Nov 2, 2023 at 9:20 PM Baodi Shi wrote: > > +1 (non-binding) > >

Re: [VOTE] PIP-300: Add custom dynamic configuration for plugins

2023-11-05 Thread guo jiwei
+1 (binding) Regards Jiwei Guo (Tboy) On Sun, Oct 8, 2023 at 2:13 PM 太上玄元道君 wrote: > +1 (no-binding) > > > Zixuan Liu 于2023年9月26日 周二10:54写道： > > > Hi Pulsar Community, > > > > Voting for PIP-300: https://github.com/apache/pulsar/pull/21127 > > Discussion thread: > > https://lists.apache.org/t

Re: [DISCUSS] PIP-313 Support force unsubscribe using consumer api

2023-11-05 Thread Rajan Dhabalia
Hi Penghui, Yes, I agree with all your comments and I will update the PIP by adding that information. Thanks, Rajan On Sun, Oct 29, 2023 at 7:17 PM PengHui Li wrote: > Hi Rajan, > > The proposal looks good to me. > The context and the goal are clear. > > I have 2 comments here > > 1. The chang